This was introduced in 436a028086
but was not used there.
It also currently looks unused.
We could go ahead and just remove this now, as anything that wants
to set the $user when the property is removed would still succeed.
But lets adhere to the deprecation policy here.
Change-Id: Id47323bb1ff480a16b46107825ed5f2f861ad976
This was introduced in 9b3128eb2b
but was not used there.
It also currently looks unused, even when grepping for possible
magic usages of 'importer' and "importer".
We could go ahead and just remove this now, as anything that wants
to set the $importer when the property is removed would still succeed.
But lets adhere to the deprecation policy here.
Change-Id: I5ac16dd87a95be6a3cdd4b16988d37d1d6104749
Cleanup from 43d5d3b682
This commit introduces both $fileIsTemp $isTemp
It would appear that the intent was to have one property here
and it looks like both of these are meant to do the same thing.
It also looks as if both public properties are actually unused
(only used by the getter and setters)
As isTemp will now sometimes return true line 766 $autoDeleteSource
will be true in new cases.
As a result $tmpFile->autocollect(); will be called in more cases
Change-Id: I8014172fb9fd7a0e4a89d0872bafdf6c50f92646
It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345"
except where it doesn't, so let's just standardise on the real numbers.
Change-Id: I6f59febaf8fc96e80f8cfc11f4356283f461142a
WikiRevision::getText() was wrongly marked deprecated in 1.21.
This has been fixed.
Bug: T152282
Bug: T61113
Change-Id: I3f0e0f7fe38bd4e2001efbe17cdba6bcc90b036f
Add comment discouraging use of the method. There are no problems
with deadlocks/timeouts in these code paths according to WMF logs.
Change-Id: I5b21cc423df584efa881361063000e01932cc2ea
$wgMaxArticleSize is defined as "maximum article size in kilobytes",
however the way it was being used in WikiImporter and EditPage was
actually allowing 1023 bytes more than the limit. Other code using the
variable was limiting it to the specified value.
Change-Id: I85e4d2146643c5ac65f27cf464a51b28d68440b0
* Check for blank $source variable more properly.
* Avoid use of ugly File::DELETE_SOURCE flag.
* Remove now-unused $flags parameter to uploadOld().
Change-Id: I6bc610cfead0036700b4f9a82e13f2bd9ab10f32
importTextFiles.php can be used to import pages from text files
containing wikitext.
Also, added $userObj to WikiRevision so that it can accept a User
object instead of just a username.
This is a GCI task.
Change-Id: I20eaf2005bdd3d041f55d8c0b108f001c064d638
It seems that when two simultaneous imports of the same page are started,
we get into the situation where $pageId is 0 (or at least something that
is transformed to 0 when inserted into the DB).
I can't reproduce this locally, so I can't tell you *why* this is
happening. But what is important is to stop it from happening.
Bug: T18674
Change-Id: I79406a1ef8e5db9a31f029438f8132ef590216fe