Commit graph

120 commits

Author SHA1 Message Date
Sam Reed
53000baecf Oh noes, moar http:// -> https:// 2011-11-28 15:43:11 +00:00
John Du Hart
2e7d867478 Removed the 'eclipse helper' bit on top of every API module
It's a parctice that dates back to 2006 when the API was first written, and frankly isn't covered by the coding conventions. Same thing with the docblocks, they're all copypasted with some bits changed and don't even make sense if you look at them in the genereated code docs.
I don't feel that any of us depend on this anymore (get a better IDE), so in the inerest of consistancy it's time we said goodbye to it.
2011-11-16 00:17:26 +00:00
Alexandre Emsenhuber
da4edaaf40 Call Linker methods statically 2011-09-16 19:35:14 +00:00
Roan Kattouw
d8a2733757 Make the PROTO_ parameter to wfExpandUrl() explicit in all calls. There are now no calls to wfExpandUrl() in core that rely on PROTO_CURRENT being the default. Also switch to using getCanonicalUrl() for.... rel="canonical" :D (I picked the right name, I KNEW IT) 2011-08-19 15:46:08 +00:00
Sam Reed
a5628f5734 Based on diff to wikia, set more functions consistently public rather than protected 2011-08-17 22:24:21 +00:00
Roan Kattouw
fbdba8b26f Revert r93802 per CR. Will avoid cache pollution by splitting the cache instead 2011-08-03 07:54:23 +00:00
Roan Kattouw
541aa4cbdd Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() has a flag for this 2011-08-03 07:05:21 +00:00
Sam Reed
d5e46f9614 Followup r92396
More modules documented, pretty much only action=query&list= to be done (ie links added where documentation pages exist already)
2011-07-17 16:51:11 +00:00
Roan Kattouw
7b8b23e8b4 Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so they become fully-qualified even if they were originally protocol-relative 2011-07-13 01:27:07 +00:00
Sam Reed
bdf84cb20e Swap else if for elseif
Trimming trailing whitespace also

Doing in 3 commits, so hopefully reviewable in CR...
2011-06-17 16:03:52 +00:00
Sam Reed
202f4d7443 Fixup error message
Remove {} (documentation tweaks)

Remove whitespace
2011-06-05 23:44:37 +00:00
Sam Reed
f4b92d6b4b Add missing word to r89505 2011-06-05 15:12:38 +00:00
Sam Reed
ef6afb5d9e Tweak documentation
Add braces
2011-04-29 23:34:37 +00:00
Chad Horohoe
783d4e0862 Remove @static from all over the place. That's what the static keyword is for, this being PHP5 and all 2011-04-21 00:07:09 +00:00
Brian Wolff
74f16767e7 Merge to trunk everything in img_metadata branch.
Hope I did this in an ok fashion. svn merge --re-integrate was giving me issues
so I just essentially over-wrote my working copy with the version at img_metadata.
2011-04-16 01:23:15 +00:00
Sam Reed
ea056f5171 Fixup a few undefined variables and alike while checking REL1_17 2011-04-04 21:13:34 +00:00
Bryan Tong Minh
100ecff40e Get the thumbmime from the handler instead of guessing it with UnregisteredLocalFile. 2011-04-02 14:49:12 +00:00
Sam Reed
9818053bd3 * (bug 27589) list=allimages&aiprop=archivename is useless
Followup r84433

Add way to filter returned properties/descriptions
2011-03-21 23:51:26 +00:00
Sam Reed
db3698860a Start of bug 27586/bug 27589
Turn properties into a filterable key/value pair, but leave exisiting wrapper methods in place for the moment

Will finish it off later
2011-03-20 23:50:59 +00:00
Bryan Tong Minh
2c145e77b0 Follow-up r83286: detabify description for mediatype 2011-03-05 15:14:49 +00:00
Bryan Tong Minh
6b70a9f121 (bug 27590) prop=imageinfo now allows querying the media type 2011-03-05 14:56:49 +00:00
Sam Reed
dcda4332c9 Tweak some documentation
Add some braces

Explicitally define a variable
2011-02-27 00:40:06 +00:00
Sam Reed
66d3616fc6 Followup r82810, r82813, r82814
Only display hidden stuff if any vaguely related property is set
2011-02-25 21:41:19 +00:00
Sam Reed
3f3e6617a4 Fix double indenting 2011-02-25 20:24:08 +00:00
Sam Reed
19e698b82c One minor followup to r82810
return $vals; early, rather than indenting all of the code another level
2011-02-25 20:22:54 +00:00
Brian Wolff
a1eb4a0973 (follow-up r82810) Address Reedy's comments on irc. 2011-02-25 20:16:19 +00:00
Brian Wolff
c09deaa426 (bug 27715) Make imageinfo api module respect revDelete.
This treats metadata and similar properties to be deleted if the file is deleted, since they
are derived from the file, and i know examples of where the file was deleted to hide sensitive
data in exif. Does still show the file size if file is deleted, because that is what is done
in interface. Follows what ApiQueryLogEvents does and outputs userhidden="" if the user cannot
be displayed due to being hidden.

Due to this bug, all the secret oversight cabal info could be visible for images, so probably
should be merged into wmf stuff soon as possible.
2011-02-25 19:51:37 +00:00
Sam Reed
442bec4f9b Commit stuff from my w/c
Remove white line

Make second if else if (they're opposites)
2011-02-25 16:53:33 +00:00
Sam Reed
14e998aae5 Followup r82509, prefix the code for urlwidth too 2011-02-20 13:59:40 +00:00
Sam Reed
adf3254f47 Remove error duplication in ApiQueryStashImageInfo by using non hardcoded prefix in ApiQueryImageInfo 2011-02-20 13:51:24 +00:00
Sam Reed
7906fde17e * (bug 27554) Update api information text to reflect change in bug 26125 2011-02-19 19:52:08 +00:00
Sam Reed
fa64025161 More parameter documentation 2011-02-19 00:30:18 +00:00
Bryan Tong Minh
a65582f4e8 Follow-up r82049: Fix strict comparison because MediaHandler::parseParamString() is not guaranteed to use intval() on the width and height parameters.
Add __METHOD__ to wfDebug() call.
2011-02-13 20:38:05 +00:00
Brian Wolff
fc5df5e52d (follow-up r81558) Per suggestion, make this use media handler's getParamString/parseParamString
Additionally, rename makeThumbParam back to getScale since that makes more sense now.
Also update the version number used in ForeignAPIRepo user-agent, since this is kind of significant change.
2011-02-13 07:30:49 +00:00
Bryan Tong Minh
0680ff6df2 Follow-up r81971: Can't use $this->setWarning() in static context, so append the error to the imageinfo array instead 2011-02-12 14:49:34 +00:00
Bryan Tong Minh
de9b4fb463 Follow-up r81971: Fix error handling 2011-02-11 15:42:28 +00:00
Bryan Tong Minh
290e4486a6 * (bug 27199) Thumbnail urls can be fetched for old files as well 2011-02-11 15:40:39 +00:00
Bryan Tong Minh
b6688f5b02 Follow-up r81558: Only raise a warning if no image handler could be found 2011-02-11 15:31:52 +00:00
Platonides
8ce7093775 Use of undefined constant h in line 250. Follow up to r81558 2011-02-08 22:08:58 +00:00
Sam Reed
41c35b3aa4 * (bug 27205) aiprop=metadata and aiprop=parsedcomment need help text
Refactored code out to reduce duplication (and hence, mismatches like this)
2011-02-06 23:59:03 +00:00
Brian Wolff
ec2af084d2 (bug 26548) Make multi-paged documents (PDFs) work with ForeignAPIRepo (aka InstantCommons).
This adds a new parameter to the query=imageinfo (and query=stashimageinfo) that takes rendering
parameters other than width and height. This could be page for pdf's and DjVu, or thumbtime for ogg's, etc.
Syntax is &iiurlparam=param1=value1|param2=value2|... I'm not sure if that really fits with the normal way
of doing things in the api, but couldn't think of anything better since the parameters are arbitrary.

I also noticed that some of the pre-existing error codes in query=imageinfo seem to duplicate the module prefix. I'm
not sure what the deal with that is, but i did not follow that example in the new error codes i introduced.

Note: In order for this to work, both the foreign repo and the local wiki have to be running this code.
2011-02-05 08:49:48 +00:00
Sam Reed
e0373cc450 Per CR on r68482, fix adss to add
Also remove trailing whitespace in files
2010-12-30 00:56:30 +00:00
Sam Reed
6309c920dd Delete all the "API for MediaWiki 1.8+" comments
Add since to ApiQueryQueryPage
2010-12-22 20:52:06 +00:00
Roan Kattouw
b81ac8ea52 Improve some of the descriptions added in r68482 2010-12-14 11:47:13 +00:00
Bryan Tong Minh
3406091152 (bug 26125) prop=imageinfo&iiprop=size now returns the page count if the file is a multi-page file
Also fix blatant lie in File::pageCount()
2010-11-27 18:51:17 +00:00
Sam Reed
6706fcb62a Fixed up some doxygen warnings 2010-11-13 00:32:54 +00:00
Neil Kandalgaonkar
902995cb1d core changes for UploadWizard (merged from r73549 to HEAD in branches/uploadwizard/phase3) 2010-11-03 04:32:41 +00:00
Bryan Tong Minh
7f71612ac8 Added iiprop=parsedcomment to prop=imageinfo, similar to prop=revisions 2010-10-23 15:40:55 +00:00
Sam Reed
f0f79d19c2 Add missing @'s to r73753, document return type 2010-09-25 17:17:27 +00:00
Sam Reed
ee40f73227 Remove some unused keys from foreach
Documentation tweaks
2010-09-25 16:56:03 +00:00