Commit graph

8 commits

Author SHA1 Message Date
Thalia
6909b2016e Always allow local IP actors to be created when importing
Why:

* Following T345578, the ActorStore throws an error on
  attempting to create an actor whose name is their IP address
  if temporary accounts are enabled.
* For the specific case of importing old revisions, we need to
  be able to create new actors whose name is their IP address,
  while still generally disallowing it.

What:

* Add $allowCreateIpActors flag to ActorStore, and check for
  it during actor name validation.
* Set the flag from ActorStoreFactory::getActorStore depending
  on whether temporary users are enabled.
* Add ActorStoreFactory::getActorStoreForImport, which sets
  flag to true.
* Add RevisionStoreFactory::getRevisionStoreForImport, which
  uses getActorStoreForImport. Use this from classes handling
  imports, so that IP actors can always be created.
* Add $forImport flag on ActorMigration, since RevisionStore
  uses an actor store obtained via ActorMigration.

Bug: T354207
Change-Id: I0715bd0d23089fd8156e579913e6e823089809be
2024-01-29 19:35:14 +00:00
jenkins-bot
c1f3f1a4d5 Merge "ActorMigration: Drop support for anything but revision table" 2024-01-22 15:45:40 +00:00
Alexander Vorwerk
0b8b61b9fe ActorMigration: Stop injecting useless stage value
Change-Id: I94fa756733b2d0c199131523e15d650cd953daec
2024-01-20 11:00:38 +00:00
Alexander Vorwerk
cd298545e0 ActorMigration: Drop support for anything but revision table
Change-Id: I3a086fc5a10fda163d07904340c23ed6256b83b7
2024-01-20 11:38:03 +01:00
Alexander Vorwerk
0887b9ffbc ActorMigration: Drop temp table code
There is no actor migration left for which a temp table is needed.

Bug: T215466
Change-Id: I4e85b0a8e05323263a44454691ef3e6963aad3ab
2024-01-19 00:27:54 +01:00
James D. Forrester
418c6c3820 Follow-up cb18d10: Add in-code comment on aliases for when they were added
Change-Id: I007e725a6a2255be959d60ef2cf7d008e8a437b6
2023-08-28 14:37:45 -04:00
Amir Sarabadani
1f74dff1fb rdbms: Switch LBFactory::getReplicaDatabase to narrow IReadableDatabase
When it's only reading, it should only rely on read methods.

Update a few callers in ChangeTags and ActorStore-related code while
at it.

Bug: T326274
Change-Id: I78dd5cbef2d480d23ba2955555421224770d474b
2023-02-28 16:06:35 +00:00
Amir Sarabadani
cb18d1007e Reorg: Move ActorMigration and ActorMigrationBase to user/
This may seem a bit weird but anything else related to actor is already
under user/ including ActorCache, ActorNormalization, ActorStore and
ActorStoreFactory.

Bug: T321882
Change-Id: I7072b374bba7a0cd9d905e399c822bf30bd5c0d8
2022-12-16 13:44:33 +01:00
Renamed from includes/ActorMigration.php (Browse further)