Initally used a new sniff with autofix (T333745),
but some provide are defined non-static in TestBase class
and need more work to make them static in a compatible way
Bug: T332865
Change-Id: I889d33424f0c01fb26f2d86f8d4fc3de3e568843
- MediaWiki no longer supports PHP versions that are old enough to
include the null terminator in the sort key, so there's no need to
remove it using rtrim(). See T137642 for more information.
- Simplify prefix comparison by setting the initial value of $prev to
the empty string rather than false. A PHP array key can only be an
integer or string, so there's no other reason to check for false.
- $letterMap is unset to "Reduce memory usage before caching", which
made sense at the time (r80443 / eaeea84b44). In 2a86b5a17a, the
code was refactored such that $letterMap goes out of scope before we
save to the cache, so unset() should no longer be needed.
Change-Id: Id99ab3a6a29d037912f4ab3e817dba52d2ac24e8
Use ObjectFactory specs for collation classes
Avoid the language construction in the factory class,
make it a detail of the implementation of each class
Follow-Up of Ifc96f851e6091ce834dbaf0e91695c648a42169c
Bug: T286079
Change-Id: Ib581f64aec8619986fb8dd49ceee0524d59a1b84
Add public, protected or private to function missing a visibility
Enable the tests folder for the phpcs sniff
Change-Id: Ibefce76ea9984c47e08c94889ea2eafca7565e2c
These comments do not add anything. I argue they are worse than having
no comments, because I have to read them first to understand they
actually don't explain anything. Removing them makes room for actual
improvements in the future (if needed).
Change-Id: Iee70aad681b3385e9af282d5581c10addbb91ac4
This is based on a numeric uppercase collation. Bashkir characters
will be remapped to the private use area for the purpose of sorting.
Bug: T162823
Change-Id: I65f1af0b57ff6ded7d464e39efd401f178a3519e
2017-05-10 04:17:46 +00:00
Renamed from tests/phpunit/includes/CollationTest.php (Browse further)
