Commit graph

19 commits

Author SHA1 Message Date
Platonides
eda718909c Remove unused globals. 2010-10-31 15:35:01 +00:00
Roan Kattouw
6d4d8641f6 (bug 25339) Allow specifying separate base paths for local and remote paths in ResourceLoaderFileModule::__construct(). Extensions can use this to properly point the resource loader to their resources in a way that doesn't depend on the extensions/ directory being a subdirectory of phase3/ on the filesystem and that respects $wgExtensionAssetsPath. Also converted all extensions using ResourceLoader to use this approach, except MWEmbed which uses way more indirection building its module registrations than I can deal with after midnight.
What actually happens here
* Add $localBasePath, $remoteBasePath params to the FileModule constructor, defaulting to $IP and $wgScriptPath respectively
* Add getLocalPath() and getRemotePath(), which use this information to build a proper FS or URL path for a file
* Make readScriptFiles() non-static so it can use these functions
* Run every single file path we use through either getLocalPath() or getRemotePath() as appropriate
** Except file dependencies, these are already prefixed. Our inability to give them special treatment caused bugs earlier
* Kill prefixFilePathList() and resolveFilePath(), no longer needed
2010-10-27 22:22:10 +00:00
Roan Kattouw
1fb4cc1f13 Fix regression introduced by doing data URL embedding early causing file dependencies for CSS not to be registered: the data URL embedding had modified the URL to the point where getLocalFileReferences() doesn't recognize it anymore. This is a quick&dirty fix registering dependencies in $this->fileDeps just before each remap() call 2010-10-27 19:59:10 +00:00
Trevor Parscal
46409b75fa Fixes comment mistakes in r75107 2010-10-26 20:17:32 +00:00
Trevor Parscal
0f94d0e00d Fixed missing break; in ResourceLoaderFileModule::__construct, and added extra error checking to it's input arrays. 2010-10-21 22:34:26 +00:00
Trevor Parscal
d7de31b5c3 ResourceLoaderFileModule now uses mediaWiki.loader.load to load scripts in debug mode. 2010-10-21 21:25:27 +00:00
Trevor Parscal
1f0e578130 Changed the way that ResourceLoaderFileModule and mediaWiki.loader work in debug mode. As of this commit, in debug mode, ResourceLoaderFileModule will emit code which appends a a script tag for each raw JavaScript file in the module, instead of the concatenated code of the module's scripts. This eliminates the need to disable batch loading on the client in debug mode, since it effectively supersedes the effect of turning batch loading off. 2010-10-21 01:03:46 +00:00
Trevor Parscal
f5565355b9 Improves on r75055, improving comment accuracy, and removing useless casting. 2010-10-20 20:56:33 +00:00
Trevor Parscal
cdd0fb65c2 * Improves on r75054 and r75036 by adding comments and renaming variables
* Fixes issue cased by creating a file module that only contains a list of dependencies.
2010-10-20 20:43:30 +00:00
Roan Kattouw
e9ff9c0f58 Include $IP in path passed to remap() so filesystem access will work properly 2010-10-20 19:13:43 +00:00
Trevor Parscal
0caccb3d28 Whitespace, comments and general cleanup. 2010-10-20 00:22:25 +00:00
Trevor Parscal
0c2d86685c Some cleanup work 2010-10-19 23:47:56 +00:00
Trevor Parscal
39b695ab1f Whitespace adjustments 2010-10-19 23:02:15 +00:00
Trevor Parscal
4b9b2ca889 Fixed remaning use of $this->loaders to use the new naming of $this->loaderScripts 2010-10-19 23:00:52 +00:00
Trevor Parscal
4f09b0fa47 Fixed case where tryForKey can sometimes not return an array 2010-10-19 22:53:53 +00:00
Trevor Parscal
f3388ec614 Refactored ResourceLoaderFileModule, most notably removing the set* methods, which are not in use at the moment, and should only be added when we have a use case for them (API bloat = bad) 2010-10-19 22:48:52 +00:00
Trevor Parscal
fb64a62306 Fixed ResourceLoaderFileModule constructor - collated lists were not being prefixed properly. Also did some renaming to improve consistency. 2010-10-19 20:59:23 +00:00
Trevor Parscal
70bae52c12 Part 2 of 2, moved ResourceLoader*Module classes to their own files - this commit removes the non file specific code. 2010-10-19 18:31:09 +00:00
Trevor Parscal
032ef610dd Part 1 of 2, moving ResourceLoader*Module classes to their own files - this commit copies the ResourceLoaderModules.php file to each of the new files, as to maintain revision history. The next revision will remove non file specific code. 2010-10-19 18:25:42 +00:00