Thijs/wiki.techinc.nl

Fork 0

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	1048db795b	API tests: Assert error codes, not error messages Error messages are not guaranteed to be stable, and these tests prevent us from improving them. Error codes are supposed to be stable, so we should be asserting that they do not change (especially since many of them are dynamically generated by the dodgy code in ApiMessageTrait). Introduce helpers assertApiErrorCode() and expectApiErrorCode() to be used instead of the usual PHPUnit assertions/expectations for this case. Change-Id: I752f82f29bf5f9405ea117ebf9e5cf70335464ad	2023-04-26 19:36:29 +02:00
Daimona Eaytoy	ef5ab69629	Replace setExpectedException with two args Find: ^(\t*)(\$this->)setExpectedException\(\s+(\\?[a-z\\]+::class),\s+('(?:[^'\\]\|\\')+'\|"(?:[^"\\]\|\\")+")\s+\); Replace: $1$2expectException( $3 );\n$1\$this->expectExceptionMessage( $4 ); +broke long lines manually. Bug: T192167 Change-Id: I5557b4372625def55a53ac637c2f980f51f12933	2019-10-05 16:14:05 +00:00
Aryeh Gregor	05d01e51ca	Test ApiDisabled.php Locally this reports that everything is covered, although the get*() functions are not registering at all (white backgrounds). Change-Id: I73fabfb33b329dc3416368fda52d35f7ee6a4a18	2018-03-20 18:01:07 +02:00

Author

SHA1

Message

Date

Bartosz Dziewoński

1048db795b

API tests: Assert error codes, not error messages

Error messages are not guaranteed to be stable, and these tests
prevent us from improving them.

Error codes are supposed to be stable, so we should be asserting
that they do not change (especially since many of them are
dynamically generated by the dodgy code in ApiMessageTrait).

Introduce helpers assertApiErrorCode() and expectApiErrorCode()
to be used instead of the usual PHPUnit assertions/expectations
for this case.

Change-Id: I752f82f29bf5f9405ea117ebf9e5cf70335464ad

2023-04-26 19:36:29 +02:00

Daimona Eaytoy

ef5ab69629

Replace setExpectedException with two args

Find: ^(\t*)(\$this->)setExpectedException\(\s+(\\?[a-z\\]+::class),\s+('(?:[^'\\]|\\')+'|"(?:[^"\\]|\\")+")\s+\);

Replace: $1$2expectException( $3 );\n$1\$this->expectExceptionMessage( $4 );

+broke long lines manually.

Bug: T192167
Change-Id: I5557b4372625def55a53ac637c2f980f51f12933

2019-10-05 16:14:05 +00:00

Aryeh Gregor

05d01e51ca

Test ApiDisabled.php

Locally this reports that everything is covered, although the get*()
functions are not registering at all (white backgrounds).

Change-Id: I73fabfb33b329dc3416368fda52d35f7ee6a4a18

2018-03-20 18:01:07 +02:00

3 commits