Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
116720 commits 1 branch 0 tags 744 MiB
Commit graph

11 commits

Author SHA1 Message Date
Tim Starling
5e30a927bc tests: Make some PHPUnit data providers static 
Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.

Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.

Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
 2023-03-24 02:53:57 +00:00
James D. Forrester
ad06527fb4 Reorg: Namespace the Title class 
This is moderately messy.

Process was principally:

* xargs rg --files-with-matches '^use Title;' | grep 'php$' | \
  xargs -P 1 -n 1 sed -i -z 's/use Title;/use MediaWiki\\Title\\Title;/1'
* rg --files-without-match 'MediaWiki\\Title\\Title;' . | grep 'php$' | \
  xargs rg --files-with-matches 'Title\b' | \
  xargs -P 1 -n 1 sed -i -z 's/\nuse /\nuse MediaWiki\\Title\\Title;\nuse /1'
* composer fix

Then manual fix-ups for a few files that don't have any use statements.

Bug: T166010
Follows-Up: Ia5d8cb759dc3bc9e9bbe217d0fb109e2f8c4101a
Change-Id: If8fc9d0d95fc1a114021e282a706fc3e7da3524b
 2023-03-02 08:46:53 -05:00
Reedy
8c39aab84b Remove or replace usages of "sanity" 
Bug: T254646
Change-Id: Ib192dc5704a14d02c7c374d0ab29bac55c5df24a
 2021-11-21 19:35:49 +00:00
DannyS712
31676abea5 Add DummyServicesTrait::getDummyInterwikiLookup 
Replacing the mock InterwikiLookup used in
MediaWikiTitleCodecTest revealed that that test was,
because of the mock not behaving correctly, testing the
wrong thing - interwiki prefixes are *not* case sensitive,
and are always converted to lowercase in the actual
ClassicInterwikiLookup. Fixed those expectations.

Change-Id: I242431e88860b7700a9f93f77a0fe195fd748800
 2021-05-05 10:57:59 -07:00
Thiemo Kreuz
b95a07380a Remove meaningless ->expects( $this->any() ) from all tests 
It is not entirely meaningless. It might be an indicator that
the number of calls to a method is intentionally unlimited.
This is similar to e.g. an @inheritDoc PHPDoc comment that
marks a method as being "intentionally undocumented".

However, what's the meaning of being "intentionally
unconstrained"? Let's just not have any constraint then.

I feel all these ->expects( $this->any() ) bloat the test
code so much that it's never worth it.

Change-Id: I9925e7706bd03e1666f6eb0b284cb42b0dd3be23
 2021-04-23 11:58:58 +02:00
daniel
e2b732cd86 Linker: userLink() should not explode on malformed user names. 
Bug: T232451
Change-Id: Ibaea91767a1882d8246254ea3edc0c41d703e678
 2021-02-02 10:45:58 -08:00
addshore
959bc315f2 MediaWikiTestCase to MediaWikiIntegrationTestCase 
The name change happened some time ago, and I think its
about time to start using the name name!
(Done with a find and replace)

My personal motivation for doing this is that I have started
trying out vscode as an IDE for mediawiki development, and
right now it doesn't appear to handle php aliases very well
or at all.

Change-Id: I412235d91ae26e4c1c6a62e0dbb7e7cf3c5ed4a6
 2020-06-30 17:02:22 +01:00
Brad Jorsch
5d9bc35dd6 ExternalUserNames: Handle otherwise-usable names with lowercase first letter 
ExternalUserNames::applyPrefix() should probably apply the prefix to
otherwise-usable names that would fail User::isUsableName() only because
of a lowercase first letter (or other non-normalization that
User::getCanonicalName() fixes).

Bug: T211450
Change-Id: If695432d6b683442bd74ee160064c950b09c924a
 2020-02-03 15:43:52 -05:00
Thalia
a81ffbc57e Set content language for test to en to ensure it passes 
Change-Id: I5bff92e304795ac4f76fd07f12f3598fbf816f39
 2019-06-03 13:44:11 -04:00
Amir Sarabadani
15cff85748 Add ExternalUserNames::getLocal() to get local part of username 
Bug: T189320
Change-Id: I99908ced218c45ecbb23f390f065170292f153b4
 2018-03-09 20:53:54 +01:00
Amir Sarabadani
dc4089b268 Move methods for handling external usernames to a dedicated class 
This makes things centralized to reduce maintenance cost and also
enables me to use this methods in Wikibase to handle RC injection

Bug: T185034
Change-Id: Ic8c602e316144ccb5b05c69a0cc607cd53e38912
 2018-01-18 21:02:49 +01:00