Commit graph

5165 commits

Author SHA1 Message Date
Thiemo Mättig
ef470ebf7f Remove @param comments that literally repeat what the code says
These comments do not add anything. I argue they are worse than having
no comments, because I have to read them first to understand they
actually don't explain anything. Removing them makes room for actual
improvements in the future (if needed).

Change-Id: Iee70aad681b3385e9af282d5581c10addbb91ac4
2018-01-10 14:14:26 +01:00
jenkins-bot
c9c12a28a6 Merge "Add @covers tags to database tests" 2017-12-28 11:08:09 +00:00
jenkins-bot
5d743b0381 Merge "tests: Complete test coverage of HtmlArmor" 2017-12-28 11:05:51 +00:00
jenkins-bot
41a6af704e Merge "Remove useless StatusTest::testCanConstruct()" 2017-12-28 10:42:14 +00:00
jenkins-bot
ec26fb42a9 Merge "Remove resolved todo from MWNamespace test" 2017-12-28 10:40:10 +00:00
jenkins-bot
fb55cef29a Merge "Improve @covers for TemplateParserTest" 2017-12-28 10:34:47 +00:00
jenkins-bot
df3e3f44cb Merge "maintenance: Add unit test for Benchmarker class" 2017-12-28 09:22:01 +00:00
Kunal Mehta
bb9e1c1aa9 tests: Complete test coverage of HtmlArmor
Change-Id: I3c50ea56721226ddb37bcf4778a7d71e9b56d0f7
2017-12-28 00:56:12 -08:00
Kunal Mehta
075ab54a44 Improve @covers for TemplateParserTest
The current @covers tags for TemplateParserTest are an incomplete call
stack for TemplateParser::processTemplate, and miss out on some
functions that are called. Those functions could be repeated in @covers
tags, but it would be burdensome to keep it up to date.

Instead, just use class level @covers for the whole test case. This also
takes care of the previously uncovered testEnableRecursivePartials().

Change-Id: I475ceba26b70a115b40d7735834a07f298f7bf99
2017-12-28 08:53:31 +00:00
Kunal Mehta
9e7e12252a Add @covers tags to database tests
Change-Id: Ic46bb961b41856d390ffe0e3632790c506f5655b
2017-12-28 08:53:23 +00:00
Kunal Mehta
54ba980cf8 Remove resolved todo from MWNamespace test
The todo was added by Addshore in aea1b27db0 at the same time he added
all the @covers tags, so it appears to all be resolved.

Change-Id: I03d866fdd1ca382ca2b1699e01a0dd9a28eef1ec
2017-12-28 08:53:12 +00:00
Kunal Mehta
99d73dc903 Remove useless StatusTest::testCanConstruct()
Neither Status, nor StatusValue have constructors, so there's not much
point testing whether the object can be constructed.

Change-Id: I170940889b5da5198ef4576d04786f84c293dd01
2017-12-28 08:53:04 +00:00
Timo Tijhof
25ce819e1c maintenance: Add unit test for Benchmarker class
Change-Id: I3f835fc07741fd42b8adb5b019f72589429cc14f
2017-12-27 22:15:21 +00:00
Timo Tijhof
cd9f2f44e5 phpunit: Remove outdated comment about calling of LinkCache::clear()
This is actually being called now, from resetDB() between tests.

Change-Id: I5aa15ce3fd57b6fc90b424fde8691ff33c7ddf45
2017-12-27 21:52:44 +01:00
Kunal Mehta
14e7d5401c Add tests for TextboxBuilder
Change-Id: I305e0bce902fb027bf02cc8a28e8846808f6437c
2017-12-27 17:49:21 +00:00
Kunal Mehta
4de7b0a542 Add @covers tags to ContentHandler tests
Change-Id: I4d0994e91f63a0921343f34ef81a82463b4ab969
2017-12-27 17:48:56 +00:00
Kunal Mehta
356c6ae993 Add @covers tags to jobqueue tests
Change-Id: I030634ac87139011e5b3d461064a8c10f10cea84
2017-12-27 17:47:30 +00:00
Kunal Mehta
01f7176c8b Add @covers tags to HTMLForm test
Change-Id: I41cc4867b071ee9a58a43760fc4a8b301cda558e
2017-12-27 17:47:17 +00:00
Kunal Mehta
2eb14eb453 Add @covers tags to filerepo tests
Change-Id: I696e03f9ab3934b6cd04e88e1d611060846d32a4
2017-12-27 17:44:47 +00:00
Kunal Mehta
247430e9b2 Add @covers tags to LinksUpdate test
Change-Id: I65ebce434f00a42e06be5168acbaa8fbf637995f
2017-12-27 17:44:34 +00:00
Kunal Mehta
389d0a0958 Add @covers tags to includes/debug tests
Change-Id: Ida6562c87204f1680239d0bdbfde4d6fdc9bf748
2017-12-27 17:44:18 +00:00
Kunal Mehta
54640d4d4e Add @covers tags for RevisionStoreDbTest
Change-Id: Ie7ce23d5ad67816c1ae8c2c838f8263fca17b4f8
2017-12-27 17:43:50 +00:00
jenkins-bot
38301f04db Merge "Add @covers tags to miscellaneous tests" 2017-12-27 17:40:45 +00:00
jenkins-bot
6adc1de83d Merge "Add @covers tags to utils tests" 2017-12-27 17:36:14 +00:00
jenkins-bot
103597d408 Merge "Add @covers tags to user tests" 2017-12-27 17:36:12 +00:00
jenkins-bot
e671db3b6a Merge "Add @covers tags to specials tests" 2017-12-27 17:30:27 +00:00
jenkins-bot
7b736d1975 Merge "Add @covers tags to parser tests" 2017-12-27 17:27:03 +00:00
jenkins-bot
e863401c71 Merge "Add @covers tags to page tests" 2017-12-27 17:26:59 +00:00
jenkins-bot
1644b30ef3 Merge "Add @covers tags to objectcache tests" 2017-12-27 17:19:57 +00:00
jenkins-bot
4a6fb0dea3 Merge "Add @covers tags to media tests" 2017-12-27 17:19:28 +00:00
jenkins-bot
a4997d99ed Merge "Add @covers tags to logging tests" 2017-12-27 17:19:25 +00:00
jenkins-bot
8eaee6fd06 Merge "Simplify ApiQueryRecentChangesIntegrationTest" 2017-12-27 12:51:54 +00:00
jenkins-bot
0ed9e8b554 Merge "Integration tests for ApiQueryRecentChanges" 2017-12-27 12:33:27 +00:00
Thiemo Mättig
e02e140e2d Simplify ApiQueryRecentChangesIntegrationTest
This patch does two major things to the newly introduced
ApiQueryRecentChangesIntegrationTest:

* It rips the confusingly complicated assertArraySubsetsEqual appart.

* It removes all wikitext content. Note that no assertion is done on this
content (not even in the test that is about adding a category). The tests
run just fine with automatically generated content. I had to introduce the
$i counter to make sure consecutive edits are done with different content.
Otherwise the later edit is not stored.

Change-Id: Iae585be86f3fd9bff7d2b4b7b218d5b0b4258603
2017-12-27 13:23:17 +01:00
Thiemo Mättig
72fa7b9dfc Fix inconsistent capitalization of different method calls
Change-Id: I9f5b9e59e8cdadf65e80077fe2d3a9822b4592fe
2017-12-27 12:35:13 +01:00
Kunal Mehta
a9960b53be tests: Use checkPHPExtension() instead of re-implementing it
Change-Id: I7f5e8684d556befc0aefa302187c573e7a3cff62
2017-12-25 22:06:37 +00:00
Kunal Mehta
222afabc80 Add @covers tags for Collation tests
Change-Id: I8b0623a6b716acdc9d369349fd4e306dbdc91d18
2017-12-25 21:59:01 +00:00
Amir Sarabadani
b29d4e2789 Integration tests for ApiQueryRecentChanges
It looks big but it's mostly copy from ApiQueryWatchlistIntegrationTest

Change-Id: I96ccd3e2813e77f47a4432ca434c1c6a212d90ea
2017-12-25 14:13:47 +01:00
Kunal Mehta
0c77841534 Add @covers tags to miscellaneous tests
Change-Id: I7e65c1734aef01cd6395ee65204a0158d1635b0c
2017-12-24 23:29:00 -08:00
Kunal Mehta
e1817d72ba Add @covers tags to utils tests
Change-Id: Iee44762696120c63fec986de1da76f12849f5957
2017-12-24 23:29:00 -08:00
Kunal Mehta
ee96c8894a Add @covers tags to user tests
Change-Id: I9ec5644e6b780937492eb5e0ea9e27ebad15ad43
2017-12-24 23:29:00 -08:00
Kunal Mehta
8956885666 Add @covers tags to specials tests
Change-Id: I626155b890580af38c09795b2b31f625fe942358
2017-12-24 23:29:00 -08:00
Kunal Mehta
546980e537 Add @covers tags to parser tests
Change-Id: I7bce04bef5e981fd203ad819882482e72ca3f61b
2017-12-24 23:29:00 -08:00
Kunal Mehta
2c16290785 Add @covers tags to page tests
Change-Id: Iadb7e8697e9992ca281b7dfe70cf832c82e194de
2017-12-24 23:29:00 -08:00
Kunal Mehta
cf0ebed65a Add @covers tags to objectcache tests
Change-Id: I5db623a582a0424f50d939aaa14fe29da9358b4f
2017-12-24 23:29:00 -08:00
Kunal Mehta
699a2f6db4 Add @covers tags to media tests
Change-Id: Ibd3439f677dec5177b53317f113ed2aa8ddc2633
2017-12-24 23:29:00 -08:00
Kunal Mehta
c368a4313b Add @covers tags to logging tests
Change-Id: Ibb14291a75423ddbb7502a5a0ee24ff0c554a876
2017-12-24 23:29:00 -08:00
Kunal Mehta
818e93ed2b Fix @covers in XmlTest
Follows up 389fa13ff8.

Change-Id: I32ddf37b24a6b5162b383260233d616cb49f7ddb
2017-12-24 19:16:26 -08:00
Amir Sarabadani
389fa13ff8 Add tests for several methods of Xml
Added tests for methods: monthSelector, span, buildTable, buildTableRow

Change-Id: I5ca6bb231b5ed95f57f649a92d659245a4852c85
2017-12-25 03:45:32 +01:00
jenkins-bot
073fd06f15 Merge "[MCR] Introduce BlobStoreFactory" 2017-12-24 23:39:58 +00:00