Commit graph

1801 commits

Author SHA1 Message Date
Sam Reed
82dd198876 Followup r83849, fix join to be on indexed user_name 2011-03-14 11:07:58 +00:00
Sam Reed
09c2fbf75e * (bug 27585) add pagecount to list=filearchive 2011-03-13 23:04:51 +00:00
Sam Reed
f507219e11 2011-03-13 22:23:57 +00:00
Sam Reed
4c3fba4f60 Followup r83856
Per BRYAN (;P) don't use a conditional parameter, just die if miser mode and prefix set
2011-03-13 22:12:57 +00:00
Sam Reed
2109e5fc4a * (bug 27020) API: Allow title prefix search of logevents (only when not in miser mode)
Won't work on WMF wiki's as miser mode is enabled, but won't show as an available option either
2011-03-13 21:43:20 +00:00
Happy-melon
0a8a3b452c Further massive rewrite of the blocking frontend: spin out unblocking into a new SpecialUnblock.php. This leaves IPBlockList as, astonishingly enough, a list of blocks... :D 2011-03-13 21:33:52 +00:00
Sam Reed
a5db765083 Fix undefined $p from r83797 2011-03-13 21:33:35 +00:00
Sam Reed
886a70a3f7 Add missing group by from r83849 per Bryan 2011-03-13 19:35:08 +00:00
Sam Reed
a463facbd5 Followup r83843, r83837, per brian, addOption unconditionally replaces ORDER BY etc, so fix that
Simplify addFields call, remove un-needed array for 1 element
2011-03-13 19:28:44 +00:00
Sam Reed
237eb87db4 * (bug 26630) Add api for Special:ActiveUsers
Not sure if this would be better having been done as list=activeusers or something...

Meh, done! :P
2011-03-13 19:07:22 +00:00
Sam Reed
d1d3e34775 Bug 27341 - Add drto param to list=deletedrevs
Tidy code up a little bit
2011-03-13 17:59:27 +00:00
Sam Reed
67dc654a9f * (bug 27203) add fato param to list=filearchive
Cleanup some whitespace also
2011-03-13 17:41:47 +00:00
Sam Reed
f0dc6ef7bb Cleanup/simplify code added to alllinks in r70584 2011-03-13 17:36:31 +00:00
Sam Reed
ec65ff0c11 Fixup a couple more hardcoded module prefixes in help 2011-03-13 17:28:53 +00:00
Sam Reed
92cad959dc Minor followup to r83814, also fix some other existances
Don't hardcode module prefixes (just incase they're subclassed at somepoint... :) )
2011-03-13 17:26:29 +00:00
Sam Reed
cb94b8f191 * (bug 27342) Add audir param to list=allusers 2011-03-13 17:23:45 +00:00
Sam Reed
576129dbd8 * (bug 27340) API: Allow listing of "small" categories 2011-03-13 17:16:07 +00:00
Happy-melon
04aad77ea1 Follow-up r83825: fix fatal in API 2011-03-13 17:02:50 +00:00
Sam Reed
d9dbcf5d34 * (bug 27183) API: Add filter by customisation state for meta=allmessages 2011-03-13 16:36:51 +00:00
Roan Kattouw
64d9832d1f (bug 27965) Paging in list=categorymembers was completely broken. It was paging by cl_from alone, while the index is on (cl_to, cl_type, cl_sortkey, cl_from) and only cl_to is constant. Fixed by paging on (type, sortkey, from), but using type|from|sortkey for clcontinue so any pipe characters in the sortkey are easier to handle. This needs the schema change in r83812 to work correctly, otherwise rows with cl_type=file will be skipped in certain cases. 2011-03-13 10:39:57 +00:00
Sam Reed
e6853e1bfa * (bug 27182) API: Add filter by prefix for meta=allmessages
Patch by Harry Burt (Jarry1250)

Comment tweaked, logic inversed ( so skip == true means we skip ), makes a bit more sense then :)
2011-03-13 00:15:02 +00:00
Sam Reed
e357db3122 * (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in auto generated document, as it is on mw.org
Followup r83797, closing. Adding bit of documentation, + RELEASE-NOTES
2011-03-13 00:07:22 +00:00
Sam Reed
8c6f2012b9 * (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear in auto generated document, as it is on mw.org
where dir = (newer|older)

Will look at doing (asc|desc)(ending)?
2011-03-12 23:39:15 +00:00
Sam Reed
86ce74c75d * (bug 28010) Passing a non existant user to list=users gives internal error
* (bug 27549) action=query&list=users&usprop=groups doesn't show implicit groups if a user doesn't have explicit groups

Also follows up r79556, where I'd done a couple of daft things... (accessing undefined objects)
2011-03-12 22:23:43 +00:00
Happy-melon
7805997608 Divert a river through the Augean Stables that is SpecialBlockip.php.
* Move to SpecialBlock.php, and rename class appropriately
* Complete refactor
* Use HTMLForm in block form.  This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM).
* Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still)
* Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false). 
* revert r40359 (move doMassUserBlock() to core).  No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.
2011-03-12 21:54:35 +00:00
Alexandre Emsenhuber
77b2dc77c9 Follow-up r83080: make ApiUploadTest really work this time 2011-03-11 20:04:17 +00:00
Sam Reed
20548c2596 Fix r83390, need to do where ipb_deleted IS NULL as we're left joining in the table, so it can be null
Duh
2011-03-07 22:58:26 +00:00
Bryan Tong Minh
9ad9f1b353 Follow-up r83461, replace deleted with hidden and reverse the word, e.g. deletedfile->filehidden. Consistency with prop=revision etc. (In Soviet-Russia, file hides you!) 2011-03-07 17:17:57 +00:00
Antoine Musso
8a3dcccbda Remove second parameters from wfEmptyMsg() calls
The second parameter was removed in r64178 and is now useless.
There is probably no need to backport this in 1.17.
2011-03-07 17:10:22 +00:00
Bryan Tong Minh
3d3f61a0ab (bug 27722) list=filearchive now supports revdel
* Adds a condition fa_deleted=0 if the user does not have the suppressrevision rights. This field is unindexed. This should however not be a big problem as files with fa_deleted are rare. Unfortunately this hides files that do not have DELETED_RESTRICTED, but I don't know how bad fa_deleted & DELETED_RESTRICTED = 0 is for performance
* Added deletedfile, deletedcomment, deleteduser and deletedrestricted to the output for what I think are appropriate fa_deleted fields, but it's hard to tell what's corrent without a single line of documentation or even comment in the code. Perhaps somebody can dig up a commit message where the purpose of the constants is explained?
2011-03-07 17:07:10 +00:00
Sam Reed
89656cc42c More documentation
Remove trailing whitespace
2011-03-07 14:59:41 +00:00
Sam Reed
0e38c2cdce Documentation and explicit variable definitions
Followup r80069, swap private to protected
2011-03-07 14:45:11 +00:00
Bryan Tong Minh
29eaa85c82 Kill filtering by hash because the query is unindexed. We need a condition on fa_storage_group, but I'm not sure how index merging will work out. I don't have time to investigate this at the moment, so killing it in its entirety seems the safest option for now. 2011-03-06 22:16:34 +00:00
Bryan Tong Minh
9770ff88f5 Breaking change: remove faminsize/famaxsize because they lead to an unindexed query, which takes a very long time if there are only few rows that match the filter. Introduced in r66168, so luckily only live since 1.17. 2011-03-06 22:03:45 +00:00
Sam Reed
aea7a5a482 Followup r83390
If the user is allowed to view hidden users, put a missing property on all users.

For list=users, do the same, but we can't easily distinguish to other people the difference between "hidden", or "missing", so no reason to do it
2011-03-06 20:51:31 +00:00
Sam Reed
5ad9f48ef8 Fix where ipb_deleted from r83390 2011-03-06 20:38:00 +00:00
Sam Reed
2dc186a1d7 Followup r83399, add back base conversion 2011-03-06 20:20:24 +00:00
Sam Reed
56aefb445f * (bug 27588) list=filearchive&faprop=sha1 returns empty attribute
Refactored code out, to be reused in ApiQueryFilearchive

Simplified too per Bryan on IRC
2011-03-06 20:05:41 +00:00
Sam Reed
f483892c90 * (bug 27717) API's exturlusage module does not respect $wgMiserMode
Implement ApiQueryCategoryMembers style miser mode stuffs
2011-03-06 19:15:07 +00:00
Sam Reed
8c4f349a63 Fix leading whitespace before class ApiQueryUsers 2011-03-06 18:17:28 +00:00
Sam Reed
67d4ee1d26 Followup r83390, change cache modes 2011-03-06 18:16:44 +00:00
Sam Reed
c488abeeb8 * (bug 27897) list=allusers and list=users list hidden users
Refactored addition of block information, and also checked if user is allowed to view hidden user fields
2011-03-06 17:59:08 +00:00
Brian Wolff
8cc82f9954 (follow-up: r83371) Fix variable name typo. $this to $loginForm. 2011-03-06 09:14:04 +00:00
Jack D. Pond
eb811913b8 Fix and Enhance:
1. Fix - previously unresolved possible return value (ABORTED) added to switch
2. Allows a message to be returned when status "ABORTED" instead of just one of existing generic messages.
2011-03-06 05:39:41 +00:00
Bryan Tong Minh
f9a36ee7bf (bug 27018) Added action=filerevert to revert files to an old version. Copied procedure from FileRevertForm, as most of the verification procedure is simple enough to not warrant the effort of writing a dedicated backend.
Further changes:
* Added Status::getErrorsByType() which returns the internal error array untouched
* Added ApiResult::convertStatusToArray() which converts a Status object to something useful for the Api
2011-03-05 17:23:35 +00:00
Bryan Tong Minh
2c145e77b0 Follow-up r83286: detabify description for mediatype 2011-03-05 15:14:49 +00:00
Bryan Tong Minh
51b0552b75 (bug 27587) list=filearchive now outputs full title info 2011-03-05 15:00:23 +00:00
Bryan Tong Minh
6b70a9f121 (bug 27590) prop=imageinfo now allows querying the media type 2011-03-05 14:56:49 +00:00
Brian Wolff
b5c30abacb (bug 27862; follow-up r77714) Make emailuser api module not freak out when SpecialEmailUser returns a status object instead of true. 2011-03-05 03:35:49 +00:00
Sam Reed
01caf960f2 Followup r82060
Calling intval() on an array of integers isn't going to get people very far

simplify logic, and then only do validation if $min or $max are not null
2011-03-03 23:22:39 +00:00