* Remove the scattered enableLB() calls from DatabaseInstaller. The
table creation step should not be responsible for managing the state
of the service container. We have a full installer step called
restore-services, and deferring enableLB() until then only affects
populateInterwikiTable, populateSiteStats, generateKeys and
insertUpdateKeys, which all use local connection management, not
LBFactory. This is a breaking change only for the overrides mechanism,
not for extensions.
* Move DatabaseInstaller::doUpgrade() and its helper outputHandler() to
WebInstaller, since it is specific to web upgrade. Move state
management logic from WebInstallerUpgrade to the new method.
* Fix the excessively narrow width of the upgrade output box, which was
annoying me during testing.
Change-Id: Ica42c4c2e104d5581702e83ae8f9dafadd0053e5
$languageFactory->getLanguage() throws an exception on an invalid
language code. Therefore first validate the values by
$languageNameUtils->isKnownLanguageTag().
Also use getRawVal() instead if getVal() because the UTF-8
normalization is not needed here.
Also use getRawLanguage instead of getLanguage because a replacement of
dummy language codes is not needed here.
Bug: T207981
Change-Id: If4823eca18c5f2dab02368740c3fd95b58738e2b
For detecting the URL parameter css=1 the Unicode normalization of
WebRequest::getVal is not needed.
Change-Id: Ic1af273e617e062e0716406007cbd23dd455c7b3
Currently, it is unstyled divs that don't look very well.
Alternative approach to I85e38a9ff16979f
Change-Id: Ic5cb76dbc4c919e059a6648200feecc037326230
This chooser has been removed from the Creative Commons website, and the
URL we are using now redirects to an apparently random 2006 blog post.
There is a new license chooser, with source at
https://github.com/creativecommons/chooser , but it does not support the
kind of embedding we need.
So, remove the feature.
Change-Id: I400777b2ae80198ba1db6bd105de38903afced6f
It is not perfect, but it's a major improvement compared the existing
one. We need to clean up a lot more once it has landed but it's a good
start.
Bug: T337435
Change-Id: I1f85110e754546c797d3325b8dd6878093790266
It's not always better to arrange code this way because it makes the
lines depend on each other and makes it a little harder to change one
line without changing the others. But I feel like it makes a lot of
sense in these cases. These method calls are not independend from
each other.
Change-Id: I6b223018d900b907933e9d4ed010af47f92ed37d
Take all available space to improve rendering of portal contents
in languages like German and Russian with long words.
Bug: T318205
Change-Id: I6e8a5fe4e8358751085ecadf0a6c63a007095584
Lighten success message slightly while still complying to WCAG 2.0 AA
contrast ratio. Also add top margin to the message to set it better
apart from installer config messages above.
Bug: T318204
Change-Id: Ic9b8b940f1598667bb5e184ac14dc3b9ab474d38
Removing the bullet image and indent the (fake) list items to
makes the text more readable.
Bug: T318203
Change-Id: I495b0a6a3c4c28a40fadbf054396d38ada1d550c
Use one background color shade `#f7f7f7` and not two similar ones
including `#f6f6f6`.
Also sort the background properties first to better orientate in the
code aligning to CSS property order proposal.
Change-Id: I70ed641521640218c8d17c10a021df9b1e52dc30
There are now 4 types of logos, only one of which is needed.
Update documentation in installer to reflect this.
Also make it possible to drag and drop files into the installer
and see live previews of what the logos will look like to aid
setup.
The 1x is no longer required.
Bug: T255913
Change-Id: I58226ae8fb02c32d2eeea65a50aaabbc193cb51c
Just disabling the `declaration-property-unit-disallowed-list` failures
for now, but it looks like at least most of these could be switched over
to ems without breaking anything. For another patch!
Change-Id: I9220334d670f71eba1b0e392da826036d54bc2f3
`list-style: none none` was a workaround for an IE 6 & 7 rendering issue.
Same goes for `list-style-image: none; list-style-type: none;` combination.
Let's unify to shorthand `list-style: none` for any non-ancient browser.
Change-Id: I05f00db8a08a9fc1523ea00fab91e91d3c00cab3
The installer needs a handful of the styles provided by
ResourceLoaderSkinModule. Reduce it to the minimum required in
preparation for the deprecation of the `legacy` feature.
Bug: T232903
Change-Id: I6a718232897448a94fe1ddda547ae5a5c671b7aa
Now that Html::infobox is deprecated in 1.36 let's make sure it's
clear the styles are too.
No release note is needed given the already existing note about
Html::infobox.
Styles are copied to the installer for now, but please note
their future standardization in T232903.
Bug: T268194
Change-Id: I5f7929e698c99e73f5186aa4d9bfe5f7788c12a1
Follows-up 00e8bde685, which removed loading of Vector styles.
Let the Installer maintain its own appearance instead.
Bug: T248133
Change-Id: Ibdb0a72083a837a369d8d660c79fecd5aac55407
This avoids an overlap of the help box with the floating page list.
The min-width:min-content prevents that long words get cut.
Change-Id: I2d9f38e84d6030de6b00f7105a8373ff9b69e0f9
`dirname()`: https://www.php.net/manual/en/function.dirname.php,
has a levels param that can be used for indicate the number of parent
directories to go up!
Change-Id: Ibdf6fbedbcf9b0eead1cfbf822d24ccae6652f3f
Changes in the behavior:
* The expanding/collapsing now works even with disabled JavaScript.
* There is no FOUC on loading anymore.
* The animation on show/hide is absent.
Change-Id: I1b88d8e2cdbb1c969670a7a8637dba10bf447330
Wow, so many opt-outs, and a lot of probably-not-going-to-change ones.
Actually wanted pattern:
* "^mw-…"
Content-related classes we're probably not going to scrap:
* "^wikitable$"
Hard-to-change classes used in lots of skins:
* "^toc$"
* "^toctoggle$"
* "^tochidden$"
Necessary for over-rides/specificity battles:
* "^oo-ui-…"
Probably worth considering changing soon:
* "^client-js$"
* "^client-nojs$"
Some of the exemptions have been applied to deprecated styles (where they're being
renamed); some are for code in entirely deprecated areas themselves; some have the
"wrong" name but sit alongside classes with an appropriate one. And some are, very
clearly, in the wrong repo. Such sigh.
Change-Id: I9b8423d53b6750b5ca79d2f69e111f75c93c5bdc
This is inspired by Ib117e05.
As far as I can tell this is functionally identical. Even arrays should
behave the same, as both the getVal() and getCheck() methods do have a
special case that returns the `null` default in case the user tried to
pass multiple values instead of a single scalar.
Change-Id: Id4e4ec91f39d3c39461bd41673bdafc3bde11737
