Commit graph

94127 commits

Author SHA1 Message Date
Holger Knust
f60d04d3ea resourceloader: Add test to validate existence of ImageModule "images" files
New data provider and test method were added to ensure file paths are correct and the file is present.

Bug: T231430
Change-Id: Iadafe0df1104de8829ea87632d65b3008cf80d76
2020-02-12 14:04:33 +00:00
Thalia
1f3a5dd527 IndexPager: Cast properties passed to implode to arrays
$mLastShown, $mFirstShown and $mPastTheEndIndex should be arrays
since 6786aa5d8e, but classes that
override doQuery do not all honour this.

Cast these to arrays as they are passed to implode.

Bug: T244941
Change-Id: I1e6d9bee852e304e6b10733f53f942942cc0ff52
2020-02-12 00:29:30 +00:00
jenkins-bot
055a35296f Merge "ImageHistoryPseudoPager: Update doQuery() for IndexPager changes" 2020-02-12 00:19:42 +00:00
jenkins-bot
9b2199bcf1 Merge "ApiDisabled: Correctly fall back to api-help-no-extended-description" 2020-02-12 00:11:14 +00:00
jenkins-bot
1f0ab30117 Merge "Drop the abandoned, replaced 'KSS' styleguide and references in MWUI" 2020-02-12 00:00:06 +00:00
Volker E
3fa38ae795 Drop the abandoned, replaced 'KSS' styleguide and references in MWUI
KSS is no longer in use anywhere. The only official style guide is
at https://design.wikimedia.org/style-guide.

Change-Id: I688a78e9a71a082c499af55bd01e8fd615130486
2020-02-11 15:38:53 -08:00
Roan Kattouw
bf9ae0768d ImageHistoryPseudoPager: Update doQuery() for IndexPager changes
This class duplicates a bunch of code from IndexPager, and that code was
changed in 6786aa5d8e in a way that broke
this code. Update it to account for the fact that mFirstShown,
mLastShown and mPastTheEndIndex are now arrays. Also update the
documentation in IndexPager to reflect that.

Bug: T244937
Change-Id: I51a50b6d3be1467f4ee399446d1d12cfed71a06c
2020-02-11 15:36:28 -08:00
jenkins-bot
12f9209152 Merge "languages: More doc annotations for LanguageConverter related classes" 2020-02-11 22:48:30 +00:00
jenkins-bot
456606bd67 Merge "Apply normal, cross-browser button appearance on revision history (part 2)" 2020-02-11 20:40:20 +00:00
Volker E
c80ec5ee9c Apply normal, cross-browser button appearance on revision history (part 2)
Continued from I717f985c572e5cb529c150a1

Bug: T244824
Change-Id: I88d99953ba3fbfb4302e548b1b3b70bbf4671d34
2020-02-11 20:23:14 +00:00
jenkins-bot
60de8e39a9 Merge "Revert "Doxygen: Fix ignoring @phan notation, also ignore @return-taint"" 2020-02-11 18:29:05 +00:00
jenkins-bot
3ac2e9ff04 Merge "Add more tests for the User class" 2020-02-11 18:01:17 +00:00
jenkins-bot
be493195a8 Merge "Use ObjectFactory to construct ContentHandlers" 2020-02-11 17:57:14 +00:00
jenkins-bot
9c2f06f68d Merge "shell: Skip FirejailCommandTest::testBuildFinalCommand() on Windows" 2020-02-11 16:49:56 +00:00
RazeSoldier
f58616acce shell: Skip FirejailCommandTest::testBuildFinalCommand() on Windows
firejail is a Linux sandboxing system, unavailable on Windows.

Bug: T228568
Change-Id: I115e0e72ec31ebd7fd61e90250c10b414eea2489
2020-02-11 16:31:31 +00:00
jenkins-bot
063d269d2e Merge "resourceloader: Use Config instead of $wg in Resources.php callback" 2020-02-11 15:56:08 +00:00
Peter Ovchyn
f136c2953c languages: More doc annotations for LanguageConverter related classes
Deprecated LinkHolderArray for public usage

Bug: T244709
Change-Id: Ic5b9e9237044b56cbb64e7c762f5d2de3b1de821
2020-02-11 17:32:12 +02:00
jenkins-bot
10b98b76f5 Merge "mediawiki.ui: Replace em with px values" 2020-02-11 07:16:31 +00:00
jenkins-bot
28368cf688 Merge "Apply normal, cross-browser button appearance on revision history" 2020-02-11 07:13:24 +00:00
Translation updater bot
ae3dee0d89 Localisation updates from https://translatewiki.net.
Change-Id: Ic14fb1b58302bed2e2f1d16b690cc27e0aad957f
2020-02-11 07:53:38 +01:00
Volker E
d82d3848ab Apply normal, cross-browser button appearance on revision history
Bug: T244824
Change-Id: I717f985c572e5cb529c150a149f4094079d02955
2020-02-10 21:00:19 -08:00
Volker E
150d053d4c mediawiki.ui: Replace em with px values
Bring on par with OOUI where similar change has been merged in
Ie7e6a19009168d78713.
Also reducing top padding of `.mw-ui-input-large` to unified `8px`.

Bug: T244823
Change-Id: Icb5d06dba7f891f617696b4455fd3956f75f90ef
2020-02-10 19:52:09 -08:00
DannyS712
989c4f7723 Add more tests for the User class
Methods newly tested:
* ::isAllowedAny, ::isAllowedAll, ::isAllowed, ::isNewbie
* ::pingLimiter (basic testing)

Testing expanded for:
* ::checkPasswordValidity
* ::testRealName

Bug: T233385
Change-Id: I2848ecc401b55e4202a853f270f084a093ed46e4
2020-02-11 01:57:04 +00:00
Bartosz Dziewoński
d79286f1af mw.Upload.BookletLayout: Fix pre-setting a file
There was an unintentional breaking change to this API in OOUI in
f70fa9df0 (v0.31.3 / 2019-04-03). It only supports an array of files
now. This fixes uploading by dragging-and-dropping or copy-pasting
an image into VisualEditor editing surface.

Change-Id: I6dcd109c085d2542b0256e37bfbf130c92261e2e
2020-02-11 02:11:32 +01:00
Roan Kattouw
3e4e3f362c resourceloader: Use Config instead of $wg in Resources.php callback
I had suggested this code myself during code review, but forgot that a
Config object is available in the callback. We should use that instead
of a global variable.

Follow-up to 036cde7a04

Change-Id: I8b104e411dc32250a0ebca535c2b0dc3d63993a0
2020-02-10 17:01:51 -08:00
jenkins-bot
9d8df97cb2 Merge "Deprecate the ArticleEditUpdates hook" 2020-02-10 23:12:10 +00:00
jenkins-bot
799eeb583a Merge "Add ALTER SEQUENCE for Postgres patch-watchlist_expiry.sql" 2020-02-10 21:25:44 +00:00
MusikAnimal
f5f71d31eb Add ALTER SEQUENCE for Postgres patch-watchlist_expiry.sql
Follow-up to I014ffccb91969e7a222a83858c55e71067b0f2af

Bug: T240094
Change-Id: I62d95f2f6f0a5a0bc8bb4f471b303e878d2e0798
2020-02-10 16:00:33 -05:00
Reedy
ad1d7efdd8 Remove SQLite watchlist_expiry patch
It's identical to the MySQL patch, so MW will just fallback

Bug: T240094
Change-Id: I1aec7f0b1c52d16cd30486cf6e5840b3cbef25ef
2020-02-10 19:01:38 +00:00
ArtBaltai
272e941b7f Use ObjectFactory to construct ContentHandlers
Changed
 - ContentHandlerFactory with legacy support
 - ContentHandlerFactoryTests
Added
 - MediaWikiIntegrationNoDbTestCase for test without preparing DB
New
 - tests

Bug: T243560
Change-Id: I693dda56af55bd03e48d62a2f1ade42f65a8fac9
2020-02-10 21:36:36 +03:00
jenkins-bot
ed3dbf33fc Merge "Add overflow: hidden to messagebox" 2020-02-10 18:03:18 +00:00
jenkins-bot
10b7602f69 Merge "Standardize information on Password Reset success page" 2020-02-10 17:10:25 +00:00
Petr Pchelko
e79b72beeb PageHistoryHandler: Undefined index 'query'
Bug: T244184
Change-Id: Ida350938d2a3cbc7be936763108253efb188c42c
2020-02-10 08:21:08 -08:00
jenkins-bot
a2ae2b4803 Merge "HTMLForm: Allow status object to have raw parameters" 2020-02-10 15:45:31 +00:00
jenkins-bot
1a88a4dc96 Merge "Add help link to Special:Mute" 2020-02-10 10:39:43 +00:00
Translation updater bot
d68fe17bb7 Localisation updates from https://translatewiki.net.
Change-Id: I685856eb029595a57db4443b75cf046f8e0b94b6
2020-02-10 07:54:14 +01:00
Sam Wilson
5b1978f797 Standardize information on Password Reset success page
For all successfully submitted (i.e. valid input) password reset
requests, display the same information. This removes the
distinction between email and username resets, and only shows the
user what they've already submitted.

Bug: T238961
Change-Id: Ic17acecf1e44401f7607cdaf90dcee1a26b8405f
2020-02-10 10:23:13 +08:00
jenkins-bot
8be52af840 Merge "resourceloader: Optimization - avoid repeated $this->getModule() calls" 2020-02-09 20:42:05 +00:00
Derick A
fb5650684a resourceloader: Optimization - avoid repeated $this->getModule() calls
`$this->getModule()` returns a RL object or a null. The check above already
makes sure that $module is not null so we can just set file dependencies
from the RL object returned.

In addition, this is an optimization as we reduce repeated calls to
`$this->getModule()`. Similar logic already exist in the same file from
L#116 - L#118.

Change-Id: If50c28ff5cd8eb435c9fa4f277e2d1038b52ca74
2020-02-09 21:18:44 +01:00
jenkins-bot
65bf0b9699 Merge "filebackend: make sure $scopeLock reference is valid in FileBackendMultiWrite" 2020-02-09 19:06:06 +00:00
jenkins-bot
3af0884d9a Merge "Fix @todo asking to document LogPage::getTitleLink()" 2020-02-09 17:27:13 +00:00
Florian
c13605dba4 HTMLForm: Allow status object to have raw parameters
The status object, which can be returned after validating an HTMLForm,
can contain message objects. These message objects can be constructed
with the full feature set provided by Message, e.g. raw parameters.

The handling of these status objects in HTMLForm basically prevented
some features of the Message object in the status, as it parsed the
messages through the Parser, which does not recognize these raw
parameters as such and escapes them wrongly.

This behaviour is fixed with this change.

Bug: T240774
Change-Id: I152ec51f317799572bf6791e110cd72c42da82a0
2020-02-09 18:06:12 +01:00
jenkins-bot
c7ac011766 Merge "SpecialRandomInCategory.php: preserve query string during redirection" 2020-02-09 16:03:24 +00:00
cobaltcigs
6e4d6525e2 SpecialRandomInCategory.php: preserve query string during redirection
Bug: T244641
Change-Id: Id093cf4659b7a8bc853750f1404923af40bec4d6
2020-02-09 13:29:38 +00:00
Fomafix
2aa6f354cf Add overflow: hidden to messagebox
This prevents an overlap of
* messagebox
* errorbox
* warningbox
* successbox
with floating objects.

Bug: T244659
Change-Id: I75a19576a4ba36b333223db3cf44533f7e79aad8
2020-02-09 11:24:12 +01:00
jenkins-bot
f7a7905686 Merge "Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent" 2020-02-08 21:02:53 +00:00
James D. Forrester
cafe286e2b Deprecate the ArticleEditUpdates hook
Change-Id: Ie85a46846315999ebaab1e1b38265937f4b2c79e
2020-02-08 20:29:35 +00:00
jenkins-bot
8dc757164a Merge "Update the change_tag table in rebuildrecentchanges.php" 2020-02-08 17:46:02 +00:00
Aaron Schulz
ef7af6ea77 Disable PSR2.Classes.ClassDeclaration.InterfaceWrongIndent
Bug: T243529
Change-Id: Ia2cd9ac19cd64a77bb7503bb2b68e46b0746d559
2020-02-08 11:19:02 +00:00
jenkins-bot
c837c1d097 Merge "Support pagination on multiple columns in the IndexPager" 2020-02-08 06:13:46 +00:00