Sam Reed
5ed71b715e
Bug 31199 - Fix notification of implicit groups so it doesn't massively change json output
...
Needs merging to 1.18, 1.18wmf1 and pushing to site
2011-09-28 16:36:17 +00:00
Sam Reed
a5628f5734
Based on diff to wikia, set more functions consistently public rather than protected
2011-08-17 22:24:21 +00:00
Sam Reed
d510cdd91d
* (bug 29938) list=users&usprop=rights shows rights the user doesn't have
2011-07-18 21:26:33 +00:00
Sam Reed
9c37ab4fb3
* (bug 28817) Add reference help page link to API Modules
...
Last followup of r92396
Should be all modules with documentation pages in core now documented...
2011-07-17 17:02:06 +00:00
Chad Horohoe
783d4e0862
Remove @static from all over the place. That's what the static keyword is for, this being PHP5 and all
2011-04-21 00:07:09 +00:00
Sam Reed
29df5af44e
Followup r84361, numerical keys ftw
2011-03-20 00:32:28 +00:00
Sam Reed
db45168a0d
* (bug 27469) label implicit groups in list=allusers&auprop=groups/list=users&usprop=groups
2011-03-20 00:19:29 +00:00
Sam Reed
86ce74c75d
* (bug 28010) Passing a non existant user to list=users gives internal error
...
* (bug 27549) action=query&list=users&usprop=groups doesn't show implicit groups if a user doesn't have explicit groups
Also follows up r79556, where I'd done a couple of daft things... (accessing undefined objects)
2011-03-12 22:23:43 +00:00
Sam Reed
aea7a5a482
Followup r83390
...
If the user is allowed to view hidden users, put a missing property on all users.
For list=users, do the same, but we can't easily distinguish to other people the difference between "hidden", or "missing", so no reason to do it
2011-03-06 20:51:31 +00:00
Sam Reed
8c4f349a63
Fix leading whitespace before class ApiQueryUsers
2011-03-06 18:17:28 +00:00
Sam Reed
67d4ee1d26
Followup r83390, change cache modes
2011-03-06 18:16:44 +00:00
Sam Reed
c488abeeb8
* (bug 27897) list=allusers and list=users list hidden users
...
Refactored addition of block information, and also checked if user is allowed to view hidden user fields
2011-03-06 17:59:08 +00:00
Sam Reed
20d56c63b3
* (bug 27708) list=users does not have a property to return user id
...
Add userid to ApiQueryUsers
Move userid in ApiQueryAllUsers before name
2011-02-25 16:19:44 +00:00
Sam Reed
448ab3b78d
Fixup one missed alias rename from r82739
2011-02-24 20:46:45 +00:00
Sam Reed
35296f391f
Followup to r82739 (bug 27688)
...
Remove u1 table aliases
2011-02-24 18:46:12 +00:00
Sam Reed
57923b31fa
* (bug 27688) Simplify queries to list user block information
...
Also expose block expiry information, listed on Users, but not all users
Some minor simplifications to come
2011-02-24 18:43:44 +00:00
Sam Reed
fa64025161
More parameter documentation
2011-02-19 00:30:18 +00:00
Sam Reed
df0a765cfe
* (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights
2011-01-04 03:36:39 +00:00
Sam Reed
0014c1113c
* (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of
2011-01-04 02:48:02 +00:00
Sam Reed
e1bcab1ab8
* (bug 25767) Add userrights properties to allusers and users query lists
...
First part of this bug. Listing of all rights that users have
2011-01-04 01:39:02 +00:00
Sam Reed
1da2cd2dde
Move comment about groups potentially returning less results from server.
...
Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
2011-01-03 20:41:22 +00:00
Sam Reed
6309c920dd
Delete all the "API for MediaWiki 1.8+" comments
...
Add since to ApiQueryQueryPage
2010-12-22 20:52:06 +00:00
Roan Kattouw
17487e40ba
Replace my old e-mail address with my new one in API comments. A bit outdated (dropped the old one in September '08)
2010-12-22 20:48:10 +00:00
Sam Reed
15b65258d1
Spaces to tab, add a couple of braces
2010-11-23 23:58:57 +00:00
Sam Reed
38f9c25b27
Explicit variable definition, tweak documentation
2010-11-23 21:43:56 +00:00
Sam Reed
4aaecdcd9d
* (bug 26089) add block expiration to blockinfo
2010-11-23 21:37:27 +00:00
Sam Reed
68e1a821f4
Capitalise first letters
2010-11-04 13:07:57 +00:00
Sam Reed
550271e806
Explicit class variable definition
...
Parameter hints
2010-10-06 21:18:55 +00:00
Sam Reed
f07567201f
Remove some unused variables
...
Tweak php doc, "One" is not a type, so insert string in there
2010-09-25 16:37:39 +00:00
Alexandre Emsenhuber
457eb73b61
Standardised file description headers, added @file
2010-08-07 19:59:42 +00:00
Sam Reed
5387b8a806
Stylize API up to date
...
Fix spaces from r69755
Minor update to RELEASE-NOTES per r69753
2010-07-23 07:33:40 +00:00
Tim Starling
b2dc451c82
Rewrote r69339 etc. to clean up API cache header handling.
...
* Introduced a "cache mode" concept to simplify the header generation code, and to avoid odd results when conflicting cache header requests are received from submodules, or at least to formalise the handling of such cases.
* Made the cache mode private by default, so that code written in ignorance of caching tends to be safe. If different query modules are used in a single request, private caching is preferred over public caching.
* Removed the "must-revalidate" option from all CC headers, this is really specific to page views with a hacked squid in front, I don't think it's applicable here.
* Made the watchlist module private. This is really the definition of private data. There's nothing in the HTTP spec that says the URL for a CC:public request is private and can't be leaked. CC:private provides protection against unknown proxy behaviour.
* In ApiQueryAllmessages: avoid calling $wgLang->getCode() to check if it's necessary to make a new $wgLang when lang= is specified, since this is the only thing that unstubs $wgUser.
* Removed "FIXME: should this check $user instead of $wgUser?" Answer is no.
2010-07-23 07:17:56 +00:00
Sam Reed
8f1d2cb199
Big blitz on unused variables (a lot of $db = $this->getDb() )
2010-07-22 22:13:21 +00:00
Roan Kattouw
70824ccccc
API: Make output containing private or user-specific data uncacheable for logged-in users by setting Vary: Cookie or Cache-Control: private, whichever is appropriate. Fixes instances in core and WMF-deployed extensions only. Without this change, the output of requests like ?action=query&list=recentchanges&rcprop=patrolled&smaxage=3600 would be cached in Squid and viewable for anyone using the same URL, even if they don't have patrol rights. Other, more serious exploits are also possible. Also avoid using $wgUser in one place, kill some unused global $wgUser; instances and tweak a comment.
2010-07-14 19:00:54 +00:00
Sam Reed
0e2576a250
Fix typo (and change wrong variable)
2010-06-22 06:05:20 +00:00
Derk-Jan Hartman
921619b119
Correct the address of the FSF in some of the GPL headers
...
59 Temple Place -> 51 Franklin Street
2010-06-21 13:13:32 +00:00
Sam Reed
faf34b4073
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66168#c7252 switch while ( $row = $db->fectchObject( $res ) ) to foreach ( $res as row )
...
On ApiQueryUsers switch $r to row, and remove nested brackets
2010-06-20 18:48:34 +00:00
Sam Reed
232cabd9f8
Followup r68157 and r68161 per Bryans comment (anons aren't in the group user)
2010-06-20 17:30:23 +00:00
Roan Kattouw
a1db76daaf
Followup to r68157: simplify ApiQueryUsers::getAutoGroups()
2010-06-17 09:39:07 +00:00
Sam Reed
a5054efc97
Rem whitespace, function comment for r68158
2010-06-17 08:15:56 +00:00
Sam Reed
18227749a6
Minor followup to r68156, add "user" as implicit group
...
Refactor out and reuse in ApiQueryUserInfo
Add couple more braces to SpecialUserrights
2010-06-17 08:00:42 +00:00
Sam Reed
a19c0eb2a3
* (bug 24009) Include implicit groups in action=query&list=users&usprop=groups
...
Add some whitespace, fix some braces in ApiQueryUsers
Add a few braces to SpecialUserrights.php, change or to || and and to &&
2010-06-17 07:39:31 +00:00
Jack Phoenix
7ced9bc569
API: fix copyright symbol, coding style cleanup, more braces
2010-02-26 13:18:56 +00:00
Sam Reed
47c24175d3
Add/remove whitelines to increase readability in API code files
2010-01-23 22:26:40 +00:00
Aryeh Gregor
3758769f0d
stylize.php on API code
...
"I wouldn't object to stylizing the API code to bring it in line with
the rest of MW on principle, but I'm not gonna bother myself." --Roan
<http://www.mediawiki.org/wiki/Special:Code/MediaWiki/60657#c5108 >
If you're seeing this commit in blames, tell your blame tool to ignore
whitespace, e.g., git blame -w or svn blame -x -w.
2010-01-11 15:55:52 +00:00
Chad Horohoe
a4e5e935b6
Mass convert NULL -> null. Left strings and comments alone, obviously.
2009-12-11 21:07:27 +00:00
Alex Z
68596ac79c
merge most of r56515 back to trunk (changing UserrightsPage::fetchUser to non-static)
...
Fixing ApiQueryUsers so it should work properly for interwiki users
2009-09-17 16:21:27 +00:00
Roan Kattouw
9e78c71b1e
API: Make it possible to fetch userrights tokens for interwiki users; make UserrightsPage::fetchUser() static
2009-09-10 13:44:49 +00:00
Tim Starling
ecaa39d51b
Followup to r49056: gender property gives "unknown" when gender option is null
2009-06-03 15:36:44 +00:00
X!
e774395b54
Added usprop=gender to list=users
2009-03-31 03:48:08 +00:00