Commit graph

26 commits

Author SHA1 Message Date
Aaron Schulz
de58577c2d Make sure job queue partitions use the null aggregator
* Fixes problem from 37042262e3
* The main class already handles the calls.
* Partitions call notifyQueueNonEmpty() on pop() even
  when the other partitions have jobs, so it is also wrong
  in addition to redundant.

Bug: T101427
Change-Id: Ic3235e1f2038053fabf92f97c663479a21d75317
2015-06-05 00:02:45 +00:00
Aaron Schulz
22734b3c0f Let deduplicateRootJob() accept JobSpecification for consistency
Change-Id: I872c2af40028e918fe6d9a8cd32ac97c70bffdae
2015-05-23 12:49:44 -07:00
jenkins-bot
2e89500994 Merge "Removed executeReadyPeriodicTasks() method" 2015-05-12 20:03:02 +00:00
Aaron Schulz
2f99b38f5f Removed unused variable in doFlushCaches()
Change-Id: I599fc2e8575cf5e8242bcc15be93e54b74ede435
2015-05-07 18:21:12 +00:00
Aaron Schulz
ec3da97659 Removed executeReadyPeriodicTasks() method
* Moved all these hacks to JobQueueDB, which is the only queue that
  should need this (for stock installs). Newer queues should always
  have the queue store manage stuff like this, not MediaWiki.
* This also avoids expensive object construction that does nothing
  when non-DB queues are used.

Change-Id: Id718cda25750be73044a049b39958cca55aa3172
2015-05-06 20:20:40 -07:00
Aaron Schulz
6c9e517a70 Made showJobs.php show claimed jobs too
Change-Id: Ifc5eeff10fdcdbbe4ade7b32e5388fee4eb94bcf
2015-04-17 12:35:39 -07:00
Aaron Schulz
9720c6c410 Made showJobs.php include abandoned jobs in --list
Change-Id: I7ae8dd2470d5e15fd66c6c06f3feb6d70527daa3
2015-03-26 12:17:10 -07:00
jenkins-bot
4f1067e27e Merge "Removed odd "partitionsNoPush" setting to simplify the code" 2015-03-18 23:06:50 +00:00
Aaron Schulz
ce33c484ed Made JobQueueFederated::supportsDelayedJobs() check all the partition queues
Change-Id: Id451faedd6286a84f993fa183e67e0bf35d21c41
2015-03-11 11:10:12 -07:00
Aaron Schulz
6846ff953f Removed odd "partitionsNoPush" setting to simplify the code
* A maintenance script already exist for copying jobs to other queues

Change-Id: Id105e7e60fae4b8a30cda74a45597a2a2e548a91
2015-03-03 22:00:43 -08:00
jenkins-bot
ea3646b476 Merge "Removed overzealous caching from JobQueueFederated" 2015-03-04 05:48:38 +00:00
Aaron Schulz
32684df25f Moved JobQueueFederated partition exceptions to their own log
Change-Id: If495e9b1a631b587cb3b8d83974837eef1d2d4c6
2015-03-02 11:15:40 -08:00
Aaron Schulz
d8a12160a2 Removed overzealous caching from JobQueueFederated
Change-Id: Id3a80dc89e5b46d6d95180e73e753b38a476eb36
2015-02-16 14:33:44 -08:00
Ricordisamoa
fc5fd5c37a Typo fixes and non-code tweaks
Skipped replacements:
* prefered → preferred
* prolly → probably

Skipped files:
* resources/lib/jquery.ui/jquery.ui.mouse.js
* resources/lib/jquery/jquery.form.js

Change-Id: Ib7923f362ddfca1b892bf5d601785d6b5aa5d44c
2014-12-12 18:31:15 +00:00
Aaron Schulz
bc5e7d037a Fixed use of wrong class constant
Change-Id: I6c7e49d16685315f9e84b61ba11d1a3b08730597
2014-07-28 12:03:58 -07:00
Aaron Schulz
77ea812c9e Removed use of cache in JobQueueFederated pop() method
* This does not really buy anything for a number of reason and
  can cause bugs. For example, if the aggregator is notified due
  to undelayed jobs but this cache is not updated, then the runners
  will not see the jobs and will de-list aggregator entry.

bug: 68506
Change-Id: I1eacca108df59fff9c0fcc846aafaf1616cf5895
2014-07-28 17:16:08 +00:00
umherirrender
44d14fc684 Doc: Reformat @params declaration
I have not found documentation about the @params command, so this seems
not valid.
I have moved the text to the corresponding @param

Change-Id: I443866d602b60570278289e6e24a77d37314cede
2014-07-24 13:12:18 +02:00
Aaron Schulz
8052dc9ffc Fixed job miscounting bug when a string digit is returned
Change-Id: I857b56a6e78f715157c7f648929d6bf38eb74828
2014-05-19 10:12:14 -07:00
Thiemo Mättig
e292bc972d Finish removing boolean return values from JobQueue code
This is a follow-up for patch
Ia706ac0122a7dd7f418e2dc2d3bd36e9a0252c25.

Change-Id: I19fe58a939706d3f7594d937e0bcad6d97c52a50
2014-04-28 22:21:58 +02:00
Siebrand Mazeland
f994817f6b Pass phpcs-strict on various files in includes/
These files have all had treatment before, and these occurrences have either
been missed or have been introduced after.

Change-Id: I06cdab4616b5bff47c85152df28f18c861730a23
2014-04-24 21:50:01 +02:00
umherirrender
dcf6955e5c Fixed some @params documentation (includes/*)
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: Ifbb1da2a6278b0bde2a6f6ce2e7bd383ee3fb28a
2014-04-20 23:33:05 +02:00
Aaron Schulz
f7f710287b Improved HashRing usage in JobQueueFederated
* Added proper ejection and caching in HashRing to avoid rebuilding
  the hash all the time (or doing manual caching).
* Made JobQueueFederated blacklist failing servers for a few seconds.
* Also made the JobQueueFederated root job methods properly respect
  the weights when they fail over.

Change-Id: Ifa4c03272c1777cfff2523ab21f780074ddcf359
2014-04-18 20:28:48 +00:00
Aaron Schulz
94c37ffb96 Revert "Revert "Removed useless JobQueue return values""
Made the obvious update to a caller missed in the change.

This reverts commit c76d5a95c1.

Change-Id: I67400ba5b9fc7de16c9f9d5075c488c5e58cea9e
2014-04-16 11:22:31 -07:00
Reedy
c76d5a95c1 Revert "Removed useless JobQueue return values"
This reverts commit bc8c89d2df.

Bug: 64007

Change-Id: I4b4dbe4637dc50cd4630ef19d54f01efba10e138
2014-04-16 17:41:53 +00:00
Aaron Schulz
bc8c89d2df Removed useless JobQueue return values
* This are already totally redundant to the use of exceptions

Change-Id: Ia706ac0122a7dd7f418e2dc2d3bd36e9a0252c25
2014-04-02 17:56:05 -07:00
Aaron Schulz
9ffd4f085d Renamed /job to /jobqueue
Change-Id: I4c8a2b42140630838867c77a70d45ba14b5d95e2
2014-03-14 13:42:04 -07:00
Renamed from includes/job/JobQueueFederated.php (Browse further)