Introduced in 2013 by I939551bd228 (fdef79d9f2), and originally used
for PostgreSqlLockManager. This was removed again in Ia8f802b2c68
(2fa8eb2c80).
Change-Id: I7ae15703f919c9ff890056648aad8e86bccf34ab
This hook is no longer used anywhere. It was deprecated in
ded922c21d and all of its users have
migrated to the new MessageCacheFetchOverrides hook.
Bug: T328183
Change-Id: I5f08849b57a33f0853e176a7452b6b3e6d601add
Remove the 'writeapi' field from the response of the query+siteinfo
API module. It had no purpose since MediaWiki 1.32 when
$wgEnableWriteAPI was removed.
Follows up I54ff9428b247ba203d67aba079149393f323d5a9.
Bug: T115414
Bug: T294397
Change-Id: Icedba7f9c7ff58a5ac690cf25e449ba9e2337bd9
In change I625a48a6ecd3fad5c2ed76b23343a0fef91e1b83 I am planning to
make Wikimedia\Message\MessageValue use it, and we try to pretend that
it is a library separate from MediaWiki, so it makes sense to move
MessageSpecifier to the same namespace under Wikimedia\.
Bug: T353458
Change-Id: I9ff4ff7beb098b60c92f564591937c7d789c6684
This contains a minor bugfix to the ALLOW_OBJECT hint.
Depends-On: Ied49bd4e03d4ae816dc9ddd6791d92355be6304e
Change-Id: Ibcedd6c0c9809ccae04bfcb7c5892466b48b56ce
Why:
- Enabling by default in DevelopmentSettings.php means that more
developers will interact with the feature and we'll have more input
into ways that the feature works with (or doesn't work with) various
extension and configuration setups in local development environments
What:
- Enable temp user account autocreation by default in
DevelopmentSettings.php
Bug: T359043
Change-Id: Ie88043a7dd7f504092ddd9a6cae1320ab2dbd208
Start with the basic required arguments.
Leaves room for expansion.
Decided to have:
- 0 arguments = interactive
- 1+ argument results in regular validation messages
- --help outputs help as normal
- interactive mode mentions you might want --help
Bug: T48076
Change-Id: I972bf55f96c9cdf1a5eaf55c0e0117b190420d30
For years we had to carefully use mw-content-ltr and mw-content-rtl
subsections to make description, ordered and unordered lists margin
values to work in LTR and RTL mixed content as expected. Now with the
widespread existence of CSS Logical
https://caniuse.com/?search=css-logical
such workarounds aren't needed as now we can just define styles in a
direction aware way.
The only problem is that older browsers which don't support
CSS Logical, that's why this change actually keeps compatibility
margin values for them so they can just ignore those new properties
and the remaining issue will be the support of nested directions for
that older browsers which should be negligible given the benefits
for the newer browsers such as the support of more than two layers
of direction changes (happens in multilingual wikis such as Commons
but rarely) and the fact margin values now will be correct even when
`mw-content-{ltr,rtl}` classes aren't used correctly by the templates
in wikis (which happens more commonly).
The purposed change uses https://caniuse.com/?search=margin-block-start
over https://caniuse.com/?search=margin-block which has even slightly
better browser support.
This change deprecates `i18n-all-lists-margins` module of SkinModule
as now just including of the `elements` module is enough.
Bug: T369475
Change-Id: I404710209d59241991716bb7180bcaabcafffcec
Follow-up to f18362ccce.
While working on I625a48a6ecd3fad5c2ed76b23343a0fef91e1b83,
I learned that Stringable objects are sometimes also used
as normal params, intended to be stringified when rendering.
For example, see `this->target` in the UnblockUser class.
That code uses Message objects, so it's not causing trouble,
but converting them to MessageValue would emit warnings.
I didn't actually intend to deprecate that, and it won't
cause issues with JSON-serializability (assuming we stringify
the objects in time), so tweak how the warnings are emitted.
Change-Id: I26dfd4f1ac8ed08a422692de4e39d072242c08df
As part of refactoring the edit save logic, remove this public entrypoint - the
attemptSave() method is still available. Because the actual logic is still
needed by core, we move it to a new private method,
internalAttemptSavePrivate(), and call that from the deprecated
internalAttemptSave() method.
Bug: T157658
Change-Id: I79ccb85f645e15256c4b5867ef3997d10a611e53
Instead of creating a half-initialized helper and later calling ::init,
provide all the information necessary for the helper in the constructor.
This is facilitated by the fact that there already exists a factory
class, PageRestHelperFactory, which holds all the services required.
This affects:
* HtmlOutputRendererHelper::init()
* HtmlMessageOutputHelper::init()
* HtmlInputTransformHelper::init()
Change-Id: I1e1213597c6be012f2bc024c2b370c968ff3b472
This class was @unstable and should be replaced by ParserOutputAccess.
Bug: T367074
Depends-On: I543a6e9da4fc473a2ac54ac635286453f2aff96a
Change-Id: Ie51b9b7a8b42a6faafeb28378c188347f274a9c5
BagOStuff::watchErrors() returns a token that can be used with the
BagOStuff::getLastError() method to get the last error registry. Use
this instead of deprecated clearLastError().
This new style for clearing last errors was introduced in 2021,
I281817a85602967c0ec2bdd23a5d8be101680b64 (I281817a85602967) as it
is more robust due to its support for allowing nested callers.
An outside BoS instance might want to watch the errors returned by
multiple internal BoS instances and with the use of watch point
tokens, this is possible.
This patch hard deprecates BagOStuff::clearLastError() and
WANObjectCache::clearLastError().
Change-Id: I9b7a77bae8c0d5cc0235f0894a92f8e38628826d
Why:
- Temporary accounts will become the default anonymous editing
paradigm on Wikimedia wikis (and maybe for MediaWiki via T355880),
so we want this to be the default that we test against in CI
What:
- Enable AutoCreateTempUser in DevelopmentSettings.php when
MW_QUIBBLE_CI is set. That means it will be enabled for CI, but not
by default, in local development setups that include
DevelopmentSettings.php
Notes:
- PHPUnit tests that need to run in an anonymous IP editing context
should use TempUserTestTrait::disableAutoCreateTempUser()
- Selenium and API-testing tests that specifically check anonymous
IP editing context should use a custom LocalSettings.php override
to disable temp accounts feature for the duration of the test
Bug: T359043
Depends-On: I375cf7dfec1667396136402a85cbbb68efd43069
Depends-On: If48a33794132b46fb51d864bce103aa8285443c3
Depends-On: I604c521f00d5cc64b8102c93f9a013bcac557001
Depends-On: Id6ec4b9e438dd277a51f781377a93756fa4c3996
Depends-On: Ib0a176fe335cf45e5b2cdd351c95d5da162a1eb2
Change-Id: I8c4395ac1bdbc0c55aa45038cbbd589025b4aeef
The last callers themselves were already soft deprecated and the
singleton on UserCache itself was almost unused. The last usage has
been replaced and the method now emits deprecation warnings.
Change-Id: Ic9f5e4f427c0402b6c0e7232bcf1d5f9eec6e73e
