Commit graph

26 commits

Author SHA1 Message Date
Umherirrender
49efbfe2fb Improve documentation about object to be stdClass or specific type
Some classes still needs exclude for the sniff

Change-Id: I9536c2ee84f6fb4c83cf862a152cf6b00344cb97
2020-11-20 14:47:56 +00:00
Umherirrender
6ca2883ce8 Improve doc about object to be stdClass in QueryPage::formatResult
Change-Id: Ib1fadd74f2f3223ea8a9343d1524533f00b991df
2020-11-15 13:50:59 +01:00
jenkins-bot
39705eb311 Merge "Replace "@stable for subclassing" with "@stable to extend"" 2020-07-13 09:31:38 +00:00
daniel
3c50afa46b Replace "@stable for subclassing" with "@stable to extend"
For compliance with the new version of the table interface policy
(T255803).

This patch was created by an automated search & replace operation
on the includes/ directory.

Bug: T257789
Change-Id: Ie32c1b11b3d16ddfc0c83a757327d449ff80b2e4
2020-07-13 11:00:30 +02:00
daniel
f7116bb3a2 Replace "@stable for overriding" with "@stable to override"
For compliance with the new version of the table interface policy
(T255803).

This patch was created by an automated search & replace operation
on the includes/ directory.

Bug: T257789
Change-Id: I5ffbb91882ecce2019ab644839eab5e8fb8a1c5f
2020-07-13 10:57:12 +02:00
daniel
24d34d32e3 Mark special page base classes as stable for subclassing
Bug: T247862
Change-Id: I44d9dddd99c0106a30058cd80377a65f9b1694a9
2020-07-10 15:52:19 +02:00
Reedy
51d3ade7d4 Fix more Squiz.Scope.MethodScope.Missing
Member variables in HistoryBlobStub have been marked protected

SpecialPage::setListed() and listed() have been deprecated

CategoryPage::getCategoryViewerClass() and setCategoryViewerClass()
have been deprecated

Change-Id: Id1f530c2c8ec1171615f726dc7446431ee7ca8fe
2020-05-18 20:35:38 +00:00
Reedy
bc24bf7c4f Fix some Squiz.Scope.MethodScope.Missing
Change-Id: I06a663403816e62aa261210538865554cad8eab1
2020-05-16 22:18:49 +01:00
James D. Forrester
4f2d1efdda Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse
Change-Id: I94a0ae83c65e8ee419bbd1ae1e86ab21ed4d8210
2020-01-10 09:32:25 -08:00
Daimona Eaytoy
8ba620b15a Fixup phan warning toomanyparams (part 2)
Bug: T231636
Change-Id: Idde7a766bb0d084d6b67bb0c940d7ad704847ad2
2019-10-10 12:52:01 +00:00
Ostrzyciel
ae0e0f4d3b Make WantedQueryPage::makeWlhLink protected
Bug: T231481
Change-Id: I6ace1bb99879ec8256b29f86220e8fc2e785f593
2019-08-28 19:13:40 +02:00
Umherirrender
a3da44c7df Change ResultWrapper to IResultWrapper in pagers and special pages
There is no need for a specific type, the interface implementation is
enough

Change-Id: I22ec4d3a9a19fc86efc9a2deb06f810695d38c85
2018-04-04 14:52:10 +02:00
Umherirrender
f739a8f368 Improve some parameter docs
Add missing @return and @param to function docs and fixed some @param

Change-Id: I810727961057cfdcc274428b239af5975c57468d
2017-09-10 20:32:31 +02:00
Matěj Suchánek
f44275ec1f Replace Linker::link() with LinkRenderer in special pages
Bug: T149346
Change-Id: I2735750803dc1b2e36be3989caaabbf3232b2923
2017-06-20 20:44:04 +00:00
Aaron Schulz
488a647831 Move IDatabase/IMaintainableDatabase to Rdbms namespace
Change-Id: If7e8a8ff574661fd827de8bcec11d2c39a687300
2017-03-28 15:32:38 -07:00
Eddie Greiner-Petter
4fdfe27aa6 Follow-up Improve sorting on SpecialWanted*-Pages
Change the SpecialWanted*-Pages so that they do sort
1. by the number of links to a site (as is now) and
2. alphabetically for entries which have the same number of links (new)

This is a follow-up for commit 5b15728.
The previous patch was reverted because using getOrderFields and
prefixing each order field with qc_ in fetchFromCache threw DB errors in
production. This follow-up differs in introducing a new function
getCacheOrderFields that defines order fields only for fetching from the
cache and doesn't reuse getOrderFields which is for the raw query
(without cache). It returns ['value'] by default and thus keeps the
known behaviour.

Bug: T4335
Change-Id: Ic01a3c28892c78ba9a9f0a7d665937efe87b44bd
2017-03-23 18:31:00 +00:00
20after4
27bcac72e2 Revert "Improve sorting on SpecialWanted*-Pages"
This reverts commit 5b15728478. The change causes db query errors:
DBQueryError: 1054 Unknown column qc_ra.rd_namespace in order clause

Change-Id: I068beeae70037c959d42419791911c54ca9908a1
2017-03-15 19:41:55 +00:00
Eddie Greiner-Petter
5b15728478 Improve sorting on SpecialWanted*-Pages
Change the SpecialWanted*-Pages so that they do sort
1. by the number of links to a site (as is now) and
2. alphabetically for entries which have the same number of links (new)

Bug: T4335
Change-Id: If54cd52b69007ee81af4733a14be3fd893c4abfe
2017-03-08 17:13:55 +00:00
Aaron Schulz
e01fd44388 Move ResultWrapper subclasses to Rdbms
Change-Id: I6f3f0e85e268b24c57c537aa6ad8016e0b4cdddb
2017-03-03 00:44:41 +00:00
rlot
366dce15f9 Replace Linker::link() usage with LinkRenderer
Replaced deprecated Linker:link() with LinkRenderer

Bug: T149346
Change-Id: Iab158d49b186835a14c357c91a1c5c4f78986238
2016-12-02 19:24:22 +01:00
Florian Schmidt
88db9249f2 Move LinkBatch operations for QueryPage to a helper function
This is easier to maintain as duplicated code everywhere.

This change also adds LinkBatch operations to specialpages, that does
not had it so far, but where it's useful.

Change-Id: I4936ecfb2be3a7709d99570c0561ab0cc9cd754f
2016-10-29 23:09:06 +02:00
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
Ricordisamoa
f86a5590aa Always use 'bool' instead of 'boolean' after '@param' and '@return'
The former is by far the most common.

Skipped:
* resources/lib/jquery.ui/jquery.ui.datepicker.js
* resources/src/mediawiki.special/mediawiki.special.upload.js

Change-Id: I73c93797e745128ba703e4865080c36784caa474
2014-12-10 11:57:31 +00:00
Aaron Schulz
a4a44f7731 Changed some DatabaseBase type hints to IDatabase
Change-Id: I1158c71f110b140473f56d5cbe352da1f4513ad9
2014-12-09 01:05:22 -08:00
Brian Wolff
81740c599d Allow WantedQueryPage subclasses to override the existence check
Some pages are still "wanted" even if the page exists. For
example, consider a page in the file namespace that exists but
doesn't have a corresponding file, in the context of
special:wantedfiles.

Change-Id: Ie40f2baea22b3564e7f06c4fa21bc1efdc0e4d54
2014-09-14 19:14:52 -03:00
Kevin Israel
ffa3518ed5 Move QueryPage and abstract subclasses to specialpage folder
... now that f508561f7b ("Moved $wgQueryPages stuff out of the global
scope and into a function") has been merged, which eliminated hardcoding
of the pathname except in the AutoLoader.

WantedQueryPage is moved to a separate file.

Bug: 60445
Change-Id: If2019492722083819b82afa6302670b94b181098
2014-06-24 20:03:21 -04:00