This reverts commit 2cb32437ef.
Reason for revert: We stopped using Prophecy (T315966).
Bug: T315892
Change-Id: I9eb04d903f7ec715c76836c7b5736b50e6490340
There's only one primary in this house.
I found this after auditing for T263127 and I6ea5c65921891ac6a705.
Change-Id: I0ed7877820cd1f0a37b0f04ea898cd3917dd5075
When the setting for sharding is on, the script actually flush all
values to the first row. Since this is being ran regularly in
production, it has been causing drifts between values and reality.
Tested locally, works fine.
Bug: T315693
Change-Id: Id9fe16eecd153b4ba2b7d28baadec3a9a44b4ee1
Ifec82b5f introduced some new places where we access the native storage
object. One of the purposes of SafeStorage is to catch any errors
that may be thrown by the browser when storage is unavailable.
Bug: T121646
Bug: T315869
Change-Id: Iacc444d97e6a8ef41439e0f6a142c9e4b01af2f0
* This patch relies on extensions setting a flag in their Parsoid ext.
config indicating that a specific tag handler needs nowikis stripped
from #tag arguments.
In the #tag parser function implementation, Parsoid's SiteConfig is
looked up to see if nowiki needs to be stripped.
* This need not be limited to nowikis, but to support extension use in
{{#tag:ext|...}} more generally, we would need to either
(a) implement the #tag parser function in Parsoid natively; OR
(b) find a way to call Parsoid from extensionSubstitution
Soln (a) needs Parsoid to support parser functions natively.
If this general support becomes necessary, a later patch can
generalize this appropriately.
Bug: T272939
Bug: T299103
Depends-On: I6a653889afd42fefb61daefd8ac842107dce8759
Depends-On: I56043e0cb7d355a3f0d08e429bb1dbba6acb4fba
Change-Id: I614153af67b5a14f33b7dfc04bd00dd9e03557d0
At present, $validTestModes[0] is 'legacy' when running
`composer phpunit -- --testsuite=parsertests`
It seems like any other value would be preferable since we're in
ParsoidTestFileSuite.php and we want the isLegacy check in
getTestSkipMessage to be false.
Introduced in a5a04f5
Change-Id: I94699e5cc6dcc7e371c4020faa4dfbf2fa335704
Currently, ForeignAPIRepo caches image metadata and siteinfo in
memcached, with the keys being local to the client wiki. This can result
in a low hit ratio if the same ForeignAPIRepo is shared between multiple
wikis. Since the cache keys for image metadata and site info already
vary on the foreign URL being fetched, it should be possible to make
these cache keys global and thereby allow reusing them across wikis that
share the same file repo configuration.
This is similar to what ForeignDBRepo/ForeignDBFile do already, although
note that for those classes the getSharedCacheKey() calls are not in
their own source, but inherited from LocalRepo/LocalFile.
Bug: T285271
Change-Id: Iaa20a27893e9748cb42fa3a3beb7cd4669b461cb
This reverts commit e794fdd90e.
Reason for revert: caused any anchor to scroll to the top of the page.
Bug: T315620
Change-Id: I731ebbb00d7262ee4c33f75aaa4af3549e574b3d
String offsets in MariaDB are 1-based, except in "Oracle compatible"
mode. SUBSTR(modtoken,0,13) was always the empty string and so the
modtoken comparison was always true. I was able to reproduce a failure
to reach consistency using ring replication.
Add regression test.
Bug: T315271
Change-Id: I74e54e8aba44505dd04426c12d91a9ea0de17f22
Also, make use of MainConfigNames constants where necessary like in
HashConfig map.
NOTE: Since `wgConf` is not a setting, keep using `setMwGlobals()`
in this case.
Change-Id: I8d0c718fd02043835fe122d675cce3d759b30330
This lets you tag a parser test file with:
!! options
parsoid-compatible=wt2html
!! end
to indicate that you want to run only the parsoid wt2html tests on
this file. This is especially useful when gradually adding
integrated-mode parsoid output clauses to an existing test file.
Change-Id: Id870d23da3c127fea61d6b8ab98200c0e4c661e2
This reduces ambiguity between a parser function invocation (where the
colon separates the first argument) and a magic variable invocation
(where the colon is considered part of the magic variable name).
There shouldn't actually be any of these out in the wild, but it is
safer to deprecate than to assume.
Bug: T236813
Change-Id: I69e4f3b794f22a69efb98f5815df61199d077048
Follow up to 5fa2b6362
* Change the SpecialPage::getRelatedNavigationLinks to
be SpecialPage::getAssociatedNavigationLinks
Bug: T313349
Change-Id: I054b391f229b7608d79589d0bc09ad51257a4c1a
