Bartosz Dziewoński 00b74a0e4b Use buildComparison() instead of raw SQL in more API modules (easy cases) ... See ec79aa3943 about the new method. These changes all follow the same simple patterns. More complex cases are handled in I6231b6beae13474d4986929367a9adc6bb76b0db. This commit was created by running the following terrible Ruby script I devised: https://phabricator.wikimedia.org/P34833, then manually reviewing the results: checking that the output makes sense in general, that the affected variables are not used elsewhere in the file, and that no comparison conditions have been lost. A few incorrect changes were undone or corrected. Change-Id: I8ed363bd6b80a9481d44434a526f078cce20220f		2022-09-29 16:04:23 +00:00
..
actions	Remove unneeded initalize of local variables	2022-09-21 21:29:21 +02:00
api	Use buildComparison() instead of raw SQL in more API modules (easy cases)	2022-09-29 16:04:23 +00:00
auth	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
block	Merge "Block: Expose list of block types as constant"	2022-08-29 17:59:42 +00:00
cache	BackLinkCache::queryLinks: Make janky filter more robust	2022-09-12 08:36:51 +00:00
changes	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
changetags	ChangeTags: Improve database query hygine	2022-08-01 19:36:39 +02:00
collation	IcuCollation: Add mappings for versions 70 and 71	2022-08-28 19:17:45 +01:00
CommentFormatter	Get rid of warnings on PHP 8.1	2022-06-13 04:42:20 -04:00
composer
config	GlobalVarConfig: Avoid slowness of array_key_exists on $GLOBALS in PHP 8.1+	2022-09-16 12:18:05 +02:00
content	content: Fix comments in ContentModelChange	2022-09-02 21:08:26 +02:00
context	Setup: Adopt RequestContext::getActionName for most early callers	2022-09-20 00:05:31 +00:00
dao	Simplify assertion for false around wiki id and domain id	2022-06-18 09:49:13 +02:00
db	rdbms: Move Database::factory() to DatabaseFactory service	2022-08-31 10:53:50 +10:00
debug	Do minor code cleanup	2022-06-24 13:52:42 +02:00
deferred	Merge "Replace trivial usages of code in strings with concatenation"	2022-08-26 16:54:56 +00:00
diff	Use default ParserOutput::getText() options for injectTOC	2022-09-08 15:56:14 -04:00
edit	ParsoidOutputStash: make storage backend configurable.	2022-06-14 14:11:37 +01:00
editpage	EditPage: Disentangle edit summary and section title	2022-07-19 09:56:05 +00:00
exception	BadTitleError: Enable 1 hour CDN cache for this error response	2022-09-26 20:27:24 +00:00
export	Remove unneeded initalize of local variables	2022-09-21 21:29:21 +02:00
externalstore	externalstore: Migrate Database::select usages to SelectQueryBuilder	2022-08-05 18:40:37 +02:00
filebackend	filebackend: Remove LBFactory dep from LockManager service	2022-08-02 22:22:48 -07:00
filerepo	filerepo: avoid PHP 8 warnings in File::splitMime() if $mime is null	2022-08-23 17:12:01 -07:00
gallery	Set alt in galleries, despite caption being visible	2022-06-07 18:20:26 -04:00
historyblob	Merge "DiffHistoryBlob: Remove workarounds for old PECL xdiff versions"	2022-06-09 16:14:42 +00:00
Hook
HookContainer	Persistent contribution entry point on the mobile navigation menu	2022-09-28 16:45:06 +00:00
htmlform	Merge "Create an HTMLForm field for selecting a timezone"	2022-09-23 18:16:06 +00:00
http
import	ImportStreamSource::newFromURL() Prevent passing null to fwrite	2022-08-16 13:39:39 +01:00
installer	Localisation updates from https://translatewiki.net.	2022-09-29 08:16:00 +02:00
interwiki	interwiki: Remove outdated CDB references	2022-09-23 16:41:08 +01:00
jobqueue	Remove JobQueueGroup::singleton()/destroySingletons()	2022-09-26 18:10:44 +02:00
json	Add return type to jsonSerialize()	2022-07-02 15:34:02 +00:00
language	Drop some pre-7.4 php compat code	2022-09-29 14:40:13 +00:00
languages	Update name of language of CHO.	2022-09-16 14:17:47 +02:00
libs	Drop some pre-7.4 php compat code	2022-09-29 14:40:13 +00:00
linkeddata
linker	Add support for write new for templatelinks migration	2022-07-12 14:46:54 +02:00
logging	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
mail	mail: Replace deprecated User::getOption	2022-08-05 22:31:05 +00:00
media	Move isWellFormedLanguageTag from Language to LanguageCode	2022-08-30 11:39:26 +00:00
Message
Navigation	Restore compatibility with overrides for IndexPager::makeLink()	2022-09-12 07:52:13 +02:00
objectcache	Merge "SqlBagOStuff: Fix modtoken comparison"	2022-08-19 22:44:58 +00:00
page	Remove unused local variables	2022-09-19 23:07:07 +02:00
pager	IndexPager: $offsets may be shorter than $columns	2022-09-19 13:13:58 +02:00
ParamValidator/TypeDef
parser	Mark ParserOptions::{get,set}MaxTemplateDepth() @internal	2022-09-28 15:22:10 -04:00
password
Permissions	Permissions: Exit early from RestrictionStore::loadRestrictions if no rev id	2022-09-16 00:30:31 +00:00
poolcounter
preferences	Merge "Create an HTMLForm field for selecting a timezone"	2022-09-23 18:16:06 +00:00
profiler
rcfeed
registration	Collect autoloader info in ExtensionProcessor	2022-06-07 17:39:00 +02:00
ResourceLoader	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
Rest	Correctly handle fake revs when previewing or switing VE mode	2022-09-28 18:51:24 +01:00
Revision	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
revisiondelete	Call IContextSource::getAuthority instead of IContextSource::getUser	2022-06-29 22:22:44 +02:00
revisionlist	Get rid of warnings on PHP 8.1	2022-06-13 04:42:20 -04:00
search	Remove unused local variables	2022-09-19 23:07:07 +02:00
session	Merge "BotPasswordSessionProviderTest: Do not set MW_API"	2022-09-26 08:51:57 +00:00
Settings	GlobalVarConfig: Avoid slowness of array_key_exists on $GLOBALS in PHP 8.1+	2022-09-16 12:18:05 +02:00
shell	Replace trivial usages of code in strings with concatenation	2022-08-26 12:26:44 +00:00
site	site: Consistently return null from Site::getDomain()	2022-07-06 19:07:01 +00:00
skins	Componentize menulink + footer	2022-09-28 14:57:37 +00:00
sparql
specialpage	Persistent contribution entry point on the mobile navigation menu	2022-09-28 16:45:06 +00:00
specials	Merge "SpecialVersion: Minor cleanup"	2022-09-28 19:32:40 +00:00
Storage	Storage: Remove using LoadBalancer::getConnectionRef in NameTableStore	2022-08-08 15:16:14 +00:00
templates
tidy	Merge "parser: Use a <meta> tag for the internal TOC_PLACEHOLDER"	2022-09-09 21:12:34 +00:00
title	docs: Clarify that functions returning namespace names include underscores (not spaces)	2022-08-30 21:15:19 +00:00
upload	UploadStash: Check if us_prop is set in the fileMetadata	2022-08-02 18:15:33 +01:00
user	Remove unneeded initalize of local variables	2022-09-21 21:29:21 +02:00
utils	SQLPlatform: Introduce buildComparison()	2022-09-10 04:22:19 +02:00
watcheditem	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
watchlist	Setup: Remove internal short-cut config $wgUseEnotif	2022-08-17 23:41:30 +02:00
widget	Make use of ?? and ?: operators where it makes sense	2022-08-04 21:43:12 +02:00
xml
.htaccess
ActorMigration.php	Soft-deprecate the remainder of ActorMigration	2022-09-29 14:39:22 +02:00
ActorMigrationBase.php	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
AutoLoader.php	Merge "Collect autoloader info in ExtensionProcessor"	2022-06-08 06:11:58 +00:00
BadFileLookup.php
BootstrapHelperFunctions.php
CategoriesRdf.php
Category.php	Category: Migrate to use SelectQueryBuilder in ::getMembers	2022-07-07 07:50:43 +00:00
CategoryViewer.php	Use SelectQueryBuilder instead of IDatabase::select()	2022-08-01 15:56:20 +01:00
CommentStore.php	Improve docs of various ::getQueryInfo functions	2022-08-13 21:18:44 +02:00
CommentStoreComment.php
config-merge-strategies.php
config-schema.php	Merge "Fix docs for InterwikiCache about .cdb files"	2022-09-19 23:52:22 +00:00
config-vars.php	Revert "Mobile Preferences - display Special:Preferences as a vertical menu"	2022-09-15 21:37:45 +00:00
ConfiguredReadOnlyMode.php	Use type hints in ReadOnlyMode/ConfiguredReadOnlyMode and improve docs	2022-06-20 19:49:51 +02:00
ContentSecurityPolicy.php	Remove unused key variable from foreach loops	2022-09-21 21:18:43 +02:00
DefaultSettings.php
Defines.php	Prepare active branch following REL1_39 cut, labelling as 1.40-alpha	2022-09-05 20:30:54 -04:00
DeprecatedGlobal.php
DerivativeRequest.php
DevelopmentSettings.php
DummyLinker.php
EditPage.php	Remove unneeded initalize of local variables	2022-09-21 21:29:21 +02:00
Emptiable.php
EventRelayerGroup.php
ExtensionInfo.php
FauxRequest.php
FauxRequestUpload.php
FauxResponse.php
FeedUtils.php
FileDeleteForm.php
ForeignResourceManager.php	ForeignResourceManager: Property and function docblocks	2022-08-16 21:42:46 +00:00
ForkController.php	Hard deprecate JobQueueGroup::singleton()/destroySingletons()	2022-06-24 18:48:31 +02:00
FormOptions.php
GitInfo.php	GitInfo: simplify and prepare for converting to a service	2022-06-30 00:09:48 +00:00
GlobalFunctions.php	Remove hard-deprecated wfReadOnly/wfReadOnlyReason	2022-09-23 22:44:44 +02:00
HeaderCallback.php
Hooks.php
Html.php	Handle null passed to wfShorthandToInteger() and Html::element()	2022-07-12 13:21:18 +00:00
HtmlHelper.php
Linker.php	Merge "Linker::generateTOC(): distinguish between $anchor and $linkAnchor"	2022-09-22 23:57:07 +00:00
LinkFilter.php	Make use of ?? and ?: operators where it makes sense	2022-08-04 21:43:12 +02:00
ListToggle.php
MagicWord.php
MagicWordArray.php
MagicWordFactory.php
MainConfigNames.php	Revert "Mobile Preferences - display Special:Preferences as a vertical menu"	2022-09-15 21:37:45 +00:00
MainConfigNames.template	Update docstring per introduction of maintenance/generateConfigSchema.php	2022-08-04 09:42:47 +02:00
MainConfigSchema.php	interwiki: Remove outdated CDB references	2022-09-23 16:41:08 +01:00
MediaWiki.php	rdbms: Remove synchronous pre-send waitForReplication fallback	2022-08-24 20:52:17 +00:00
MediaWikiServices.php	Merge "rdbms: Move Database::factory() to DatabaseFactory service"	2022-09-02 01:51:38 +00:00
MediaWikiVersionFetcher.php
MergeHistory.php	Remove unneeded use of TitleValue::newFromPage	2022-07-31 12:26:11 +00:00
MovePage.php	Use SelectQueryBuilder instead of IDatabase::select()	2022-08-01 15:56:20 +01:00
MWTimestamp.php	Hard-deprecate MWTimestamp::getHumanTimestamp	2022-06-20 02:20:25 +00:00
NoLocalSettings.php
OrderedStreamingForkController.php
OutputHandler.php	Remove Flash cross-domain policy mangling	2022-07-22 11:44:49 +10:00
OutputPage.php	BadTitleError: Enable 1 hour CDN cache for this error response	2022-09-26 20:27:24 +00:00
PageProps.php	PageProps: Migrate Database::select usages to SelectQueryBuilder	2022-08-05 18:35:48 +02:00
PathRouter.php
PHPVersionCheck.php	Prepare active branch following REL1_39 cut, labelling as 1.40-alpha	2022-09-05 20:30:54 -04:00
Pingback.php
ProtectionForm.php	Replace deprecated wfReadOnly/wfReadOnlyReason	2022-06-20 15:35:24 +00:00
ProxyLookup.php
RawMessage.php
ReadOnlyMode.php	Use type hints in ReadOnlyMode/ConfiguredReadOnlyMode and improve docs	2022-06-20 19:49:51 +02:00
ServiceWiring.php	Merge "HTMLTransform: do not presume wikitext"	2022-09-22 17:40:04 +00:00
Setup.php	Remove deprecated $wgParser	2022-08-03 14:40:16 +02:00
SetupDynamicConfig.php	docs: Fix broken references to docs/Configuration.md	2022-09-07 16:36:21 +00:00
SiteConfiguration.php	Merge "SiteConfiguration: Document some non-obvious optimizations"	2022-08-04 23:32:07 +00:00
SiteStats.php	SiteStats: Migrate Database::select usages to SelectQueryBuilder	2022-08-05 18:45:48 +02:00
SiteStatsInit.php	SiteStats: Make sure initSiteStats.php re-distribute values	2022-08-22 12:24:56 +00:00
Status.php
StreamFile.php
StubGlobalUser.php
StubObject.php
StubUserLang.php
TemplateParser.php
TemplatesOnThisPageFormatter.php
Title.php	Restore negative response cache in getDbPageLanguageCode	2022-09-06 05:56:45 +00:00
TitleArray.php
TitleArrayFromResult.php	Get rid of warnings on PHP 8.1	2022-06-13 04:42:20 -04:00
TitleFactory.php
TrackingCategories.php
WebRequest.php	Support CDN query parameter re-ordering	2022-08-09 01:53:38 +00:00
WebRequestUpload.php
WebResponse.php	Drop some pre-7.4 php compat code	2022-09-29 14:40:13 +00:00
WebStart.php
WikiMap.php
WikiReference.php