Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes
History
Brian Wolff 024915bbcd Separate RevisionOutputCache::makeParserOutputKey from no revid case 
If the revision id is null, the item should not be cachable.
However, you still need a poolcounter work key for such cases,
and this method was used for both. This is confusing and seems
dangerous, so split into two methods, one where a revision id
is required, and another one where it is optional that should
only be used when it is not for a cache key.

This also fixes a warning about null revId on php 8.1 in tests.

Bug: T313663
Change-Id: Id685caeecf21d058bfd8446d9b5e21f0f11e0177
2022-09-09 18:24:27 -07:00
..
actions tests: don't assume wgLanguageCode is 'en' 2022-07-21 19:32:41 -04:00
api watcheditem: Replace deprecated User::getOption 2022-08-05 22:31:09 +00:00
auth tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-19 15:42:15 +01:00
block tests: Remove resetServiceForTesting after overrideConfigValues 2022-07-27 23:08:27 +02:00
cache tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
changes tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
changetags tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
collation IcuCollation: Remove unnecessary rtrim() and unset() 2022-05-21 02:02:39 -04:00
config
content Merge "Use canonical parser options when rendering JavaScript/CSS for side effects" 2022-07-28 19:51:45 +00:00
context Revert "Setup: Promote clearActionName log message to runtime warning" 2022-07-12 10:17:59 +00:00
db Allow DB config to be reloaded on the fly 2022-08-05 17:32:12 +02:00
debug tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
deferred tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
diff tests: Migrate setMwGlobals() to overrideConfigValue(s)() 2022-07-23 05:53:49 +01:00
editpage tests: Migrate setMwGlobals() to overrideConfigValue(s) 2022-07-27 18:07:00 +01:00
exception Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
externalstore Make use of ?? and ?: operators where it makes sense 2022-08-04 21:43:12 +02:00
filebackend tests: Remove resetServiceForTesting after overrideConfigValues 2022-07-27 23:08:27 +02:00
filerepo tests: Migrate setMwGlobals() to overrideConfigValue(s) 2022-07-27 18:07:00 +01:00
GlobalFunctions tests: Migrate setMwGlobals() to overrideConfigValue(s) 2022-07-27 18:07:00 +01:00
HookContainer
htmlform tests: Use Title::makeTitle instead of Title::newFromText 2022-07-06 00:44:00 +02:00
http Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
import Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
installer Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
interwiki Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
jobqueue Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
language Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
languages Use yield consistently in grammar tests 2022-06-03 14:52:53 +03:00
libs Merge "objectcache: Remove unused WRITE_SYNC flag" 2022-08-03 00:23:55 +00:00
linkeddata Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
linker tests: Add missing @group Database 2022-08-06 22:55:12 +02:00
logging Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
mail tests: Add missing @group Database 2022-08-06 22:55:12 +02:00
media Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
Message
Navigation tests: don't assume wgLanguageCode is 'en' 2022-07-21 19:32:41 -04:00
objectcache Migrate usage of setMwGlobals() to overrideConfigValue(s) 2022-08-01 06:16:22 +01:00
page rdbms: Stop accepting live connection in DBConnRef constructor 2022-08-08 18:11:31 +02:00
pager Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
ParamValidator/TypeDef tests: Add missing @group Database 2022-08-06 22:55:12 +02:00
parser Migrate from setMwGlobals() to overrideConfigValue(s) 2022-08-02 10:14:10 +01:00
password Add convenience methods for asserting status. 2022-03-16 22:44:25 +01:00
Permissions tests: Remove resetServiceForTesting after overrideConfigValues 2022-07-27 23:08:27 +02:00
poolcounter Separate RevisionOutputCache::makeParserOutputKey from no revid case 2022-09-09 18:24:27 -07:00
preferences Remove deprecated $wgParser 2022-08-03 14:40:16 +02:00
rcfeed Migrate from setMwGlobals() to overrideConfigValue(s) 2022-08-02 10:14:10 +01:00
registration Collect autoloader info in ExtensionProcessor 2022-06-07 17:39:00 +02:00
ResourceLoader ResourceLoader: Add test for mw.loader.state missing response 2022-08-04 16:08:20 -07:00
Rest REST: introduce getPrivateRouteUrl 2022-07-14 13:12:35 +00:00
Revision rdbms: Stop accepting live connection in DBConnRef constructor 2022-08-08 18:11:31 +02:00
search tests: don't assume wgLanguageCode is 'en' 2022-07-21 19:32:41 -04:00
session Support REST API in BotPasswordSessionProvider 2022-07-22 17:15:41 +02:00
shell
site Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
skins Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
sparql Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
specialpage Make ChangesListSpecialPageTest cast to string for php 8.1 2022-07-29 22:12:37 -07:00
specials tests: Add missing @group Database 2022-08-06 22:55:12 +02:00
Storage Storage: Remove using LoadBalancer::getConnectionRef in NameTableStore 2022-08-08 15:16:14 +00:00
title Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
upload Add us-ascii to safeXmlEncodings 2022-04-27 09:59:49 +10:00
user Merge "user: Move logic for unregistered HTTPS pref to User::requiresHTTPS()" 2022-08-06 22:11:39 +00:00
utils Hard deprecated the MWGrants class 2022-07-11 17:10:36 +00:00
watcheditem watcheditem: Replace deprecated User::getOption 2022-08-05 22:31:09 +00:00
ActorMigrationTest.php tests: Use namespaced IDatabase class 2022-05-28 00:09:55 +02:00
ActorMigrationTest.sql
AutoLoaderTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
CategoryTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
CommentStoreCommentTest.php
CommentStoreTest.php
CommentStoreTest.sql
ContentSecurityPolicyTest.php [php8.1] Change override of $wgResourceBasePath for CSP tests 2022-07-25 12:54:04 -07:00
EditPageConstraintsTest.php Merge "EditPage: Disentangle edit summary and section title" 2022-07-19 21:14:32 +00:00
EditPageTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
ExportTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
ExtraParserTest.php tests: Remove resetServiceForTesting after overrideConfigValues 2022-07-27 23:08:27 +02:00
FauxRequestTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
GitInfoTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
HooksTest.php
HtmlTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
LinkerTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
LinkFilterTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
MagicWordFactoryTest.php
MediaWikiServicesTest.php Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
MediaWikiTest.php tests: don't assume wgLanguageCode is 'en' 2022-07-21 19:32:41 -04:00
MediaWikiVersionFetcherTest.php
MergeHistoryTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
MessageTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
MockServiceWiring.php
MovePageTest.php Tests: Use createNoOpMock() shortcut in a few more places 2022-07-18 21:25:31 +00:00
MultiHttpClientTest.php Replace trivial usa of mock builder with createMock() shortcut 2022-07-15 16:43:48 +00:00
MWTimestampTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
OutputPageTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
PagePropsTest.php Hard deprecate PageProps::getInstance() 2022-03-15 22:58:48 +01:00
SampleTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
SiteStatsTest.php
StatusTest.php StatusValue: include type in toString output 2022-06-10 11:09:14 +00:00
TemplateCategoriesTest.php tests: Make sure deferred updates are done and re-enable TemplateCategoriesTest 2022-03-17 13:01:08 +00:00
TestUser.php
TestUserRegistry.php
TimeAdjustTest.php tests: Use overrideConfigValue(s) where necessary 2022-07-16 23:45:52 +01:00
TitleTest.php Replace complicated setup with createNoOpMock() in TitleTest 2022-08-06 09:19:48 +00:00
TitleUrlTest.php tests: Use overrideConfig(Value|Values) where needed 2022-07-12 22:24:50 +00:00
TrackingCategoriesTest.php
WebRequestTest.php Support CDN query parameter re-ordering 2022-08-09 01:53:38 +00:00
WikiMapTest.php tests: Use overrideConfig(Value|Values) where needed 2022-07-12 22:24:50 +00:00
XmlTest.php tests: don't assume wgLanguageCode is 'en' 2022-07-21 19:32:41 -04:00