Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes/GlobalFunctions
History
Thiemo Kreuz e4272518f7 tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 
assertEquals( false, … ) still succeeds when the actual value is 0, null,
an empty string, even an empty array. All these should be reported as a
failure, I would argue.

Note this patch previously also touched assertSame( false ). I reverted
these. The only benefit would have been consistency within this codebase,
but there is no strict reason to prefer one over the other. assertFalse()
and assertSame( false ) are functionally identical.

Change-Id: Ic5f1c7d504e7249002d3184520012e03313137b4
2019-10-04 00:30:36 +00:00
..
GlobalTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
GlobalWithDBTest.php Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
README
WfExpandUrlTest.php GlobalFunctions: Enable patch-coverage for wfExpandUrl test 2018-07-25 18:25:27 +01:00
wfParseUrlTest.php
wfShellExecTest.php Skip ::testT69870() under Windows system 2019-06-22 19:59:27 +00:00
wfThumbIsStandardTest.php

README 

This directory hold tests for includes/GlobalFunctions.php file
which is a pile of functions.