6ba47296d9
There is no way to express that Title::castFromPageIdentity(), Title::castFromPageReference() and Title::castFromLinkTarget() can only return null when the parameter is null. We need to add Phan suppressions or explicit types almost everywhere that these methods are used with parameters that are known to not be null. Instead, introduce new methods Title::newFromPageIdentity() and Title::newFromPageReference() (Title::newFromLinkTarget() already exists), without the null-coalescing behavior, and use them when the parameter is not null. This lets static analysis tools, and humans, easily understand where nulls can't appear. Do the same with the corresponding TitleFactory methods. Change the obvious uses of castFrom*() to newFrom*() (if there is a Phan suppression, a type check, or a method call on the result). Change-Id: Ida4da75953cf3bca372a40dc88022443109ca0cb
64 lines
1.9 KiB
PHP
64 lines
1.9 KiB
PHP
<?php
|
|
/**
|
|
* Copyright © 2009 Roan Kattouw <roan.kattouw@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Page\PageIdentity;
|
|
|
|
/**
|
|
* Import reporter for the API
|
|
* @ingroup API
|
|
*/
|
|
class ApiImportReporter extends ImportReporter {
|
|
private $mResultArr = [];
|
|
|
|
/**
|
|
* @param ?PageIdentity $pageIdentity
|
|
* @param ForeignTitle $foreignTitle
|
|
* @param int $revisionCount
|
|
* @param int $successCount
|
|
* @param array $pageInfo
|
|
* @return void
|
|
*/
|
|
public function reportPage( ?PageIdentity $pageIdentity, $foreignTitle, $revisionCount, $successCount, $pageInfo ) {
|
|
// Add a result entry
|
|
$r = [];
|
|
|
|
if ( $pageIdentity === null ) {
|
|
# Invalid or non-importable title
|
|
$r['title'] = $pageInfo['title'];
|
|
$r['invalid'] = true;
|
|
} else {
|
|
$titleFactory = MediaWikiServices::getInstance()->getTitleFactory();
|
|
ApiQueryBase::addTitleInfo( $r, $titleFactory->newFromPageIdentity( $pageIdentity ) );
|
|
$r['revisions'] = (int)$successCount;
|
|
}
|
|
|
|
$this->mResultArr[] = $r;
|
|
|
|
// Piggyback on the parent to do the logging
|
|
parent::reportPage( $pageIdentity, $foreignTitle, $revisionCount, $successCount, $pageInfo );
|
|
}
|
|
|
|
public function getData() {
|
|
return $this->mResultArr;
|
|
}
|
|
}
|