Follows-up I7555c9b6b510, I6d845bdfbb80, I69b5385868, I4c7d826c7e, I1287f3979ab, which widened the `@covers` annotations of other suites: > We lose useful coverage and spend valuable time keeping these tags > accurate through refactors (or worse, forget to do so). > > I've audited each test to confirm it is a general test of the > subject class, where adding any called methods would be an accepted > change, thus widening it is merely a no-op that clarifies intent > and reduces maintenance. I am not disabling the "only track coverage > of specified subject" benefits, nor am I claiming coverage in > in classes outside the subject under test. > > Tracking tiny details per-method wastes time in keeping references > in sync during refactors, time to realize (and fix) when people > inevitably don't keep them in sync, time lost in finding uncovered > code to write tests for only to realize it was already covered but > not yet claimed, etc. Change-Id: Ie3d6a2b4e79b6aa0dc1d2414a3ae7e2bad209c7b
130 lines
4.4 KiB
PHP
130 lines
4.4 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers ConfigFactory
|
|
*/
|
|
class ConfigFactoryTest extends \MediaWikiIntegrationTestCase {
|
|
|
|
public function testRegister() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'unittest', 'GlobalVarConfig::newInstance' );
|
|
$this->assertInstanceOf( GlobalVarConfig::class, $factory->makeConfig( 'unittest' ) );
|
|
}
|
|
|
|
public function testRegisterInvalid() {
|
|
$factory = new ConfigFactory();
|
|
$this->expectException( InvalidArgumentException::class );
|
|
$factory->register( 'invalid', 'Invalid callback' );
|
|
}
|
|
|
|
public function testRegisterInvalidInstance() {
|
|
$factory = new ConfigFactory();
|
|
$this->expectException( InvalidArgumentException::class );
|
|
$factory->register( 'invalidInstance', (object)[] );
|
|
}
|
|
|
|
public function testRegisterInstance() {
|
|
$config = GlobalVarConfig::newInstance();
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'unittest', $config );
|
|
$this->assertSame( $config, $factory->makeConfig( 'unittest' ) );
|
|
}
|
|
|
|
public function testRegisterAgain() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'unittest', 'GlobalVarConfig::newInstance' );
|
|
$config1 = $factory->makeConfig( 'unittest' );
|
|
|
|
$factory->register( 'unittest', 'GlobalVarConfig::newInstance' );
|
|
$config2 = $factory->makeConfig( 'unittest' );
|
|
|
|
$this->assertNotSame( $config1, $config2 );
|
|
}
|
|
|
|
public function testSalvage() {
|
|
$oldFactory = new ConfigFactory();
|
|
$oldFactory->register( 'foo', 'GlobalVarConfig::newInstance' );
|
|
$oldFactory->register( 'bar', 'GlobalVarConfig::newInstance' );
|
|
$oldFactory->register( 'quux', 'GlobalVarConfig::newInstance' );
|
|
|
|
// instantiate two of the three defined configurations
|
|
$foo = $oldFactory->makeConfig( 'foo' );
|
|
$bar = $oldFactory->makeConfig( 'bar' );
|
|
$quux = $oldFactory->makeConfig( 'quux' );
|
|
|
|
// define new config instance
|
|
$newFactory = new ConfigFactory();
|
|
$newFactory->register( 'foo', 'GlobalVarConfig::newInstance' );
|
|
$newFactory->register( 'bar', static function () {
|
|
return new HashConfig();
|
|
} );
|
|
|
|
// "foo" and "quux" are defined in the old and the new factory.
|
|
// The old factory has instances for "foo" and "bar", but not "quux".
|
|
$newFactory->salvage( $oldFactory );
|
|
|
|
$newFoo = $newFactory->makeConfig( 'foo' );
|
|
$this->assertSame( $foo, $newFoo, 'existing instance should be salvaged' );
|
|
|
|
$newBar = $newFactory->makeConfig( 'bar' );
|
|
$this->assertNotSame( $bar, $newBar, 'don\'t salvage if callbacks differ' );
|
|
|
|
// the new factory doesn't have quux defined, so the quux instance should not be salvaged
|
|
$this->expectException( ConfigException::class );
|
|
$newFactory->makeConfig( 'quux' );
|
|
}
|
|
|
|
public function testGetConfigNames() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'foo', 'GlobalVarConfig::newInstance' );
|
|
$factory->register( 'bar', new HashConfig() );
|
|
|
|
$this->assertEquals( [ 'foo', 'bar' ], $factory->getConfigNames() );
|
|
}
|
|
|
|
public function testMakeConfigWithCallback() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'unittest', 'GlobalVarConfig::newInstance' );
|
|
|
|
$conf = $factory->makeConfig( 'unittest' );
|
|
$this->assertInstanceOf( Config::class, $conf );
|
|
$this->assertSame( $conf, $factory->makeConfig( 'unittest' ) );
|
|
}
|
|
|
|
public function testMakeConfigWithObject() {
|
|
$factory = new ConfigFactory();
|
|
$conf = new HashConfig();
|
|
$factory->register( 'test', $conf );
|
|
$this->assertSame( $conf, $factory->makeConfig( 'test' ) );
|
|
}
|
|
|
|
public function testMakeConfigFallback() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( '*', 'GlobalVarConfig::newInstance' );
|
|
$conf = $factory->makeConfig( 'unittest' );
|
|
$this->assertInstanceOf( Config::class, $conf );
|
|
}
|
|
|
|
public function testMakeConfigWithNoBuilders() {
|
|
$factory = new ConfigFactory();
|
|
$this->expectException( ConfigException::class );
|
|
$factory->makeConfig( 'nobuilderregistered' );
|
|
}
|
|
|
|
public function testMakeConfigWithInvalidCallback() {
|
|
$factory = new ConfigFactory();
|
|
$factory->register( 'unittest', static function () {
|
|
return true; // Not a Config object
|
|
} );
|
|
$this->expectException( UnexpectedValueException::class );
|
|
$factory->makeConfig( 'unittest' );
|
|
}
|
|
|
|
public function testGetDefaultInstance() {
|
|
// NOTE: the global config factory returned here has been overwritten
|
|
// for operation in test mode. It may not reflect LocalSettings.
|
|
$factory = $this->getServiceContainer()->getConfigFactory();
|
|
$this->assertInstanceOf( Config::class, $factory->makeConfig( 'main' ) );
|
|
}
|
|
|
|
}
|