6d84e747b2
Follows-up I7555c9b6b510, I6d845bdfbb80, I69b5385868, I4c7d826c7e, I1287f3979ab, which widened the `@covers` annotations of other suites: > We lose useful coverage and spend valuable time keeping these tags > accurate through refactors (or worse, forget to do so). > > I've audited each test to confirm it is a general test of the > subject class, where adding any called methods would be an accepted > change, thus widening it is merely a no-op that clarifies intent > and reduces maintenance. I am not disabling the "only track coverage > of specified subject" benefits, nor am I claiming coverage in > in classes outside the subject under test. > > Tracking tiny details per-method wastes time in keeping references > in sync during refactors, time to realize (and fix) when people > inevitably don't keep them in sync, time lost in finding uncovered > code to write tests for only to realize it was already covered but > not yet claimed, etc. Change-Id: Ie3d6a2b4e79b6aa0dc1d2414a3ae7e2bad209c7b
79 lines
2 KiB
PHP
79 lines
2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers GlobalVarConfig
|
|
*/
|
|
class GlobalVarConfigTest extends MediaWikiIntegrationTestCase {
|
|
|
|
public function testNewInstance() {
|
|
$config = GlobalVarConfig::newInstance();
|
|
$this->assertInstanceOf( GlobalVarConfig::class, $config );
|
|
$this->setMwGlobals( 'wgBaz', 'somevalue' );
|
|
// Check prefix is set to 'wg'
|
|
$this->assertEquals( 'somevalue', $config->get( 'Baz' ) );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideConstructor
|
|
*/
|
|
public function testConstructor( $prefix ) {
|
|
$var = $prefix . 'GlobalVarConfigTest';
|
|
$this->setMwGlobals( $var, 'testvalue' );
|
|
$config = new GlobalVarConfig( $prefix );
|
|
$this->assertInstanceOf( GlobalVarConfig::class, $config );
|
|
$this->assertEquals( 'testvalue', $config->get( 'GlobalVarConfigTest' ) );
|
|
}
|
|
|
|
public static function provideConstructor() {
|
|
return [
|
|
[ 'wg' ],
|
|
[ 'ef' ],
|
|
[ 'smw' ],
|
|
[ 'blahblahblahblah' ],
|
|
[ '' ],
|
|
];
|
|
}
|
|
|
|
public function testHas() {
|
|
$this->setMwGlobals( 'wgGlobalVarConfigTestHas', 'testvalue' );
|
|
$config = new GlobalVarConfig();
|
|
$this->assertTrue( $config->has( 'GlobalVarConfigTestHas' ) );
|
|
$this->assertFalse( $config->has( 'GlobalVarConfigTestNotHas' ) );
|
|
}
|
|
|
|
public static function provideGet() {
|
|
$set = [
|
|
'wgSomething' => 'default1',
|
|
'wgFoo' => 'default2',
|
|
'efVariable' => 'default3',
|
|
'BAR' => 'default4',
|
|
];
|
|
|
|
foreach ( $set as $var => $value ) {
|
|
$GLOBALS[$var] = $value;
|
|
}
|
|
|
|
return [
|
|
[ 'Something', 'wg', 'default1' ],
|
|
[ 'Foo', 'wg', 'default2' ],
|
|
[ 'Variable', 'ef', 'default3' ],
|
|
[ 'BAR', '', 'default4' ],
|
|
[ 'ThisGlobalWasNotSetAbove', 'wg', false ]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideGet
|
|
* @param string $name
|
|
* @param string $prefix
|
|
* @param string $expected
|
|
*/
|
|
public function testGet( $name, $prefix, $expected ) {
|
|
$config = new GlobalVarConfig( $prefix );
|
|
if ( $expected === false ) {
|
|
$this->expectException( ConfigException::class );
|
|
$this->expectExceptionMessage( 'GlobalVarConfig::get: undefined option:' );
|
|
}
|
|
$this->assertEquals( $expected, $config->get( $name ) );
|
|
}
|
|
}
|