87846c95a6
Follows-up I98d2ecc987, I7555c9b6b5, I6d845bdfbb, I69b5385868, I4c7d826c7e, I1287f3979a, which widened the `@covers` annotations of other suites: > We lose useful coverage and spend valuable time keeping these tags > accurate through refactors (or worse, forget to do so). > > I've audited each test to confirm it is a general test of the > subject class, where adding any called methods would be an accepted > change, thus widening it is merely a no-op that clarifies intent > and reduces maintenance. I am not disabling the "only track coverage > of specified subject" benefits, nor am I claiming coverage in > in classes outside the subject under test. > > Tracking tiny details per-method wastes time in keeping references > in sync during refactors, time to realize (and fix) when people > inevitably don't keep them in sync, time lost in finding uncovered > code to write tests for only to realize it was already covered but > not yet claimed, etc. Change-Id: I133c7b707aab7ceb4f2ecd3be38bd4bd1b194143
72 lines
2.1 KiB
PHP
72 lines
2.1 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Cache\LinkBatchFactory;
|
|
use MediaWiki\Title\Title;
|
|
|
|
/**
|
|
* @covers CdnCacheUpdate
|
|
*/
|
|
class CdnCacheUpdateTest extends MediaWikiIntegrationTestCase {
|
|
|
|
public function testPurgeMergeWeb() {
|
|
$this->setMwGlobals( 'wgCommandLineMode', false );
|
|
$this->setService( 'LinkBatchFactory', $this->createMock( LinkBatchFactory::class ) );
|
|
|
|
$title = Title::newMainPage();
|
|
|
|
$urls1 = [];
|
|
$urls1[] = $title->getCanonicalURL( '?x=1' );
|
|
$urls1[] = $title->getCanonicalURL( '?x=2' );
|
|
$urls1[] = $title->getCanonicalURL( '?x=3' );
|
|
$update1 = $this->newCdnCacheUpdate( $urls1 );
|
|
|
|
$urls2 = [];
|
|
$urls2[] = $title->getCanonicalURL( '?x=2' );
|
|
$urls2[] = $title->getCanonicalURL( '?x=3' );
|
|
$urls2[] = $title->getCanonicalURL( '?x=4' );
|
|
$urls2[] = $title;
|
|
$update2 = $this->newCdnCacheUpdate( $urls2 );
|
|
|
|
$expected = [
|
|
$title->getInternalURL(),
|
|
$title->getInternalURL( 'action=history' ),
|
|
$title->getCanonicalURL( '?x=1' ),
|
|
$title->getCanonicalURL( '?x=2' ),
|
|
$title->getCanonicalURL( '?x=3' ),
|
|
$title->getCanonicalURL( '?x=4' ),
|
|
];
|
|
DeferredUpdates::addUpdate( $update1 );
|
|
DeferredUpdates::addUpdate( $update2 );
|
|
|
|
$this->assertEquals( $expected, $update1->getUrls() );
|
|
|
|
/** @var CdnCacheUpdate $update */
|
|
$update = null;
|
|
DeferredUpdates::clearPendingUpdates();
|
|
DeferredUpdates::addCallableUpdate( function () use ( $urls1, $urls2, &$update ) {
|
|
$update = $this->newCdnCacheUpdate( $urls1 );
|
|
DeferredUpdates::addUpdate( $update );
|
|
DeferredUpdates::addUpdate( $this->newCdnCacheUpdate( $urls2 ) );
|
|
DeferredUpdates::addUpdate(
|
|
$this->newCdnCacheUpdate( $urls2 ),
|
|
DeferredUpdates::PRESEND
|
|
);
|
|
} );
|
|
DeferredUpdates::doUpdates();
|
|
|
|
$this->assertEquals( $expected, $update->getUrls() );
|
|
|
|
$this->assertSame( 0, DeferredUpdates::pendingUpdatesCount(), 'PRESEND update run' );
|
|
}
|
|
|
|
/**
|
|
* @param array $urls
|
|
* @return CdnCacheUpdate
|
|
*/
|
|
private function newCdnCacheUpdate( array $urls ) {
|
|
return $this->getMockBuilder( CdnCacheUpdate::class )
|
|
->setConstructorArgs( [ $urls ] )
|
|
->onlyMethods( [ 'doUpdate' ] )
|
|
->getMock();
|
|
}
|
|
}
|