87846c95a6
Follows-up I98d2ecc987, I7555c9b6b5, I6d845bdfbb, I69b5385868, I4c7d826c7e, I1287f3979a, which widened the `@covers` annotations of other suites: > We lose useful coverage and spend valuable time keeping these tags > accurate through refactors (or worse, forget to do so). > > I've audited each test to confirm it is a general test of the > subject class, where adding any called methods would be an accepted > change, thus widening it is merely a no-op that clarifies intent > and reduces maintenance. I am not disabling the "only track coverage > of specified subject" benefits, nor am I claiming coverage in > in classes outside the subject under test. > > Tracking tiny details per-method wastes time in keeping references > in sync during refactors, time to realize (and fix) when people > inevitably don't keep them in sync, time lost in finding uncovered > code to write tests for only to realize it was already covered but > not yet claimed, etc. Change-Id: I133c7b707aab7ceb4f2ecd3be38bd4bd1b194143
70 lines
1.5 KiB
PHP
70 lines
1.5 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Page\PageIdentityValue;
|
|
|
|
/**
|
|
* @group Search
|
|
* @covers SearchUpdate
|
|
*/
|
|
class SearchUpdateTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @var SearchUpdate
|
|
*/
|
|
private $su;
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$pageIdentity = new PageIdentityValue( 42, NS_MAIN, 'Main_Page', PageIdentityValue::LOCAL );
|
|
$this->su = new SearchUpdate( 0, $pageIdentity );
|
|
}
|
|
|
|
public function updateText( $text ) {
|
|
return trim( $this->su->updateText( $text ) );
|
|
}
|
|
|
|
public function testUpdateText() {
|
|
$this->assertEquals(
|
|
'test',
|
|
$this->updateText( '<div>TeSt</div>' ),
|
|
'HTML stripped, text lowercased'
|
|
);
|
|
|
|
$this->assertEquals(
|
|
'foo bar boz quux',
|
|
$this->updateText( <<<EOT
|
|
<table style="color:red; font-size:100px">
|
|
<tr class="scary"><td><div>foo</div></td><tr>bar</td></tr>
|
|
<tr><td>boz</td><tr>quux</td></tr>
|
|
</table>
|
|
EOT
|
|
), 'Stripping HTML tables' );
|
|
|
|
$this->assertEquals(
|
|
'a b',
|
|
$this->updateText( 'a > b' ),
|
|
'Handle unclosed tags'
|
|
);
|
|
|
|
$text = str_pad( "foo <barbarbar \n", 10000, 'x' );
|
|
|
|
$this->assertNotEquals(
|
|
'',
|
|
$this->updateText( $text ),
|
|
'T20609'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* T34712: Test if unicode quotes in article links make its search index empty
|
|
*/
|
|
public function testUnicodeLinkSearchIndexError() {
|
|
$text = "text „http://example.com“ text";
|
|
$result = $this->updateText( $text );
|
|
$processed = preg_replace( '/Q/u', 'Q', $result );
|
|
$this->assertTrue(
|
|
$processed != '',
|
|
'Link surrounded by unicode quotes should not fail UTF-8 validation'
|
|
);
|
|
}
|
|
}
|