4938038175
This reduces confidence in the test. There is no guruantee that it won't return the same value twice during the duration of a full PHPUnit run of all test suites, whether twice in a row or 20 minutes apart. For a test that needs a string of any kind, use an explicit, consinstent and cheap literal value. For a test that specifically needs some kind of uniqueness compared to something else within the same test case, do so explicitly. Tests that require something globally unique (for some undefined/vague definition of "global") were not found, and should not exist anyway. Also, in libs/objectcache tests, fix order of parameters in some assertions (expected first, then actual), and use assertFalse/assertSame instead of assertEqual for cases where false is expected to remove tolerance of other loosely equal values. Change-Id: Ifc60e88178da471330b94bfbf12e2731d2efc77d
62 lines
1.4 KiB
PHP
62 lines
1.4 KiB
PHP
<?php
|
|
|
|
class ReplicatedBagOStuffTest extends MediaWikiTestCase {
|
|
/** @var HashBagOStuff */
|
|
private $writeCache;
|
|
/** @var HashBagOStuff */
|
|
private $readCache;
|
|
/** @var ReplicatedBagOStuff */
|
|
private $cache;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
|
|
$this->writeCache = new HashBagOStuff();
|
|
$this->readCache = new HashBagOStuff();
|
|
$this->cache = new ReplicatedBagOStuff( [
|
|
'writeFactory' => $this->writeCache,
|
|
'readFactory' => $this->readCache,
|
|
] );
|
|
}
|
|
|
|
/**
|
|
* @covers ReplicatedBagOStuff::set
|
|
*/
|
|
public function testSet() {
|
|
$key = 'a key';
|
|
$value = 'a value';
|
|
$this->cache->set( $key, $value );
|
|
|
|
// Write to master.
|
|
$this->assertEquals( $value, $this->writeCache->get( $key ) );
|
|
// Don't write to replica. Replication is deferred to backend.
|
|
$this->assertFalse( $this->readCache->get( $key ) );
|
|
}
|
|
|
|
/**
|
|
* @covers ReplicatedBagOStuff::get
|
|
*/
|
|
public function testGet() {
|
|
$key = 'a key';
|
|
|
|
$write = 'one value';
|
|
$this->writeCache->set( $key, $write );
|
|
$read = 'another value';
|
|
$this->readCache->set( $key, $read );
|
|
|
|
// Read from replica.
|
|
$this->assertEquals( $read, $this->cache->get( $key ) );
|
|
}
|
|
|
|
/**
|
|
* @covers ReplicatedBagOStuff::get
|
|
*/
|
|
public function testGetAbsent() {
|
|
$key = 'a key';
|
|
$value = 'a value';
|
|
$this->writeCache->set( $key, $value );
|
|
|
|
// Don't read from master. No failover if value is absent.
|
|
$this->assertFalse( $this->cache->get( $key ) );
|
|
}
|
|
}
|