wiki.techinc.nl/tests/phpunit/includes/specials/SpecialSearchTest.php
Tim Starling 68c433bd23 Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.

General principles:
* Use DI if it is already used. We're not changing the way state is
  managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
  is a service, it's a more generic interface, it is the only
  thing that provides isRegistered() which is needed in some cases,
  and a HookRunner can be efficiently constructed from it
  (confirmed by benchmark). Because HookContainer is needed
  for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
  SpecialPage and ApiBase have getHookContainer() and getHookRunner()
  methods in the base class, and classes that extend that base class
  are not expected to know or care where the base class gets its
  HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
  getHookRunner() methods, getting them from the global service
  container. The point of this is to ease migration to DI by ensuring
  that call sites ask their local friendly base class rather than
  getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
  methods did not seem warranted, there is a private HookRunner property
  which is accessed directly. Very rarely (two cases), there is a
  protected property, for consistency with code that conventionally
  assumes protected=private, but in cases where the class might actually
  be overridden, a protected accessor is preferred over a protected
  property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
  global code. In a few cases it was used for objects with broken
  construction schemes, out of horror or laziness.

Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore

Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router

setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine

Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-05-30 14:23:28 +00:00

397 lines
10 KiB
PHP

<?php
use MediaWiki\MediaWikiServices;
/**
* Test class for SpecialSearch class
* Copyright © 2012, Antoine Musso
*
* @author Antoine Musso
* @group Database
*/
class SpecialSearchTest extends MediaWikiTestCase {
/**
* @covers SpecialSearch::load
* @covers SpecialSearch::showResults
*/
public function testValidateSortOrder() {
$ctx = new RequestContext();
$ctx->setRequest( new FauxRequest( [
'search' => 'foo',
'fulltext' => 1,
'sort' => 'invalid',
] ) );
$sp = Title::makeTitle( NS_SPECIAL, 'Search' );
MediaWikiServices::getInstance()
->getSpecialPageFactory()
->executePath( $sp, $ctx );
$html = $ctx->getOutput()->getHTML();
$this->assertRegExp( '/class="warningbox"/', $html, 'must contain warnings' );
$this->assertRegExp( '/Sort order of invalid is unrecognized/',
$html, 'must tell user sort order is invalid' );
}
/**
* @covers SpecialSearch::load
* @dataProvider provideSearchOptionsTests
* @param array $requested Request parameters. For example:
* [ 'ns5' => true, 'ns6' => true ]. Null to use default options.
* @param array $userOptions User options to test with. For example:
* [ 'searchNs5' => 1 ];. Null to use default options.
* @param string $expectedProfile An expected search profile name
* @param array $expectedNS Expected namespaces
* @param string $message
*/
public function testProfileAndNamespaceLoading( $requested, $userOptions,
$expectedProfile, $expectedNS, $message = 'Profile name and namespaces mismatches!'
) {
$context = new RequestContext;
$context->setUser(
$this->newUserWithSearchNS( $userOptions )
);
/*
$context->setRequest( new FauxRequest( [
'ns5'=>true,
'ns6'=>true,
] ));
*/
$context->setRequest( new FauxRequest( $requested ) );
$search = new SpecialSearch();
$search->setContext( $context );
$search->load();
/**
* Verify profile name and namespace in the same assertion to make
* sure we will be able to fully compare the above code. PHPUnit stop
* after an assertion fail.
*/
$this->assertEquals(
[ /** Expected: */
'ProfileName' => $expectedProfile,
'Namespaces' => $expectedNS,
],
[ /** Actual: */
'ProfileName' => $search->getProfile(),
'Namespaces' => $search->getNamespaces(),
],
$message
);
}
public static function provideSearchOptionsTests() {
$defaultNS = MediaWikiServices::getInstance()->getSearchEngineConfig()->defaultNamespaces();
$EMPTY_REQUEST = [];
$NO_USER_PREF = null;
return [
/**
* Parameters:
* <Web Request>, <User options>
* Followed by expected values:
* <ProfileName>, <NSList>
* Then an optional message.
*/
[
$EMPTY_REQUEST, $NO_USER_PREF,
'default', $defaultNS,
'T35270: No request nor user preferences should give default profile'
],
[
[ 'ns5' => 1 ], $NO_USER_PREF,
'advanced', [ 5 ],
'Web request with specific NS should override user preference'
],
[
$EMPTY_REQUEST, [
'searchNs2' => 1,
'searchNs14' => 1,
] + array_fill_keys( array_map( function ( $ns ) {
return "searchNs$ns";
}, $defaultNS ), 0 ),
'advanced', [ 2, 14 ],
'T35583: search with no option should honor User search preferences'
. ' and have all other namespace disabled'
],
];
}
/**
* Helper to create a new User object with given options
* User remains anonymous though
* @param array|null $opt
*/
protected function newUserWithSearchNS( $opt = null ) {
$u = User::newFromId( 0 );
if ( $opt === null ) {
return $u;
}
foreach ( $opt as $name => $value ) {
$u->setOption( $name, $value );
}
return $u;
}
/**
* Verify we do not expand search term in <title> on search result page
* https://gerrit.wikimedia.org/r/4841
* @covers SpecialSearch::setupPage
*/
public function testSearchTermIsNotExpanded() {
$this->setMwGlobals( [
'wgSearchType' => null,
] );
# Initialize [[Special::Search]]
$ctx = new RequestContext();
$term = '{{SITENAME}}';
$ctx->setRequest( new FauxRequest( [ 'search' => $term, 'fulltext' => 1 ] ) );
$ctx->setTitle( Title::newFromText( 'Special:Search' ) );
$search = new SpecialSearch();
$search->setContext( $ctx );
# Simulate a user searching for a given term
$search->execute( '' );
# Lookup the HTML page title set for that page
$pageTitle = $search
->getContext()
->getOutput()
->getHTMLTitle();
# Compare :-]
$this->assertRegExp(
'/' . preg_quote( $term, '/' ) . '/',
$pageTitle,
"Search term '{$term}' should not be expanded in Special:Search <title>"
);
}
public function provideRewriteQueryWithSuggestion() {
return [
[
'With suggestion and no rewritten query shows did you mean',
'/Did you mean: <a[^>]+>first suggestion/',
'first suggestion',
null,
[ Title::newMainPage() ]
],
[
'With rewritten query informs user of change',
'/Showing results for <a[^>]+>first suggestion/',
'asdf',
'first suggestion',
[ Title::newMainPage() ]
],
[
'When both queries have no results user gets no results',
'/There were no results matching the query/',
'first suggestion',
'first suggestion',
[]
],
];
}
/**
* @dataProvider provideRewriteQueryWithSuggestion
* @covers SpecialSearch::showResults
*/
public function testRewriteQueryWithSuggestion(
$message,
$expectRegex,
$suggestion,
$rewrittenQuery,
array $resultTitles
) {
$results = array_map( function ( $title ) {
return SearchResult::newFromTitle( $title );
}, $resultTitles );
$searchResults = new SpecialSearchTestMockResultSet(
$suggestion,
$rewrittenQuery,
$results
);
$mockSearchEngine = $this->mockSearchEngine( $searchResults );
$search = $this->getMockBuilder( SpecialSearch::class )
->setMethods( [ 'getSearchEngine' ] )
->getMock();
$search->expects( $this->any() )
->method( 'getSearchEngine' )
->will( $this->returnValue( $mockSearchEngine ) );
$search->getContext()->setTitle( Title::makeTitle( NS_SPECIAL, 'Search' ) );
$search->getContext()->setLanguage( 'en' );
$search->load();
$search->showResults( 'this is a fake search' );
$html = $search->getContext()->getOutput()->getHTML();
foreach ( (array)$expectRegex as $regex ) {
$this->assertRegExp( $regex, $html, $message );
}
}
protected function mockSearchEngine( $results ) {
$mock = $this->getMockBuilder( SearchEngine::class )
->setMethods( [ 'searchText', 'searchTitle', 'getNearMatcher' ] )
->getMock();
$mock->expects( $this->any() )
->method( 'searchText' )
->will( $this->returnValue( $results ) );
$nearMatcherMock = $this->getMockBuilder( SearchNearMatcher::class )
->disableOriginalConstructor()
->setMethods( [ 'getNearMatch' ] )
->getMock();
$nearMatcherMock->expects( $this->any() )
->method( 'getNearMatch' )
->willReturn( $results->getFirstResult() );
$mock->expects( $this->any() )
->method( 'getNearMatcher' )
->willReturn( $nearMatcherMock );
$mock->setHookContainer( MediaWikiServices::getInstance()->getHookContainer() );
return $mock;
}
/**
* @covers SpecialSearch::execute
*/
public function testSubPageRedirect() {
$this->setMwGlobals( [
'wgScript' => '/w/index.php',
] );
$ctx = new RequestContext;
$sp = Title::newFromText( 'Special:Search/foo_bar' );
MediaWikiServices::getInstance()->getSpecialPageFactory()->executePath( $sp, $ctx );
$url = $ctx->getOutput()->getRedirect();
$parts = parse_url( $url );
$this->assertEquals( '/w/index.php', $parts['path'] );
parse_str( $parts['query'], $query );
$this->assertEquals( 'Special:Search', $query['title'] );
$this->assertEquals( 'foo bar', $query['search'] );
}
/**
* If the 'search-match-redirect' user pref is false, then SpecialSearch::goResult() should
* return null
*
* @covers SpecialSearch::goResult
*/
public function testGoResult_userPrefRedirectOn() {
$context = new RequestContext;
$context->setUser(
$this->newUserWithSearchNS( [ 'search-match-redirect' => false ] )
);
$context->setRequest(
new FauxRequest( [ 'search' => 'TEST_SEARCH_PARAM', 'fulltext' => 1 ] )
);
$search = new SpecialSearch();
$search->setContext( $context );
$search->load();
$this->assertNull( $search->goResult( 'TEST_SEARCH_PARAM' ) );
}
/**
* If the 'search-match-redirect' user pref is true, then SpecialSearch::goResult() should
* NOT return null if there is a near match found for the search term
*
* @covers SpecialSearch::goResult
*/
public function testGoResult_userPrefRedirectOff() {
// mock the search engine so it returns a near match for an arbitrary search term
$searchResults = new SpecialSearchTestMockResultSet(
'TEST_SEARCH_SUGGESTION',
'',
[ SearchResult::newFromTitle( Title::newMainPage() ) ]
);
$mockSearchEngine = $this->mockSearchEngine( $searchResults );
$search = $this->getMockBuilder( SpecialSearch::class )
->setMethods( [ 'getSearchEngine' ] )
->getMock();
$search->expects( $this->any() )
->method( 'getSearchEngine' )
->will( $this->returnValue( $mockSearchEngine ) );
// set up a mock user with 'search-match-redirect' set to true
$context = new RequestContext;
$context->setUser(
$this->newUserWithSearchNS( [ 'search-match-redirect' => true ] )
);
$context->setRequest(
new FauxRequest( [ 'search' => 'TEST_SEARCH_PARAM', 'fulltext' => 1 ] )
);
$search->setContext( $context );
$search->load();
$this->assertNotNull( $search->goResult( 'TEST_SEARCH_PARAM' ) );
}
}
class SpecialSearchTestMockResultSet extends SearchResultSet {
protected $results;
protected $suggestion;
public function __construct(
$suggestion = null,
$rewrittenQuery = null,
array $results = [],
$containedSyntax = false
) {
$this->suggestion = $suggestion;
$this->rewrittenQuery = $rewrittenQuery;
$this->results = $results;
$this->containedSyntax = $containedSyntax;
}
public function expandResults() {
return $this->results;
}
public function getTotalHits() {
return $this->numRows();
}
public function hasSuggestion() {
return $this->suggestion !== null;
}
public function getSuggestionQuery() {
return $this->suggestion;
}
public function getSuggestionSnippet() {
return $this->suggestion;
}
public function hasRewrittenQuery() {
return $this->rewrittenQuery !== null;
}
public function getQueryAfterRewrite() {
return $this->rewrittenQuery;
}
public function getQueryAfterRewriteSnippet() {
return htmlspecialchars( $this->rewrittenQuery );
}
public function getFirstResult() {
if ( count( $this->results ) === 0 ) {
return null;
}
return $this->results[0]->getTitle();
}
}