6e9b4f0e9c
Per wikitech-l consensus: https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html Notes: * Disabled CallTimePassByReference due to false positives (T127163) Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
74 lines
1.9 KiB
PHP
74 lines
1.9 KiB
PHP
<?php
|
|
/**
|
|
* @author Antoine Musso
|
|
* @copyright Copyright © 2013, Antoine Musso
|
|
* @copyright Copyright © 2013, Wikimedia Foundation Inc.
|
|
* @file
|
|
*/
|
|
|
|
class MWExceptionHandlerTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @covers MWExceptionHandler::getRedactedTrace
|
|
*/
|
|
public function testGetRedactedTrace() {
|
|
$refvar = 'value';
|
|
try {
|
|
$array = [ 'a', 'b' ];
|
|
$object = new stdClass();
|
|
self::helperThrowAnException( $array, $object, $refvar );
|
|
} catch ( Exception $e ) {
|
|
}
|
|
|
|
# Make sure our stack trace contains an array and an object passed to
|
|
# some function in the stacktrace. Else, we can not assert the trace
|
|
# redaction achieved its job.
|
|
$trace = $e->getTrace();
|
|
$hasObject = false;
|
|
$hasArray = false;
|
|
foreach ( $trace as $frame ) {
|
|
if ( !isset( $frame['args'] ) ) {
|
|
continue;
|
|
}
|
|
foreach ( $frame['args'] as $arg ) {
|
|
$hasObject = $hasObject || is_object( $arg );
|
|
$hasArray = $hasArray || is_array( $arg );
|
|
}
|
|
|
|
if ( $hasObject && $hasArray ) {
|
|
break;
|
|
}
|
|
}
|
|
$this->assertTrue( $hasObject,
|
|
"The stacktrace must have a function having an object has parameter" );
|
|
$this->assertTrue( $hasArray,
|
|
"The stacktrace must have a function having an array has parameter" );
|
|
|
|
# Now we redact the trace.. and make sure no function arguments are
|
|
# arrays or objects.
|
|
$redacted = MWExceptionHandler::getRedactedTrace( $e );
|
|
|
|
foreach ( $redacted as $frame ) {
|
|
if ( !isset( $frame['args'] ) ) {
|
|
continue;
|
|
}
|
|
foreach ( $frame['args'] as $arg ) {
|
|
$this->assertNotInternalType( 'array', $arg );
|
|
$this->assertNotInternalType( 'object', $arg );
|
|
}
|
|
}
|
|
|
|
$this->assertEquals( 'value', $refvar, 'Ensuring reference variable wasn\'t changed' );
|
|
}
|
|
|
|
/**
|
|
* Helper function for testExpandArgumentsInCall
|
|
*
|
|
* Pass it an object and an array, and something by reference :-)
|
|
*
|
|
* @throws Exception
|
|
*/
|
|
protected static function helperThrowAnException( $a, $b, &$c ) {
|
|
throw new Exception();
|
|
}
|
|
}
|