Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes
History
Timo Tijhof 0be2e83ef4 resourceloader: Restore feedback for SkinModule invalid argument 
This was added in 381499a675 in response to the issue that when a skin
adopts a feature that was new in MW 1.36, it caused an exception when
that version of the skin is then installed on MW 1.35. That's expected,
and generally helpful because the default support policy requires
like-for-like (MW 1.35 with REL1_35, this applies to all skins and
extensions, except for a few like Translate and SemanticMediaWiki).

However, while supporting LTS within master is unusual, there are
indeed the Translate/SemanticMediaWiki projects, and this problem has
already been solved years ago there by using a conditional with
$wgVersion. The proposed approach on T271441 actually also involves
such a conditional, but late at runtime instead of in the module
definition. Anyway, the way it was fixed in Timeless already solves
the problem by not passing down the invalid feature in the first
place, thus making the 381499a675 patch obsolete. I'm not aware of
any skin in Gerrit having such a compat policy, but if they exist,
they can fix it the same way, by defining the module in code with
a condition, just as Translate/SemanticMediaWiki do.

Bug: T271441
Change-Id: If97b3d04ac1e3355ee4f229db11e524d24ebd27a
2021-05-14 20:30:15 +00:00
..
actions Merge "Hard deprecate watchlist methods in WatchAction" 2021-05-05 17:24:55 +00:00
api ApiPageSet: replace Title in method signatures 2021-05-12 23:17:59 +02:00
auth Inject load balancers into some authentication providers 2021-05-10 16:56:32 +00:00
block Introduce Block interface and replace AbstractBlock. 2021-05-11 11:36:11 +02:00
cache GenderCacheTest: fix call to overrideMwServices() 2021-05-12 07:37:19 +00:00
changes build: Upgrade mediawiki-codesniffer from v35.0.0 to v36.0.0 2021-04-29 13:00:15 -07:00
changetags Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
collation
config
content build: Upgrade mediawiki-codesniffer from v35.0.0 to v36.0.0 2021-04-29 13:00:15 -07:00
context Remove $actor field from UsererIdentityValue 2021-04-13 18:18:06 +00:00
db rdbms: cleanup getServer() and connection parameter fields in Database 2021-05-05 19:44:02 +00:00
debug Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
deferred Deferred updates: remove Title from method signatures. 2021-05-11 11:17:02 +02:00
diff Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
editpage Update Legoktm's email address 2021-05-02 05:39:37 +00:00
exception Remove sepate getMockWgOut() method in exception tests 2021-03-08 03:54:14 +00:00
externalstore Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
filebackend Hard deprecate FileBackendGroup::singleton() and ::destroySingletons() 2021-05-04 21:03:41 +02:00
filerepo Hard deprecate LockManagerGroup::singleton() and ::destroySingletons() 2021-05-03 18:42:31 +00:00
GlobalFunctions Drop global function wfNegotiateType, deprecated in 1.36 2021-05-10 15:09:49 -07:00
HookContainer
htmlform
http phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
import ImportReporter: replace Title in method signatures 2021-05-12 23:25:21 +02:00
installer Installer: Do not use mediawiki.skinning.interface module 2021-04-15 11:11:32 -07:00
interwiki Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
jobqueue Merge "Add MediaWikiIntegrationTestCase::runJobs() and use it" 2021-05-05 03:15:17 +00:00
language
libs Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
linkeddata
linker Pass PageReference as possible parameter to LinkRenderer methods 2021-05-10 16:01:27 -04:00
logging Merge "Allow action blocks to be logged via block log parameters" 2021-05-05 21:26:46 +00:00
mail Use UserIdentityValue in tests where possible 2021-04-22 09:32:43 +02:00
media phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
Message phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
Navigation
objectcache
page ArticleViewTest: Make timestamp tests deterministic 2021-05-12 15:35:35 +02:00
pager Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
ParamValidator/TypeDef
parser Tests: use UserIdentityValue instead of mock User objects 2021-05-03 15:41:48 +00:00
password UserPasswordPolicyTest: Replace PasswordCannotMatchBlacklist with PasswordCannotMatchDefaults 2021-04-18 23:52:57 +01:00
Permissions phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
poolcounter ParserCache: only use in-process caching for metadata 2021-04-06 17:53:38 -06:00
preferences Use DummyServicesTrait::getDummyNamespaceInfo in more places 2021-05-05 01:53:30 +00:00
rcfeed phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
registration Add extension.json merge strategy "provide_default" 2021-05-04 16:02:55 +10:00
resourceloader resourceloader: Restore feedback for SkinModule invalid argument 2021-05-14 20:30:15 +00:00
Rest Fix order of parameters in assertions 2021-05-03 15:50:53 +00:00
Revision rdbms: cleanup getServer() and connection parameter fields in Database 2021-05-05 19:44:02 +00:00
search Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
session Hard deprecate the setters of SessionProvider class 2021-05-12 19:49:50 +00:00
shell
site Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
skins getFooterIcons should not return empty arrays, part 2, Electric Boogaloo 2021-05-09 20:12:06 +00:00
sparql
specialpage Fix changes list "hide myself" feature 2021-05-12 09:45:59 +10:00
specials Fix order of joins in SpecialRecentChanges 2021-05-05 09:29:40 -07:00
Storage SqlBlobStoreTest: test against tt:10000 instead of tt:1000 2021-05-10 19:00:29 +00:00
title Add DummyServicesTrait::getDummyInterwikiLookup 2021-05-05 10:57:59 -07:00
upload
user Merge "Simplify and cleanup TalkPageNotificationManagerTest" 2021-05-12 22:51:56 +00:00
utils Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
watcheditem Add MediaWikiIntegrationTestCase::runJobs() and use it 2021-05-05 02:51:30 +00:00
ActorMigrationTest.php Split a base class out of ActorMigration 2021-05-03 15:14:06 +10:00
ActorMigrationTest.sql
AutoLoaderTest.php Add script for resolving class names to files 2021-04-16 11:04:39 +00:00
CategoryTest.php Simplify database handling in CategoryTest 2021-05-09 00:53:31 +00:00
CommentStoreCommentTest.php
CommentStoreTest.php build: Upgrade mediawiki-codesniffer from v35.0.0 to v36.0.0 2021-04-29 13:00:15 -07:00
CommentStoreTest.sql
ContentSecurityPolicyTest.php build: Swap deprecated @codingStandardsIgnore to phpcs:ignore 2021-04-04 21:18:22 +02:00
EditPageConstraintsTest.php Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
EditPageTest.php EditPage::getExpectedParentRevision(): guard against null edittime 2021-05-06 11:38:30 +10:00
ExportTest.php
ExtraParserTest.php Parser: Trim trailing whitespace as the last step in pre-save transform 2021-04-14 20:53:49 +02:00
FauxRequestTest.php
GitInfoTest.php
HooksTest.php
HtmlTest.php
LinkerTest.php
LinkFilterTest.php
MagicWordFactoryTest.php
MediaWikiServicesTest.php
MediaWikiTest.php
MediaWikiVersionFetcherTest.php
MergeHistoryTest.php Fix order of parameters in assertions 2021-05-03 15:50:53 +00:00
MessageTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
MockServiceWiring.php
MovePageTest.php Use DummyServicesTrait::getDummyNamespaceInfo in more places 2021-05-05 01:53:30 +00:00
MultiHttpClientTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
MWTimestampTest.php MWTimestampTest: use StaticUserOptionsLookup 2021-05-12 21:05:48 +00:00
OutputPageTest.php build: Upgrade mediawiki-codesniffer from v35.0.0 to v36.0.0 2021-04-29 13:00:15 -07:00
PagePropsTest.php Simplify PagePropsTest 2021-05-03 14:42:27 +00:00
ReadOnlyModeTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
RevisionDbTest.php Clean up hard deprecated Title methods 2021-05-11 07:41:18 -07:00
RevisionTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
RevisionTestModifyableContent.php
RevisionTestModifyableContentHandler.php
SampleTest.php
SiteStatsTest.php
StatusTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
TemplateCategoriesTest.php TemplateCategoriesTest: remove unneeded require of runJobs.php 2021-05-12 07:02:02 +00:00
TestUser.php Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
TestUserRegistry.php
TimeAdjustTest.php
TitleMethodsTest.php Title: avoid instance cache pollution 2021-05-07 11:37:54 +02:00
TitleTest.php Clean up hard deprecated Title methods 2021-05-11 07:41:18 -07:00
WebRequestTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
WikiMapTest.php
XmlTest.php Move Xml::expandAttributes tests to unit tests 2021-03-07 19:27:11 +00:00