Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes/revisiondelete
History
C. Scott Ananian 9e033de4f2 Don't double-escape the ellipses in Language::truncateForVisual() 
It turns out this gets rid of a bunch of suppressed
"SecurityCheck-DoubleEscaped" that appear to have been accurate
warnings.

There seems to have been some confusion about how ::truncateForVisual()
is supposed to be used; in particular it is to be passed *unescaped*
output, because it is not (generally speaking) safe to truncate
HTML-escaped strings.  The goal of ::truncateForVisual() is to have
a specific number of codepoints in the output for display purposes,
the encoding of those codepoints is not an issue (htmlspecialchars
can be applied to the *return value*.)  If you need a specific number
of *bytes* you should be using ::truncateForDatabase().  If you want
a certain number of *HTML bytes* then the ::truncateHtml() method
is probably what you want.

Slightly refactor some code in RevDelLogItem to avoid a false positive.

Bug: T301205
Bug: T290624
Change-Id: I893362e049aedfa699043fcf27caf4815196f748
2022-02-10 17:09:18 -05:00
..
Hook Document hook names in hook interfaces. 2020-09-27 12:03:12 +02:00
RevDelArchivedFileItem.php Don't throw away '0' edit summary 2021-11-24 10:33:36 +00:00
RevDelArchivedFileList.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevDelArchivedRevisionItem.php Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
RevDelArchiveItem.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevDelArchiveList.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevDelFileItem.php SECURITY: properly escape output used within galleries and Special:RevisionDelete 2022-01-10 14:20:48 -06:00
RevDelFileList.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevDelItem.php
RevDelList.php RevDelList: Rename reloadFromMaster to reloadFromPrimary 2021-09-03 20:16:18 +00:00
RevDelLogItem.php Don't double-escape the ellipses in Language::truncateForVisual() 2022-02-10 17:09:18 -05:00
RevDelLogList.php Replace deprecated CommentStore::getStore in RevDelLogItem 2021-08-04 03:26:57 +02:00
RevDelRevisionItem.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
RevDelRevisionList.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevisionDeleter.php RevisionDeleter: Use PageIdentity instead of Title 2021-05-06 13:42:13 +02:00
RevisionDeleteUser.php Refactor global variables to use MediaWikiServices instead 2022-01-10 13:55:53 -05:00