Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/data/ParserCache/1.36-ParserOutput-withMetadata.serialized
C. Scott Ananian ea4bedee9d Remove misleading test in SerializationTestTrain::validateObjectEquality() 
The initial object comparison using `==` compares all the property values
using `==` as well.  This causes (for example) the string "1" to compare
as equal to the number `1`, the empty string `""` to compare as equal
to the number `0` and other surprising things.

It appears that this comparison was done at an attempt at performance
optimization, but that has little place in a test suite.  Use the full
recursive strict comparison instead.

This requires updating one ParserCache test case which was apparently
created incorrectly (or not properly updated) and relied on the
previous behavior (numbers comparing as equal to strings) to pass.

Change-Id: Ife0e9ccc7be0f4933975bb326203693bc15a9658
2022-03-31 09:50:51 -04:00

1 line
2.3 KiB
Text
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

O:12:"ParserOutput":46:{s:5:"mText";s:0:"";s:14:"mLanguageLinks";a:2:{i:0;s:5:"link1";i:1;s:5:"link2";}s:11:"mCategories";a:2:{s:9:"category2";s:1:"1";s:9:"category1";s:1:"2";}s:11:"mIndicators";a:1:{s:10:"indicator1";s:16:"indicator1_value";}s:10:"mTitleText";s:11:"title_text1";s:6:"mLinks";a:2:{i:0;a:1:{s:5:"Link1";i:42;}i:2;a:1:{s:5:"Link2";i:43;}}s:13:"mLinksSpecial";a:0:{}s:10:"mTemplates";a:1:{i:10;a:1:{s:9:"Template1";i:42;}}s:12:"mTemplateIds";a:1:{i:10;a:1:{s:9:"Template1";i:4242;}}s:7:"mImages";a:1:{s:6:"Image1";i:1;}s:18:"mFileSearchOptions";a:1:{s:6:"Image1";a:2:{s:4:"time";s:14:"19731129213309";s:4:"sha1";s:9:"test_sha1";}}s:14:"mExternalLinks";a:1:{s:16:"https://test.org";i:1;}s:15:"mInterwikiLinks";a:1:{s:6:"enwiki";a:2:{s:10:"interwiki1";i:1;s:10:"interwiki2";i:1;}}s:11:"mNewSection";b:1;s:15:"mHideNewSection";b:1;s:10:"mNoGallery";b:0;s:10:"mHeadItems";a:1:{s:4:"tag1";s:10:"head_item1";}s:8:"mModules";a:1:{i:0;s:7:"module1";}s:13:"mModuleStyles";a:1:{i:0;s:13:"module_style1";}s:13:"mJsConfigVars";a:1:{s:4:"key1";s:6:"value1";}s:12:"mOutputHooks";a:1:{i:0;a:2:{i:0;s:5:"hook1";i:1;a:6:{s:7:"boolean";b:1;s:4:"null";N;s:6:"number";i:42;s:6:"string";s:6:"string";s:5:"array";a:3:{i:0;i:1;i:1;i:2;i:2;i:3;}s:3:"map";a:1:{s:3:"key";s:5:"value";}}}}s:9:"mWarnings";a:1:{s:8:"warning1";i:1;}s:9:"mSections";a:2:{i:0;s:8:"section1";i:1;s:8:"section2";}s:11:"mProperties";a:0:{}s:8:"mTOCHTML";s:8:"tochtml1";s:10:"mTimestamp";s:14:"20010419042521";s:11:"mEnableOOUI";b:1;s:26:"ParserOutputmIndexPolicy";s:7:"noindex";s:28:"ParserOutputmExtensionData";a:0:{}s:30:"ParserOutputmLimitReportData";a:1:{s:17:"limit_report_key1";s:6:"value1";}s:32:"ParserOutputmLimitReportJSData";a:1:{s:17:"limit_report_key1";s:6:"value1";}s:34:"ParserOutputmPreventClickjacking";b:0;s:30:"ParserOutputmExtraScriptSrcs";a:0:{}s:31:"ParserOutputmExtraDefaultSrcs";a:0:{}s:29:"ParserOutputmExtraStyleSrcs";a:0:{}s:20:"ParserOutputmFlags";a:1:{s:4:"test";b:1;}s:31:"ParserOutputmSpeculativeRevId";i:42;s:35:"ParserOutputspeculativePageIdUsed";N;s:35:"ParserOutputrevisionTimestampUsed";N;s:36:"ParserOutputrevisionUsedSha1Base36";N;s:32:"ParserOutputmWrapperDivClasses";a:0:{}s:32:"ParserOutputmMaxAdaptiveExpiry";d:INF;s:20:"*mParseUsedOptions";a:0:{}s:10:"mCacheTime";s:0:"";s:12:"mCacheExpiry";N;s:16:"mCacheRevisionId";N;}
Reference in a new issue View git blame Copy permalink