This is possibly not perfect but seems to serve for a start; follows up on r91591 that adds JSMin+ to use it in some unit tests. May want to adjust some related bits. - $wgResourceLoaderValidateJs on by default (can be disabled) - when loading a JS file through ResourceLoaderFileModule or ResourceLoaderWikiModule, parse it using JSMinPlus's JSParser class. If the parser throws an exception, the JS code of the offending file will be replaced by a JS exception throw listing the file or page name, line number (in original form), and description of the error from the parser. - parsing results are cached based on md5 of content to avoid re-parsing identical text - for JS pages loaded via direct load.php request, the parse error is thrown and visible in the JS console/error log Issues: - the primary use case for this is when a single load.php request implements multiple modules via mw.loader.implement() -- the loader catches the exception and skips on to the next module (good) but doesn't re-throw the exception for the JS console. It does log to console if present, but it'll only show up as a regular debug message, not an error. This can suppress visibility of errors in a module that's loaded together with other modules (such as a gadget). - have not done performance testing on the JSParser - have not done thorough unit testing with the JSParser
185 lines
5.2 KiB
PHP
185 lines
5.2 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @author Trevor Parscal
|
|
* @author Roan Kattouw
|
|
*/
|
|
|
|
defined( 'MEDIAWIKI' ) || die( 1 );
|
|
|
|
/**
|
|
* Abstraction for resource loader modules which pull from wiki pages
|
|
*
|
|
* This can only be used for wiki pages in the MediaWiki and User namespaces,
|
|
* because of its dependence on the functionality of
|
|
* Title::isValidCssJsSubpage.
|
|
*/
|
|
abstract class ResourceLoaderWikiModule extends ResourceLoaderModule {
|
|
|
|
/* Protected Members */
|
|
|
|
# Origin is user-supplied code
|
|
protected $origin = self::ORIGIN_USER_SITEWIDE;
|
|
|
|
// In-object cache for title mtimes
|
|
protected $titleMtimes = array();
|
|
|
|
/* Abstract Protected Methods */
|
|
|
|
abstract protected function getPages( ResourceLoaderContext $context );
|
|
|
|
/* Protected Methods */
|
|
|
|
/**
|
|
* @param $title Title
|
|
* @return null|string
|
|
*/
|
|
protected function getContent( $title ) {
|
|
if ( $title->getNamespace() === NS_MEDIAWIKI ) {
|
|
$message = wfMessage( $title->getDBkey() )->inContentLanguage();
|
|
return $message->exists() ? $message->plain() : '';
|
|
}
|
|
if ( !$title->isCssJsSubpage() ) {
|
|
return null;
|
|
}
|
|
$revision = Revision::newFromTitle( $title );
|
|
if ( !$revision ) {
|
|
return null;
|
|
}
|
|
return $revision->getRawText();
|
|
}
|
|
|
|
/* Methods */
|
|
|
|
/**
|
|
* @param $context ResourceLoaderContext
|
|
* @return string
|
|
*/
|
|
public function getScript( ResourceLoaderContext $context ) {
|
|
$scripts = '';
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
if ( $options['type'] !== 'script' ) {
|
|
continue;
|
|
}
|
|
$title = Title::newFromText( $titleText );
|
|
if ( !$title ) {
|
|
continue;
|
|
}
|
|
$script = $this->getContent( $title );
|
|
if ( strval( $script ) !== '' ) {
|
|
$script = $this->validateScriptFile( $titleText, $script );
|
|
if ( strpos( $titleText, '*/' ) === false ) {
|
|
$scripts .= "/* $titleText */\n";
|
|
}
|
|
$scripts .= $script . "\n";
|
|
}
|
|
}
|
|
return $scripts;
|
|
}
|
|
|
|
/**
|
|
* @param $context ResourceLoaderContext
|
|
* @return array
|
|
*/
|
|
public function getStyles( ResourceLoaderContext $context ) {
|
|
global $wgScriptPath;
|
|
|
|
$styles = array();
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
if ( $options['type'] !== 'style' ) {
|
|
continue;
|
|
}
|
|
$title = Title::newFromText( $titleText );
|
|
if ( !$title ) {
|
|
continue;
|
|
}
|
|
$media = isset( $options['media'] ) ? $options['media'] : 'all';
|
|
$style = $this->getContent( $title );
|
|
if ( strval( $style ) === '' ) {
|
|
continue;
|
|
}
|
|
if ( $this->getFlip( $context ) ) {
|
|
$style = CSSJanus::transform( $style, true, false );
|
|
}
|
|
$style = CSSMin::remap( $style, false, $wgScriptPath, true );
|
|
if ( !isset( $styles[$media] ) ) {
|
|
$styles[$media] = '';
|
|
}
|
|
if ( strpos( $titleText, '*/' ) === false ) {
|
|
$styles[$media] .= "/* $titleText */\n";
|
|
}
|
|
$styles[$media] .= $style . "\n";
|
|
}
|
|
return $styles;
|
|
}
|
|
|
|
/**
|
|
* @param $context ResourceLoaderContext
|
|
* @return int|mixed
|
|
*/
|
|
public function getModifiedTime( ResourceLoaderContext $context ) {
|
|
$modifiedTime = 1; // wfTimestamp() interprets 0 as "now"
|
|
$mtimes = $this->getTitleMtimes( $context );
|
|
if ( count( $mtimes ) ) {
|
|
$modifiedTime = max( $modifiedTime, max( $mtimes ) );
|
|
}
|
|
return $modifiedTime;
|
|
}
|
|
|
|
/**
|
|
* @param $context ResourceLoaderContext
|
|
* @return bool
|
|
*/
|
|
public function isKnownEmpty( ResourceLoaderContext $context ) {
|
|
return count( $this->getTitleMtimes( $context ) ) == 0;
|
|
}
|
|
|
|
/**
|
|
* Get the modification times of all titles that would be loaded for
|
|
* a given context.
|
|
* @param $context ResourceLoaderContext: Context object
|
|
* @return array( prefixed DB key => UNIX timestamp ), nonexistent titles are dropped
|
|
*/
|
|
protected function getTitleMtimes( ResourceLoaderContext $context ) {
|
|
$hash = $context->getHash();
|
|
if ( isset( $this->titleMtimes[$hash] ) ) {
|
|
return $this->titleMtimes[$hash];
|
|
}
|
|
|
|
$this->titleMtimes[$hash] = array();
|
|
$batch = new LinkBatch;
|
|
foreach ( $this->getPages( $context ) as $titleText => $options ) {
|
|
$batch->addObj( Title::newFromText( $titleText ) );
|
|
}
|
|
|
|
if ( !$batch->isEmpty() ) {
|
|
$dbr = wfGetDB( DB_SLAVE );
|
|
$res = $dbr->select( 'page',
|
|
array( 'page_namespace', 'page_title', 'page_touched' ),
|
|
$batch->constructSet( 'page', $dbr ),
|
|
__METHOD__
|
|
);
|
|
foreach ( $res as $row ) {
|
|
$title = Title::makeTitle( $row->page_namespace, $row->page_title );
|
|
$this->titleMtimes[$hash][$title->getPrefixedDBkey()] =
|
|
wfTimestamp( TS_UNIX, $row->page_touched );
|
|
}
|
|
}
|
|
return $this->titleMtimes[$hash];
|
|
}
|
|
}
|