10cf632683
There is no strong use case for associative "decoration" of constructor arguments (the documentation benefits mentioned in I43aa085 are outweighed by the confusion caused by not failing loudly when someone passes an associative argument by accident, e.g. by omitting an array nesting level), so disallow them but make sure they fail nicely, not with an invalid offset error. Change-Id: I09e4af85ded6a1497b0db0265d2ee6707f91f5e3
132 lines
4 KiB
PHP
132 lines
4 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
class ObjectFactoryTest extends PHPUnit_Framework_TestCase {
|
|
|
|
/**
|
|
* @covers ObjectFactory::getObjectFromSpec
|
|
*/
|
|
public function testClosureExpansionDisabled() {
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
'closure_expansion' => false,
|
|
) );
|
|
$this->assertInstanceOf( 'Closure', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0]() );
|
|
$this->assertInstanceOf( 'Closure', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0]() );
|
|
}
|
|
|
|
/**
|
|
* @covers ObjectFactory::getObjectFromSpec
|
|
*/
|
|
public function testClosureExpansionEnabled() {
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
'closure_expansion' => true,
|
|
) );
|
|
$this->assertInternalType( 'string', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0] );
|
|
$this->assertInternalType( 'string', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0] );
|
|
|
|
$obj = ObjectFactory::getObjectFromSpec( array(
|
|
'class' => 'ObjectFactoryTestFixture',
|
|
'args' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
'calls' => array(
|
|
'setter' => array( function() {
|
|
return 'unwrapped';
|
|
}, ),
|
|
),
|
|
) );
|
|
$this->assertInternalType( 'string', $obj->args[0] );
|
|
$this->assertSame( 'unwrapped', $obj->args[0] );
|
|
$this->assertInternalType( 'string', $obj->setterArgs[0] );
|
|
$this->assertSame( 'unwrapped', $obj->setterArgs[0] );
|
|
}
|
|
|
|
/**
|
|
* @covers ObjectFactory::constructClassInstance
|
|
* @dataProvider provideConstructClassInstance
|
|
*/
|
|
public function testConstructClassInstance( $args ) {
|
|
$obj = ObjectFactory::constructClassInstance(
|
|
'ObjectFactoryTestFixture', $args
|
|
);
|
|
$this->assertSame( $args, $obj->args );
|
|
}
|
|
|
|
public function provideConstructClassInstance() {
|
|
// These args go to 11. I thought about making 10 one louder, but 11!
|
|
return array(
|
|
'0 args' => array( array() ),
|
|
'1 args' => array( array( 1, ) ),
|
|
'2 args' => array( array( 1, 2, ) ),
|
|
'3 args' => array( array( 1, 2, 3, ) ),
|
|
'4 args' => array( array( 1, 2, 3, 4, ) ),
|
|
'5 args' => array( array( 1, 2, 3, 4, 5, ) ),
|
|
'6 args' => array( array( 1, 2, 3, 4, 5, 6, ) ),
|
|
'7 args' => array( array( 1, 2, 3, 4, 5, 6, 7, ) ),
|
|
'8 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, ) ),
|
|
'9 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, ) ),
|
|
'10 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, ) ),
|
|
'11 args' => array( array( 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, ) ),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @expectedException InvalidArgumentException
|
|
*/
|
|
public function testNamedArgs() {
|
|
$args = array( 'foo' => 1, 'bar' => 2, 'baz' => 3 );
|
|
$obj = ObjectFactory::constructClassInstance(
|
|
'ObjectFactoryTestFixture', $args
|
|
);
|
|
}
|
|
}
|
|
|
|
class ObjectFactoryTestFixture {
|
|
public $args;
|
|
public $setterArgs;
|
|
public function __construct( /*...*/ ) {
|
|
$this->args = func_get_args();
|
|
}
|
|
public function setter( /*...*/ ) {
|
|
$this->setterArgs = func_get_args();
|
|
}
|
|
}
|