11e3172c03
The same way it does already for non-error output. This makes it so that doPreOutputCommit() consistently happens between the staging of output and the actual sending of output. It is still allowed for code to bypass this, such as for fatal errors and for handlers that disable OutputPage (like Special:Export). But for cases where we do want to perform doPreOutputCommit(), it should be run consistently between staging and sending so that it can make appropiate decisions based on the current state of OutputPage. Previously, the state of OutputPage seen by doPreOutputCommit() would be the broken/incomplete output of a seemingly succesful (possibly cacheable) user action, which would then, after doPreOutputCommit() runs, be completely replaced by $e->report()/ $out->showErrorPage(). This is a prerequisite for being able to reliably send cookie-block cookies on error pages (next patch). Bug: T233594 Change-Id: Iaeaf5e55a5868e6be534ddda73f3b56b9d6ef8f0
34 lines
1.1 KiB
PHP
34 lines
1.1 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
/**
|
|
* An error page that emits an HTTP 400 Bad Request status code.
|
|
*
|
|
* @since 1.28
|
|
* @ingroup Exception
|
|
*/
|
|
class BadRequestError extends ErrorPageError {
|
|
|
|
public function report( $action = self::SEND_OUTPUT ) {
|
|
global $wgOut;
|
|
$wgOut->setStatusCode( 400 );
|
|
parent::report( $action );
|
|
}
|
|
}
|