I'm not sure what the benefit was of having this service being injectible via the constructor. I mean, I wish *all* services would be injected. But there are more services used in this class, and no other is injected. Also it seems the only test that was ever setting the ParserCache service to something else was not even using it: As far as I can see the test case testJobSpecRemovesDuplicates() is not triggering the code that uses the ParserCache service. Change-Id: I65f5c654d36ffecfd914e97cd8069eb99f76c5c6 |
||
|---|---|---|
| .. | ||
| jobs | ||
| JobQueueMemoryTest.php | ||
| JobQueueTest.php | ||
| JobRunnerTest.php | ||
| JobTest.php | ||
| RefreshLinksPartitionTest.php | ||