13c1839735
Parser is using the service container to get a SignatureValidator because, as noted in Gerrit comments on the relevant commit, there is a circular dependency Parser -> SignatureValidatorFactory -> Parser. So, have SignatureValidatorFactory::__construct() take a closure which returns a Parser, instead of an actual Parser or ParserFactory. Change-Id: I7bf4660f84ec8c8fb1d5b3b8581fe5d82bc3156e
101 lines
3.2 KiB
PHP
101 lines
3.2 KiB
PHP
<?php
|
|
|
|
use MediaWiki\BadFileLookup;
|
|
use MediaWiki\Config\ServiceOptions;
|
|
use MediaWiki\Http\HttpRequestFactory;
|
|
use MediaWiki\Languages\LanguageConverterFactory;
|
|
use MediaWiki\Linker\LinkRendererFactory;
|
|
use MediaWiki\Preferences\SignatureValidatorFactory;
|
|
use MediaWiki\SpecialPage\SpecialPageFactory;
|
|
use MediaWiki\Tidy\TidyDriverBase;
|
|
use MediaWiki\User\UserFactory;
|
|
use MediaWiki\User\UserOptionsLookup;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @covers ParserFactory
|
|
*/
|
|
class ParserFactoryTest extends MediaWikiUnitTestCase {
|
|
private function createFactory() {
|
|
$options = new ServiceOptions(
|
|
Parser::CONSTRUCTOR_OPTIONS,
|
|
array_combine(
|
|
Parser::CONSTRUCTOR_OPTIONS,
|
|
array_fill( 0, count( Parser::CONSTRUCTOR_OPTIONS ), null )
|
|
)
|
|
);
|
|
|
|
// Stub out a MagicWordFactory so the Parser can initialize its
|
|
// function hooks when it is created.
|
|
$mwFactory = $this->getMockBuilder( MagicWordFactory::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'get', 'getVariableIDs' ] )
|
|
->getMock();
|
|
$mwFactory
|
|
->method( 'get' )->will( $this->returnCallback( function ( $arg ) {
|
|
$mw = $this->getMockBuilder( MagicWord::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'getSynonyms' ] )
|
|
->getMock();
|
|
$mw->method( 'getSynonyms' )->willReturn( [] );
|
|
return $mw;
|
|
} ) );
|
|
$mwFactory
|
|
->method( 'getVariableIDs' )->willReturn( [] );
|
|
|
|
$languageConverterFactory = $this->getMockBuilder( LanguageConverterFactory::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$factory = new ParserFactory(
|
|
$options,
|
|
$mwFactory,
|
|
$this->createNoOpMock( Language::class ),
|
|
"",
|
|
$this->createNoOpMock( SpecialPageFactory::class ),
|
|
$this->createNoOpMock( LinkRendererFactory::class ),
|
|
$this->createNoOpMock( NamespaceInfo::class ),
|
|
new TestLogger(),
|
|
$this->createNoOpMock( BadFileLookup::class ),
|
|
$languageConverterFactory,
|
|
$this->createHookContainer(),
|
|
$this->createNoOpMock( TidyDriverBase::class ),
|
|
$this->createNoOpMock( WANObjectCache::class ),
|
|
$this->createNoOpMock( UserOptionsLookup::class ),
|
|
$this->createNoOpMock( UserFactory::class ),
|
|
$this->createNoOpMock( TitleFormatter::class ),
|
|
$this->createNoOpMock( HttpRequestFactory::class ),
|
|
$this->createNoOpMock( TrackingCategories::class ),
|
|
$this->createNoOpMock( SignatureValidatorFactory::class )
|
|
);
|
|
return $factory;
|
|
}
|
|
|
|
/**
|
|
* @covers ParserFactory::__construct
|
|
*/
|
|
public function testConstructor() {
|
|
$factory = $this->createFactory();
|
|
$this->assertNotNull( $factory, "Factory should be created correctly" );
|
|
}
|
|
|
|
/**
|
|
* @covers ParserFactory::create
|
|
*/
|
|
public function testCreate() {
|
|
$factory = $this->createFactory();
|
|
$parser = $factory->create();
|
|
$this->assertNotNull( $factory, "Factory should be created correctly" );
|
|
$this->assertNotNull( $parser, "Factory should create parser correctly" );
|
|
$this->assertInstanceOf( Parser::class, $parser );
|
|
|
|
$parserWrapper = TestingAccessWrapper::newFromObject( $parser );
|
|
$factoryWrapper = TestingAccessWrapper::newFromObject( $factory );
|
|
$this->assertSame(
|
|
$factoryWrapper->languageConverterFactory, $parserWrapper->languageConverterFactory
|
|
);
|
|
$this->assertSame(
|
|
$factory, $parserWrapper->factory
|
|
);
|
|
}
|
|
}
|