1c60cafab4
With PHPUnit 9, tests without @covers tags are considered risky and emit warnings. Not having @covers is bad practice anyway, so use @coversNothing instead to make the intention clear, and re-enable the phpcs rule. Also rewrite an assertion in ResourcesTest that was bothering me. Bug: T243600 Change-Id: I6dd683f93b6b2faed5f107be2ca7860602277fbc
105 lines
2.8 KiB
PHP
105 lines
2.8 KiB
PHP
<?php
|
|
|
|
use MediaWiki\MediaWikiServices;
|
|
|
|
/**
|
|
* Try to make sure that extensions register all rights in $wgAvailableRights
|
|
* or via the 'UserGetAllRights' hook.
|
|
*
|
|
* @author Marius Hoch < hoo@online.de >
|
|
* @coversNothing
|
|
*/
|
|
class AvailableRightsTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
/**
|
|
* Returns all rights that should be in $wgAvailableRights + all rights
|
|
* registered via the 'UserGetAllRights' hook + all "core" rights.
|
|
*
|
|
* @return string[]
|
|
*/
|
|
private function getAllVisibleRights() {
|
|
global $wgGroupPermissions, $wgRevokePermissions;
|
|
|
|
$rights = MediaWikiServices::getInstance()->getPermissionManager()->getAllPermissions();
|
|
|
|
foreach ( $wgGroupPermissions as $permissions ) {
|
|
$rights = array_merge( $rights, array_keys( $permissions ) );
|
|
}
|
|
|
|
foreach ( $wgRevokePermissions as $permissions ) {
|
|
$rights = array_merge( $rights, array_keys( $permissions ) );
|
|
}
|
|
|
|
$rights = array_unique( $rights );
|
|
sort( $rights );
|
|
|
|
return $rights;
|
|
}
|
|
|
|
public function testAvailableRights() {
|
|
$missingRights = array_diff(
|
|
$this->getAllVisibleRights(),
|
|
MediaWikiServices::getInstance()->getPermissionManager()->getAllPermissions()
|
|
);
|
|
|
|
$this->assertEquals(
|
|
[],
|
|
// Re-index to produce nicer output, keys are meaningless.
|
|
array_values( $missingRights ),
|
|
'Additional user rights need to be added to $wgAvailableRights or ' .
|
|
'via the "UserGetAllRights" hook. See the instructions at: ' .
|
|
'https://www.mediawiki.org/wiki/Manual:User_rights#Adding_new_rights'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test, if for all rights an action- message exist,
|
|
* which is used on Special:ListGroupRights as help text
|
|
* Extensions and core
|
|
*
|
|
* @coversNothing
|
|
*/
|
|
public function testAllActionsWithMessages() {
|
|
$this->checkMessagesExist( 'action-' );
|
|
}
|
|
|
|
/**
|
|
* Test, if for all rights a right- message exist,
|
|
* which is used on Special:ListGroupRights as help text
|
|
* Extensions and core
|
|
*/
|
|
public function testAllRightsWithMessage() {
|
|
$this->checkMessagesExist( 'right-' );
|
|
}
|
|
|
|
/**
|
|
* @param string $prefix
|
|
*/
|
|
private function checkMessagesExist( $prefix ) {
|
|
// Getting all user rights, for core: User::$mCoreRights, for extensions: $wgAvailableRights
|
|
$services = MediaWikiServices::getInstance();
|
|
$allRights = $services->getPermissionManager()->getAllPermissions();
|
|
$allMessageKeys = $services->getLocalisationCache()->getSubitemList( 'en', 'messages' );
|
|
|
|
$messagesToCheck = [];
|
|
foreach ( $allMessageKeys as $message ) {
|
|
// === 0: must be at beginning of string (position 0)
|
|
if ( strpos( $message, $prefix ) === 0 ) {
|
|
$messagesToCheck[] = substr( $message, strlen( $prefix ) );
|
|
}
|
|
}
|
|
|
|
$missing = array_diff(
|
|
$allRights,
|
|
$messagesToCheck
|
|
);
|
|
|
|
$this->assertEquals(
|
|
[],
|
|
$missing,
|
|
"Each user right (core/extensions) has a corresponding $prefix message."
|
|
);
|
|
}
|
|
}
|