wiki.techinc.nl/tests/phpunit/unit/includes/editpage/Constraint/AutoSummaryMissingSummaryConstraintTest.php
Thiemo Kreuz c1ee8250e9 Remove unnecessary ->equalTo() from tests
This is the default anyway when using ->with(). The test code
becomes so much more readable without this, I would like to
argue. Let it just say "with these values".

Because of the way I split my changes into multiple patches
there are a few other changes in this patch I could not split,
e.g. removing unnecessary ->any(). This is the default anyway
and doesn't make the test more specific.

Change-Id: I34990799fa9258ba8dc64c7e78ec43f7903b7681
2021-04-23 12:02:42 +02:00

74 lines
2.3 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
use MediaWiki\EditPage\Constraint\AutoSummaryMissingSummaryConstraint;
use MediaWiki\EditPage\Constraint\IEditConstraint;
/**
* Tests the AutoSummaryMissingSummaryConstraint
*
* @author DannyS712
*
* @covers \MediaWiki\EditPage\Constraint\AutoSummaryMissingSummaryConstraint
*/
class AutoSummaryMissingSummaryConstraintTest extends MediaWikiUnitTestCase {
use EditConstraintTestTrait;
public function testPass() {
$originalContent = $this->createMock( Content::class );
$newContent = $this->createMock( Content::class );
$newContent->expects( $this->once() )
->method( 'equals' )
->with( $originalContent )
->willReturn( false );
$newContent->expects( $this->once() )
->method( 'isRedirect' )
->willReturn( false );
$constraint = new AutoSummaryMissingSummaryConstraint(
'UserSummary',
'AutoSummary',
false,
$newContent,
$originalContent
);
$this->assertConstraintPassed( $constraint );
}
public function testFailure() {
$originalContent = $this->createMock( Content::class );
$newContent = $this->createMock( Content::class );
$newContent->expects( $this->once() )
->method( 'equals' )
->with( $originalContent )
->willReturn( false );
$newContent->expects( $this->once() )
->method( 'isRedirect' )
->willReturn( false );
$constraint = new AutoSummaryMissingSummaryConstraint(
'UserSummary',
md5( 'UserSummary' ),
false,
$newContent,
$originalContent
);
$this->assertConstraintFailed( $constraint, IEditConstraint::AS_SUMMARY_NEEDED );
}
}