c1ee8250e9
This is the default anyway when using ->with(). The test code becomes so much more readable without this, I would like to argue. Let it just say "with these values". Because of the way I split my changes into multiple patches there are a few other changes in this patch I could not split, e.g. removing unnecessary ->any(). This is the default anyway and doesn't make the test more specific. Change-Id: I34990799fa9258ba8dc64c7e78ec43f7903b7681
132 lines
3.8 KiB
PHP
132 lines
3.8 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\EditPage\Constraint\ContentModelChangeConstraint;
|
|
use MediaWiki\EditPage\Constraint\IEditConstraint;
|
|
use MediaWiki\Page\PageIdentity;
|
|
use MediaWiki\Tests\Unit\Permissions\MockAuthorityTrait;
|
|
|
|
/**
|
|
* Tests the ContentModelChangeConstraint
|
|
*
|
|
* @author DannyS712
|
|
*
|
|
* @covers \MediaWiki\EditPage\Constraint\ContentModelChangeConstraint
|
|
*/
|
|
class ContentModelChangeConstraintTest extends MediaWikiUnitTestCase {
|
|
use EditConstraintTestTrait;
|
|
use MockAuthorityTrait;
|
|
use MockTitleTrait;
|
|
|
|
public function testPass() {
|
|
$newContentModel = 'FooBarBaz';
|
|
|
|
$title = $this->getMockBuilder( Title::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'getContentModel', 'setContentModel' ] )
|
|
->getMock();
|
|
$title->expects( $this->once() )
|
|
->method( 'getContentModel' )
|
|
->willReturn( 'differentStartingContentModel' );
|
|
$title->expects( $this->once() )
|
|
->method( 'setContentModel' )
|
|
->with( $newContentModel );
|
|
|
|
$performer = $this->mockRegisteredAuthorityWithPermissions( [ 'edit', 'editcontentmodel' ] );
|
|
$constraint = new ContentModelChangeConstraint(
|
|
$performer,
|
|
$title,
|
|
$newContentModel
|
|
);
|
|
$this->assertConstraintPassed( $constraint );
|
|
}
|
|
|
|
public function testNoChange() {
|
|
$unchangingContentModel = 'FooBarBaz';
|
|
$title = $this->makeMockTitle( __METHOD__, [
|
|
'contentModel' => $unchangingContentModel,
|
|
] );
|
|
$constraint = new ContentModelChangeConstraint(
|
|
$this->mockRegisteredUltimateAuthority(),
|
|
$title,
|
|
$unchangingContentModel
|
|
);
|
|
$this->assertConstraintPassed( $constraint );
|
|
}
|
|
|
|
public function testFailure() {
|
|
$newContentModel = 'FooBarBaz';
|
|
|
|
$title = $this->getMockBuilder( Title::class )
|
|
->disableOriginalConstructor()
|
|
->onlyMethods( [ 'getContentModel', 'setContentModel' ] )
|
|
->getMock();
|
|
$title->expects( $this->once() )
|
|
->method( 'getContentModel' )
|
|
->willReturn( 'differentStartingContentModel' );
|
|
$title->expects( $this->once() )
|
|
->method( 'setContentModel' )
|
|
->with( $newContentModel );
|
|
|
|
$performer = $this->mockRegisteredAuthority( function (
|
|
string $permission,
|
|
PageIdentity $page = null
|
|
) use ( $title ) {
|
|
if ( $permission === 'editcontentmodel' ) {
|
|
if ( $page ) {
|
|
$this->assertEquals( $title, $page );
|
|
}
|
|
return true;
|
|
}
|
|
if ( $permission === 'edit' ) {
|
|
$this->assertEquals( $title, $page );
|
|
return false;
|
|
}
|
|
$this->fail( "Unexpected permission check $permission" );
|
|
return false;
|
|
} );
|
|
|
|
$constraint = new ContentModelChangeConstraint(
|
|
$performer,
|
|
$title,
|
|
$newContentModel
|
|
);
|
|
$this->assertConstraintFailed(
|
|
$constraint,
|
|
IEditConstraint::AS_NO_CHANGE_CONTENT_MODEL
|
|
);
|
|
}
|
|
|
|
public function testFailure_quick() {
|
|
$title = $this->makeMockTitle( __METHOD__, [
|
|
'contentModel' => 'differentStartingContentModel',
|
|
] );
|
|
|
|
$constraint = new ContentModelChangeConstraint(
|
|
$this->mockRegisteredAuthorityWithoutPermissions( [ 'editcontentmodel' ] ),
|
|
$title,
|
|
'FooBarBaz'
|
|
);
|
|
$this->assertConstraintFailed(
|
|
$constraint,
|
|
IEditConstraint::AS_NO_CHANGE_CONTENT_MODEL
|
|
);
|
|
}
|
|
}
|