990fd8f0b2
Previously, `$this->summary` was used for two different purposes. Usually it was just the summary. But when `$this->section` was 'new', then it was actually the section title most of the time – unless `$this->sectiontitle` was also set (in which case it took priority), and until it was replaced by the real edit summary (near the end of the processing, after copying the section title to the page content and before saving changes). Unsurprisingly some of the code didn't handle this duality correctly, causing T191722 and T311533. Now `$this->summary` is always the summary, and when `$this->section` is 'new', then `$this->sectiontitle` is always the new section title. The only place where this duality remains is in the input attributes and query parameters, where 'wpSummary' is still used for both the summary and the section title inputs (only one of them can appear, depending on whether `$this->section` is 'new'). It would be an unreasonable backwards-compatibility break to change this, and the code handling this is somewhat isolated from the rest of the logic. Bug: T191722 Bug: T311533 Change-Id: I5313ca9a045d112ece390b011a34192220e2abc1
118 lines
3 KiB
PHP
118 lines
3 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\EditPage\Constraint\IEditConstraint;
|
|
use MediaWiki\EditPage\Constraint\SpamRegexConstraint;
|
|
use MediaWiki\EditPage\SpamChecker;
|
|
use Psr\Log\LogLevel;
|
|
use Psr\Log\NullLogger;
|
|
|
|
/**
|
|
* Tests the SpamRegexContraint
|
|
*
|
|
* @author DannyS712
|
|
*
|
|
* @covers \MediaWiki\EditPage\Constraint\SpamRegexConstraint
|
|
*/
|
|
class SpamRegexConstraintTest extends MediaWikiUnitTestCase {
|
|
use EditConstraintTestTrait;
|
|
|
|
public function testPass() {
|
|
$summary = __METHOD__ . '-summary';
|
|
$sectionHeading = __METHOD__ . '-section-heading';
|
|
$text = __METHOD__ . '-text';
|
|
|
|
$spamChecker = $this->createMock( SpamChecker::class );
|
|
$spamChecker->expects( $this->once() )
|
|
->method( 'checkSummary' )
|
|
->with( $summary )
|
|
->willReturn( false );
|
|
$spamChecker->expects( $this->exactly( 2 ) )
|
|
->method( 'checkContent' )
|
|
->withConsecutive(
|
|
[ $sectionHeading ],
|
|
[ $text ]
|
|
)
|
|
->willReturn( false );
|
|
|
|
$title = $this->createMock( Title::class );
|
|
$title->expects( $this->never() )
|
|
->method( 'getPrefixedDBkey' );
|
|
|
|
$logger = new NullLogger();
|
|
|
|
$constraint = new SpamRegexConstraint(
|
|
$logger,
|
|
$spamChecker,
|
|
$summary,
|
|
$sectionHeading,
|
|
$text,
|
|
'Request-IP',
|
|
$title
|
|
);
|
|
$this->assertConstraintPassed( $constraint );
|
|
}
|
|
|
|
public function testFailure() {
|
|
$summary = __METHOD__ . '-summary';
|
|
$sectionHeading = __METHOD__ . '-section-heading';
|
|
$text = __METHOD__ . '-text';
|
|
$matchingText = __METHOD__ . '-match';
|
|
|
|
$spamChecker = $this->createMock( SpamChecker::class );
|
|
$spamChecker->expects( $this->once() )
|
|
->method( 'checkSummary' )
|
|
->with( $summary )
|
|
->willReturn( $matchingText );
|
|
|
|
$prefixedDBKey = 'PrefixedDBKeyGoesHere';
|
|
$title = $this->createMock( Title::class );
|
|
$title->expects( $this->once() )
|
|
->method( 'getPrefixedDBkey' )
|
|
->willReturn( $prefixedDBKey );
|
|
|
|
$logger = new TestLogger( true );
|
|
|
|
$constraint = new SpamRegexConstraint(
|
|
$logger,
|
|
$spamChecker,
|
|
$summary,
|
|
$sectionHeading,
|
|
$text,
|
|
'Request-IP',
|
|
$title
|
|
);
|
|
$this->assertConstraintFailed( $constraint, IEditConstraint::AS_SPAM_ERROR );
|
|
|
|
$this->assertSame( [
|
|
[
|
|
LogLevel::DEBUG,
|
|
'{ip} spam regex hit [[{title}]]: "{match}"'
|
|
],
|
|
], $logger->getBuffer() );
|
|
$logger->clearBuffer();
|
|
|
|
$this->assertSame(
|
|
$matchingText,
|
|
$constraint->getMatch()
|
|
);
|
|
}
|
|
|
|
}
|