61ae7504df
createMock() does the same, but is much easier to read. A small difference is that some of the replacements made in this patch didn't use disableOriginalConstructor() before. In case this was relevant we should see the respective test fail. If not we can save some CPU cycles and skip these constructors. Change-Id: Ib98fb06e0fe753b7a53cb087a47e1159515a8ad5
77 lines
2.1 KiB
PHP
77 lines
2.1 KiB
PHP
<?php
|
|
|
|
use Liuggio\StatsdClient\Entity\StatsdData;
|
|
use Liuggio\StatsdClient\Sender\SenderInterface;
|
|
|
|
/**
|
|
* @covers SamplingStatsdClient
|
|
*/
|
|
class SamplingStatsdClientTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
/**
|
|
* @dataProvider samplingDataProvider
|
|
*/
|
|
public function testSampling( $data, $sampleRate, $seed, $expectWrite ) {
|
|
$sender = $this->createMock( SenderInterface::class );
|
|
$sender->method( 'open' )->willReturn( true );
|
|
if ( $expectWrite ) {
|
|
$sender->expects( $this->once() )->method( 'write' )
|
|
->with( $this->anything(), $data );
|
|
} else {
|
|
$sender->expects( $this->never() )->method( 'write' );
|
|
}
|
|
if ( defined( 'MT_RAND_PHP' ) ) {
|
|
mt_srand( $seed, MT_RAND_PHP );
|
|
} else {
|
|
mt_srand( $seed );
|
|
}
|
|
$client = new SamplingStatsdClient( $sender );
|
|
$client->send( $data, $sampleRate );
|
|
}
|
|
|
|
public function samplingDataProvider() {
|
|
$unsampled = new StatsdData();
|
|
$unsampled->setKey( 'foo' );
|
|
$unsampled->setValue( 1 );
|
|
|
|
$sampled = new StatsdData();
|
|
$sampled->setKey( 'foo' );
|
|
$sampled->setValue( 1 );
|
|
$sampled->setSampleRate( '0.1' );
|
|
|
|
return [
|
|
// $data, $sampleRate, $seed, $expectWrite
|
|
[ $unsampled, 1, 0 /*0.44*/, true ],
|
|
[ $sampled, 1, 0 /*0.44*/, false ],
|
|
[ $sampled, 1, 4 /*0.03*/, true ],
|
|
[ $unsampled, 0.1, 0 /*0.44*/, false ],
|
|
[ $sampled, 0.5, 0 /*0.44*/, false ],
|
|
[ $sampled, 0.5, 4 /*0.03*/, false ],
|
|
];
|
|
}
|
|
|
|
public function testSetSamplingRates() {
|
|
$matching = new StatsdData();
|
|
$matching->setKey( 'foo.bar' );
|
|
$matching->setValue( 1 );
|
|
|
|
$nonMatching = new StatsdData();
|
|
$nonMatching->setKey( 'oof.bar' );
|
|
$nonMatching->setValue( 1 );
|
|
|
|
$sender = $this->createMock( SenderInterface::class );
|
|
$sender->method( 'open' )->willReturn( true );
|
|
$sender->expects( $this->once() )->method( 'write' )
|
|
->with( $this->anything(), $nonMatching );
|
|
|
|
$client = new SamplingStatsdClient( $sender );
|
|
$client->setSamplingRates( [ 'foo.*' => 0.2 ] );
|
|
|
|
mt_srand( 0 ); // next random is 0.44
|
|
$client->send( $matching );
|
|
mt_srand( 0 );
|
|
$client->send( $nonMatching );
|
|
}
|
|
}
|