68ec2661d2
It's just a nice, lesser known convenience function. Exists since PHP 5.5. The changes to SerializationTestTrait ended being a little different. Original I tried to use array_column() as well. But it drops the array keys, which is relevant here. We found that calling the two methods getTestInstances(AndAssertions) multiple times is quite expensive and should be avoided. I changed the code slightly so it's much less likely this is done unintentionally. Change-Id: Ifaba3c370871a7c97b4d81ec21ff6ec134433fc0
111 lines
3.1 KiB
PHP
111 lines
3.1 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @author Ori Livneh <ori@wikimedia.org>
|
|
*/
|
|
|
|
class TimingTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
/**
|
|
* @covers Timing::clearMarks
|
|
* @covers Timing::getEntries
|
|
*/
|
|
public function testClearMarks() {
|
|
$timing = new Timing;
|
|
$this->assertCount( 1, $timing->getEntries() );
|
|
|
|
$timing->mark( 'a' );
|
|
$timing->mark( 'b' );
|
|
$this->assertCount( 3, $timing->getEntries() );
|
|
|
|
$timing->clearMarks( 'a' );
|
|
$this->assertNull( $timing->getEntryByName( 'a' ) );
|
|
$this->assertNotNull( $timing->getEntryByName( 'b' ) );
|
|
|
|
$timing->clearMarks();
|
|
$this->assertCount( 1, $timing->getEntries() );
|
|
}
|
|
|
|
/**
|
|
* @covers Timing::mark
|
|
* @covers Timing::getEntryByName
|
|
*/
|
|
public function testMark() {
|
|
$timing = new Timing;
|
|
$timing->mark( 'a' );
|
|
|
|
$entry = $timing->getEntryByName( 'a' );
|
|
$this->assertEquals( 'a', $entry['name'] );
|
|
$this->assertEquals( 'mark', $entry['entryType'] );
|
|
$this->assertArrayHasKey( 'startTime', $entry );
|
|
$this->assertSame( 0, $entry['duration'] );
|
|
|
|
usleep( 100 );
|
|
$timing->mark( 'a' );
|
|
$newEntry = $timing->getEntryByName( 'a' );
|
|
$this->assertGreaterThan( $entry['startTime'], $newEntry['startTime'] );
|
|
}
|
|
|
|
/**
|
|
* @covers Timing::measure
|
|
*/
|
|
public function testMeasure() {
|
|
$timing = new Timing;
|
|
|
|
$timing->mark( 'a' );
|
|
usleep( 100 );
|
|
$timing->mark( 'b' );
|
|
|
|
$a = $timing->getEntryByName( 'a' );
|
|
$b = $timing->getEntryByName( 'b' );
|
|
|
|
$timing->measure( 'a_to_b', 'a', 'b' );
|
|
|
|
$entry = $timing->getEntryByName( 'a_to_b' );
|
|
$this->assertEquals( 'a_to_b', $entry['name'] );
|
|
$this->assertEquals( 'measure', $entry['entryType'] );
|
|
$this->assertEquals( $a['startTime'], $entry['startTime'] );
|
|
$this->assertEquals( $b['startTime'] - $a['startTime'], $entry['duration'] );
|
|
}
|
|
|
|
/**
|
|
* @covers Timing::getEntriesByType
|
|
*/
|
|
public function testGetEntriesByType() {
|
|
$timing = new Timing;
|
|
|
|
$timing->mark( 'mark_a' );
|
|
usleep( 100 );
|
|
$timing->mark( 'mark_b' );
|
|
usleep( 100 );
|
|
$timing->mark( 'mark_c' );
|
|
|
|
$timing->measure( 'measure_a', 'mark_a', 'mark_b' );
|
|
$timing->measure( 'measure_b', 'mark_b', 'mark_c' );
|
|
|
|
$marks = array_column( $timing->getEntriesByType( 'mark' ), 'name' );
|
|
|
|
$this->assertEquals( [ 'requestStart', 'mark_a', 'mark_b', 'mark_c' ], $marks );
|
|
|
|
$measures = array_column( $timing->getEntriesByType( 'measure' ), 'name' );
|
|
|
|
$this->assertEquals( [ 'measure_a', 'measure_b' ], $measures );
|
|
}
|
|
}
|