wiki.techinc.nl/tests/phpunit/unit/includes/libs/objectcache/HashBagOStuffTest.php
daniel df9a729e57 BagOStuff: never use the full cache key as metrics key
When the cache key doesn't contain a prefix indentifying the collection,
don't use the entire cache key as the metrics name. Doing so may explode
the number of metrics.

Bug: T323357
Change-Id: Ia7ff3f060a36f848c7a74e39070bd62a932120e7
2022-11-21 14:03:44 +01:00

229 lines
5.7 KiB
PHP

<?php
use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
use Wikimedia\TestingAccessWrapper;
/**
* @group BagOStuff
*/
class HashBagOStuffTest extends PHPUnit\Framework\TestCase {
use MediaWikiCoversValidator;
/**
* @covers HashBagOStuff::__construct
*/
public function testConstruct() {
$this->assertInstanceOf(
HashBagOStuff::class,
new HashBagOStuff()
);
}
/**
* @covers HashBagOStuff::__construct
*/
public function testQoS() {
$bag = new HashBagOStuff();
$this->assertSame(
BagOStuff::QOS_DURABILITY_SCRIPT,
$bag->getQoS( BagOStuff::ATTR_DURABILITY )
);
}
/**
* @covers HashBagOStuff::__construct
*/
public function testConstructBadZero() {
$this->expectException( InvalidArgumentException::class );
$cache = new HashBagOStuff( [ 'maxKeys' => 0 ] );
}
/**
* @covers HashBagOStuff::__construct
*/
public function testConstructBadNeg() {
$this->expectException( InvalidArgumentException::class );
$cache = new HashBagOStuff( [ 'maxKeys' => -1 ] );
}
/**
* @covers HashBagOStuff::__construct
*/
public function testConstructBadType() {
$this->expectException( InvalidArgumentException::class );
$cache = new HashBagOStuff( [ 'maxKeys' => 'x' ] );
}
/**
* @covers HashBagOStuff::delete
*/
public function testDelete() {
$cache = new HashBagOStuff();
for ( $i = 0; $i < 10; $i++ ) {
$cache->set( "key$i", 1 );
$this->assertSame( 1, $cache->get( "key$i" ) );
$cache->delete( "key$i" );
$this->assertFalse( $cache->get( "key$i" ) );
}
}
/**
* @covers HashBagOStuff::clear
*/
public function testClear() {
$cache = new HashBagOStuff();
for ( $i = 0; $i < 10; $i++ ) {
$cache->set( "key$i", 1 );
$this->assertSame( 1, $cache->get( "key$i" ) );
}
$cache->clear();
for ( $i = 0; $i < 10; $i++ ) {
$this->assertFalse( $cache->get( "key$i" ) );
}
}
/**
* @covers HashBagOStuff::doGet
* @covers HashBagOStuff::expire
*/
public function testExpire() {
$cache = new HashBagOStuff();
$cacheInternal = TestingAccessWrapper::newFromObject( $cache );
$cache->set( 'foo', 1 );
$cache->set( 'bar', 1, 10 );
$cache->set( 'baz', 1, -10 );
$this->assertSame( 0, $cacheInternal->bag['foo'][$cache::KEY_EXP], 'Indefinite' );
// 2 seconds tolerance
$this->assertEqualsWithDelta(
time() + 10,
$cacheInternal->bag['bar'][$cache::KEY_EXP],
2,
'Future'
);
$this->assertEqualsWithDelta(
time() - 10,
$cacheInternal->bag['baz'][$cache::KEY_EXP],
2,
'Past'
);
$this->assertSame( 1, $cache->get( 'bar' ), 'Key not expired' );
$this->assertFalse( $cache->get( 'baz' ), 'Key expired' );
}
/**
* Ensure maxKeys eviction prefers keeping new keys.
*
* @covers HashBagOStuff::set
*/
public function testEvictionAdd() {
$cache = new HashBagOStuff( [ 'maxKeys' => 10 ] );
for ( $i = 0; $i < 10; $i++ ) {
$cache->set( "key$i", 1 );
$this->assertSame( 1, $cache->get( "key$i" ) );
}
for ( $i = 10; $i < 20; $i++ ) {
$cache->set( "key$i", 1 );
$this->assertSame( 1, $cache->get( "key$i" ) );
$this->assertFalse( $cache->get( "key" . ( $i - 10 ) ) );
}
}
/**
* Ensure maxKeys eviction prefers recently set keys
* even if the keys pre-exist.
*
* @covers HashBagOStuff::set
*/
public function testEvictionSet() {
$cache = new HashBagOStuff( [ 'maxKeys' => 3 ] );
foreach ( [ 'foo', 'bar', 'baz' ] as $key ) {
$cache->set( $key, 1 );
}
// Set existing key
$cache->set( 'foo', 1 );
// Add a 4th key (beyond the allowed maximum)
$cache->set( 'quux', 1 );
// Foo's life should have been extended over Bar
foreach ( [ 'foo', 'baz', 'quux' ] as $key ) {
$this->assertSame( 1, $cache->get( $key ), "Kept $key" );
}
$this->assertFalse( $cache->get( 'bar' ), 'Evicted bar' );
}
/**
* Ensure maxKeys eviction prefers recently retrieved keys (LRU).
*
* @covers HashBagOStuff::doGet
* @covers HashBagOStuff::hasKey
*/
public function testEvictionGet() {
$cache = new HashBagOStuff( [ 'maxKeys' => 3 ] );
foreach ( [ 'foo', 'bar', 'baz' ] as $key ) {
$cache->set( $key, 1 );
}
// Get existing key
$cache->get( 'foo', 1 );
// Add a 4th key (beyond the allowed maximum)
$cache->set( 'quux', 1 );
// Foo's life should have been extended over Bar
foreach ( [ 'foo', 'baz', 'quux' ] as $key ) {
$this->assertSame( 1, $cache->get( $key ), "Kept $key" );
}
$this->assertFalse( $cache->get( 'bar' ), 'Evicted bar' );
}
/**
* Ensure updateOpStats doesn't get confused.
*
* @covers MediumSpecificBagOStuff::updateOpStats
*/
public function testUpdateOpStats() {
$counts = [];
$stats = $this->createMock( StatsdDataFactoryInterface::class );
$stats->method( 'updateCount' )->willReturnCallback(
static function ( $name, $delta ) use ( &$counts ) {
$counts[$name] = ( $counts[$name] ?? 0 ) + $delta;
}
);
$cache = new HashBagOStuff( [
'stats' => $stats
] );
$cache = TestingAccessWrapper::newFromObject( $cache );
$cache->updateOpStats(
'frob',
[
// The value is the key
$cache->makeKey( 'Foo', '123456' ),
// The value is a tuble of ( bytes sent, bytes received )
$cache->makeGlobalKey( 'Bar', '123456' ) => [ 5, 3 ],
// The key is not a proper key
'1337BABE-123456' => [ 5, 3 ],
]
);
$this->assertSame( 1, $counts['objectcache.Foo.frob_call_rate'] );
$this->assertSame( 1, $counts['objectcache.Bar.frob_call_rate'] );
$this->assertSame( 1, $counts['objectcache.UNKNOWN.frob_call_rate'] );
$this->assertSame( 3, $counts['objectcache.Bar.frob_bytes_read'] );
$this->assertSame( 5, $counts['objectcache.Bar.frob_bytes_sent'] );
$this->assertSame( 3, $counts['objectcache.UNKNOWN.frob_bytes_read'] );
$this->assertSame( 5, $counts['objectcache.UNKNOWN.frob_bytes_sent'] );
}
}