Brad Jorsch 74ff87d291 Block: Clean up handling of non-User targets ... The fix applied in d67121f6d took care of the immediate issue in T208398, but after further analysis it was not a correct fix. * Near line 770, the method shouldn't even be called unless the target is TYPE_USER. * Near line 1598, it isn't dealing with a target at all. * Near line 1813, you're not going to get a sensible result trying to call `$user->getTalkPage()` for a range or auto-block ID. What you would really need there to handle range and auto-blocks correctly is to pass in the User actually making the edit. But after some pushback in code review about passing the User into Block::preventsEdit() to make line 1813 work, we'll instead replace the method with Block::appliesToTitle() and put the check for user talk pages back into User::isBlockedFrom(). Bug: T208398 Bug: T208472 Change-Id: I23d3a3a1925e97f0cabe328c1cc74e978cb4d24a		2018-11-02 12:33:57 -04:00
..
BotPasswordTest.php	Improve ApiLogin test coverage	2018-10-10 11:11:43 +03:00
CentralIdLookupTest.php	Use ::class to resolve class names in tests	2018-01-26 22:49:13 +01:00
ExternalUserNamesTest.php	Add ExternalUserNames::getLocal() to get local part of username	2018-03-09 20:53:54 +01:00
LocalIdLookupTest.php	Deprecate MediaWikiTestCase::stashMwGlobals	2018-10-07 19:39:47 +03:00
PasswordResetTest.php	Convert PasswordReset to using MapCacheLRU	2018-07-14 01:31:54 +00:00
UserArrayFromResultTest.php	Use ::class to resolve class names in tests	2018-01-26 22:49:13 +01:00
UserGroupMembershipTest.php	Add actor table and code to start using it	2018-02-23 10:06:20 -08:00
UserTest.php	Block: Clean up handling of non-User targets	2018-11-02 12:33:57 -04:00