4268915645
Follows-up 6e2be46e82 (Idaa8552cf37), which allowed canonical
action=raw URLs to be long-cached by the CDN and have them be
purged on-edit alongside the view and history URLs.
In reviewing that, I mistook isJsSubpage() as checking both
NS_USER and NS_MEDIAWIKI js pages. This method name was renamed
to isUserJsConfigPage() which made the omission more obvious.
Bug: T261371
Change-Id: Ic22b5f39ce4e1a9f074833f9e4e626e3999465dd
64 lines
2 KiB
PHP
64 lines
2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group Cache
|
|
* @covers HtmlCacheUpdater
|
|
*/
|
|
class HtmlCacheUpdaterTest extends MediaWikiUnitTestCase {
|
|
|
|
public function testGetCdnUrls() {
|
|
$htmlCache = new HtmlCacheUpdater(
|
|
$this->createHookContainer(),
|
|
0, false, 86400 );
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'getInternalURL' )->will( $this->returnCallback( function ( $query = '' ) {
|
|
return 'https://test/?title=Example' . ( $query !== '' ? "&$query" : '' );
|
|
} ) );
|
|
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=Example',
|
|
'https://test/?title=Example&action=history',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for an article'
|
|
);
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=Example',
|
|
],
|
|
$htmlCache->getUrls( $title, $htmlCache::PURGE_URLS_LINKSUPDATE_ONLY ),
|
|
'linkupdate urls for an article'
|
|
);
|
|
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'getInternalURL' )->will( $this->returnCallback( function ( $query = '' ) {
|
|
return 'https://test/?title=User:Example/foo.js' . ( $query !== '' ? "&$query" : '' );
|
|
} ) );
|
|
$title->method( 'isUserJsConfigPage' )->willReturn( true );
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=User:Example/foo.js',
|
|
'https://test/?title=User:Example/foo.js&action=history',
|
|
'https://test/?title=User:Example/foo.js&action=raw&ctype=text/javascript',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for a user js page'
|
|
);
|
|
|
|
$title = $this->createMock( Title::class );
|
|
$title->method( 'getInternalURL' )->will( $this->returnCallback( function ( $query = '' ) {
|
|
return 'https://test/?title=MediaWiki:Example.js' . ( $query !== '' ? "&$query" : '' );
|
|
} ) );
|
|
$title->method( 'isSiteJsConfigPage' )->willReturn( true );
|
|
$this->assertEquals(
|
|
[
|
|
'https://test/?title=MediaWiki:Example.js',
|
|
'https://test/?title=MediaWiki:Example.js&action=history',
|
|
'https://test/?title=MediaWiki:Example.js&action=raw&ctype=text/javascript',
|
|
],
|
|
$htmlCache->getUrls( $title ),
|
|
'all urls for a site js page'
|
|
);
|
|
}
|
|
}
|