wiki.techinc.nl/includes
Derick Alangi 21e2d71560 Replace some uses of deprecated wfFindFile() and wfLocalFile()
These global functions were deprecated in 1.34 and services made
available to replace them. See services below;

* wfFindFile() - MediaWikiServices::getInstance()->getRepoGroup()->findFile()
* wfLocalFind() - MediaWikiServices::getInstance()->getRepoGroup()->getLocalRepo()->newFile()

NOTES:

* wfFindFile() and wfLocalFind() usages in tests have been ignored
  in this change per @Timo's comments about state of objects.

* includes/upload/UploadBase.php also maintained for now as it causes
  some failures I don't fully understand, will investigate and handle
  it in a follow up patch.

* Also, includes/MovePage.php

Change-Id: I9437494de003f40fbe591321da7b42d16bb732d6
2019-06-11 13:26:37 +00:00
..
actions Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
api Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
auth Rename Block to MediaWiki\Block\DatabaseBlock 2019-05-28 12:20:48 +01:00
block Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad 2019-06-05 11:38:29 -04:00
cache Use IResultWrapper in LinkBatch and BacklinkCache 2019-06-06 21:56:18 +02:00
changes Document $rows on hook ChangesListInitRows as IResultWrapper 2019-06-03 21:35:51 +02:00
changetags SECURITY: Add permission check for user is permitted to view the log type 2019-06-06 19:06:01 +00:00
clientpool Rename CDN config variables to be generic, deprecating the old names 2019-05-24 21:09:22 +00:00
collation Remove several methods, deprecated in 1.32 2019-05-09 11:36:44 -07:00
composer Add some more missing limit parameters to explode() calls 2019-04-05 14:34:39 +00:00
config Remove useless use of current and end 2019-05-18 18:51:44 +00:00
content Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
context Use AtEase::quietCall() instead of Wikimedia\quietCall() 2019-06-10 14:18:19 +00:00
dao dao: Correct return type doc for getLoadBalancer() 2019-04-11 22:24:43 +00:00
db Adjust type hints in database related classes 2019-06-05 19:10:13 +02:00
debug Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
deferred Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
diff Deprecate $wgWikiDiff2MovedParagraphDetectionCutoff 2019-05-22 15:42:20 +02:00
edit Avoid extra parse/save delay for users with non-canonical parser options 2019-04-14 02:00:16 +00:00
editpage Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
exception Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions 2019-05-11 02:44:26 +01:00
export Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
externalstore ExternalStore: Pass external domain to getReadOnlyReason 2019-05-22 19:09:00 +00:00
filebackend Fix/suppress misc phan errors (#5) 2019-04-05 15:53:37 -07:00
filerepo Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
gallery Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
historyblob Move HistoryBlob classes to own files 2019-03-25 20:29:47 +01:00
htmlform HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory 2019-06-04 23:49:20 -04:00
http Return result from HttpRequestFactory get and post methods 2019-05-13 11:32:17 +02:00
import Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
installer Localisation updates from https://translatewiki.net. 2019-06-10 22:18:45 +02:00
interwiki Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
jobqueue Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
json
libs Merge "objectcache: Make BagOStuff::getCurrentTime() public" 2019-06-09 17:33:40 +00:00
linkeddata linkeddata: Fix broken check in PageDataRequestHandler 2019-04-01 11:26:48 +00:00
linker Update LinkRenderer to use NamespaceInfo 2019-05-07 14:52:17 +02:00
logging Pass options as array to IDatabase::insert 2019-06-07 19:12:35 +02:00
mail Deprecate User::isBlocked() 2019-04-25 11:47:44 -04:00
media Allow int as return type of MediaHandler::isMetadataValid 2019-06-04 21:33:37 +02:00
Navigation Refactor buildPrevNextNavigation 2019-06-05 19:32:27 -04:00
objectcache Pass options as array to IDatabase::insert 2019-06-07 19:12:35 +02:00
page Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
pager Refactor buildPrevNextNavigation 2019-06-05 19:32:27 -04:00
parser Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
password Hard deprecate Password::equals() 2019-04-12 18:39:14 -07:00
Permissions Revert "Factors out permissions check from User into PermissionManager service" 2019-05-30 13:51:37 +00:00
poolcounter Avoid/Replace usage of deprecated wfMemcKey() function 2019-05-02 14:27:31 +00:00
preferences Fix ServiceOptions type in constructor documentation 2019-06-06 21:59:27 +02:00
profiler Move SectionProfileCallback to its own file 2019-04-14 19:25:56 +00:00
rcfeed build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass 2019-05-13 14:57:07 +00:00
registration registration: Deprecate ParserTestFiles in extension.json 2019-06-02 21:53:31 -04:00
resourceloader resourceloader: Warn on ResourceLoader::construct without Config 2019-06-10 15:24:45 +00:00
Revision build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass 2019-05-13 14:57:07 +00:00
revisiondelete Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
revisionlist Move class RevisionListBase and friends to own file 2019-03-14 19:50:40 +01:00
search Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
session Use AtEase::quietCall() instead of Wikimedia\quietCall() 2019-06-10 14:18:19 +00:00
shell Update wikimedia/at-ease from 1.2.0 to 2.0.0 2019-05-18 14:32:57 +01:00
site Remove wgSitesCacheFile and rebuildSitesCache.php (unused) 2019-03-15 20:03:44 +00:00
skins Merge "Deprecate logout token on GET" 2019-06-08 19:02:23 +00:00
sparql
specialpage Drop SpecialPage::getTitle() 2019-06-09 04:40:01 +00:00
specials Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
Storage Make sure that each DataUpdate still has outer transaction scope 2019-05-30 20:53:18 +00:00
templates ChangesList: Comment out newlines in EnhancedChangesListGroup.mustache 2019-04-03 06:37:41 +02:00
tidy tidy: Remove unused var and define $parts var to avoid undefined error 2019-06-10 14:34:54 +01:00
title Merge "Fix logic in NamespaceInfo::getRestrictionLevels" 2019-05-22 09:48:08 +00:00
upload Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
user Pass options as array to IDatabase::insert 2019-06-07 19:12:35 +02:00
utils Move ClassCollector to its own file 2019-04-14 19:46:18 +00:00
watcheditem Merge "watcheditem: Do not create the same TitleValue object twice" 2019-06-10 20:27:02 +00:00
widget Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
.htaccess
ActorMigration.php Use the ?? feature instead of isset() where it makes sense 2019-03-24 22:40:49 +01:00
AjaxDispatcher.php
AjaxResponse.php Rename CDN config variables to be generic, deprecating the old names 2019-05-24 21:09:22 +00:00
AutoLoader.php Introduce PermissionManager service 2019-04-05 14:54:51 +00:00
Autopromote.php Deprecate User::isBlocked() 2019-04-25 11:47:44 -04:00
CategoriesRdf.php
Category.php Reinstate small category refresh logic in LinksDeletionUpdate 2019-04-23 17:07:07 -07:00
CategoryFinder.php
CategoryViewer.php Use short assignment operator in PHP 2019-03-07 09:55:49 +01:00
CommentStore.php Fix misc phan errors by adjusting documentation (#8) 2019-04-05 23:31:16 -07:00
CommentStoreComment.php
ConfiguredReadOnlyMode.php Don't pass Config to service constructors 2019-05-02 11:33:56 +03:00
ContentSecurityPolicy.php CSP: Minor cleanup in ContentSecurityPolicy.php 2019-03-20 23:16:01 +01:00
DefaultSettings.php Relax HTML sniffing checks on image upload 2019-06-07 14:21:00 -07:00
Defines.php Make the XML dump schema version configurable. 2019-03-21 12:43:32 +01:00
DeprecatedGlobal.php
DerivativeRequest.php
DevelopmentSettings.php DevelopmentSettings: Remove unused globals & declare $wgSQLMode 2019-04-13 17:54:30 +00:00
DummyLinker.php
EditPage.php Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
EventRelayerGroup.php
FauxRequest.php WebRequest: Change getFullRequestURL() to use local getProtocol() 2019-04-20 00:58:17 +01:00
FauxResponse.php Move FauxResponse class to own file 2019-03-02 18:55:13 +00:00
FeedUtils.php changes: Remove unused FeedUtils::checkPurge method 2019-05-24 13:25:45 +00:00
FileDeleteForm.php
ForeignResourceManager.php Use AtEase::quietCall() instead of Wikimedia\quietCall() 2019-06-10 14:18:19 +00:00
ForkController.php build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0 and make pass 2019-05-13 14:57:07 +00:00
FormOptions.php Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions 2019-05-11 02:44:26 +01:00
GitInfo.php Wording 2019-06-01 14:16:00 +02:00
GlobalFunctions.php Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
HeaderCallback.php Add some @since tags to HeaderCallback 2019-06-06 16:14:58 +01:00
Hooks.php
Html.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
Linker.php Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
LinkFilter.php Fix some docs 2019-05-22 21:50:52 +02:00
ListToggle.php
MagicWord.php Simplify by using ?: operator 2019-04-15 15:05:00 +02:00
MagicWordArray.php Improve return types in class MagicWordArray 2019-06-03 17:52:47 +02:00
MagicWordFactory.php
MediaWiki.php Merge "Rename CDN config variables to be generic, deprecating the old names" 2019-05-24 21:39:53 +00:00
MediaWikiServices.php Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
MediaWikiVersionFetcher.php
MergeHistory.php Improve documentation of constants throughout the codebase 2019-02-26 14:02:50 +01:00
Message.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
MovePage.php Hard-deprecate Title::moveTo and friends 2019-05-28 11:52:36 -05:00
MWGrants.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
MWNamespace.php MWNamespace: Remove deprecated method ::canTalk() and test suit 2019-04-20 21:07:50 +01:00
MWTimestamp.php
NoLocalSettings.php
OrderedStreamingForkController.php
OutputHandler.php Simplify a few list() that only care about the first element 2019-05-17 16:54:47 +02:00
OutputPage.php Rename CDN config variables to be generic, deprecating the old names 2019-05-24 21:09:22 +00:00
PageProps.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
PathRouter.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
PHPVersionCheck.php Use https://www.php.net/ instead of https://secure.php.net/ 2019-04-12 06:44:48 +02:00
Pingback.php Pass options as array to IDatabase::insert 2019-06-07 19:12:35 +02:00
ProtectionForm.php Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
ProxyLookup.php
RawMessage.php
ReadOnlyMode.php Drop clearCache() from (Configured)ReadOnlyMode 2019-04-10 19:39:34 +03:00
Revision.php Move getPrevious/NextRevision logic out of Title 2019-05-05 21:08:46 +03:00
ServiceWiring.php Revert "Factors out permissions check from User into PermissionManager service" 2019-05-30 13:51:37 +00:00
Setup.php Rename CDN config variables to be generic, deprecating the old names 2019-05-24 21:09:22 +00:00
SiteConfiguration.php Get rid of unnecessary func_get_args() and friends 2019-04-12 20:17:01 +00:00
SiteStats.php
SiteStatsInit.php Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
Status.php Status: Make various improvements to the Status class 2019-03-04 00:44:34 +00:00
StreamFile.php
StubObject.php StubObject: Use 'self' instead of 'StubObject' (or <ClassName>) 2019-04-17 14:01:17 +01:00
StubUserLang.php Split StubObject.php to have one class in one file 2019-04-14 14:20:42 +00:00
TemplateParser.php Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
TemplatesOnThisPageFormatter.php Make EditPage::getTemplates avoid page table query spam 2019-03-15 02:34:00 -07:00
Title.php Replace some uses of deprecated wfFindFile() and wfLocalFile() 2019-06-11 13:26:37 +00:00
TitleArray.php Inline trivial …_internal() methods in Title/UserArray classes 2019-05-29 19:22:03 +00:00
TitleArrayFromResult.php
TrackingCategories.php Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
WebRequest.php Allow the request ID to be passed in via the X-Request-Id header 2019-05-15 07:27:38 +00:00
WebRequestUpload.php Use https://www.php.net/ instead of https://secure.php.net/ 2019-04-12 06:44:48 +02:00
WebResponse.php Convert a few call_user_func*() calls to native PHP syntax 2019-03-07 19:25:40 -08:00
WebStart.php Remove "Squiz.WhiteSpace.FunctionSpacing" from phpcs exclusions 2019-05-11 02:44:26 +01:00
WikiMap.php Optimize WikiMap::getWikiFromUrl() for the common local wiki case 2019-05-07 22:10:19 +00:00
WikiReference.php
Xml.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
XmlJsCode.php
XmlSelect.php