wiki.techinc.nl/includes/Storage/PageEditStash.php
Tim Starling 68c433bd23 Hooks::run() call site migration
Migrate all callers of Hooks::run() to use the new
HookContainer/HookRunner system.

General principles:
* Use DI if it is already used. We're not changing the way state is
  managed in this patch.
* HookContainer is always injected, not HookRunner. HookContainer
  is a service, it's a more generic interface, it is the only
  thing that provides isRegistered() which is needed in some cases,
  and a HookRunner can be efficiently constructed from it
  (confirmed by benchmark). Because HookContainer is needed
  for object construction, it is also needed by all factories.
* "Ask your friendly local base class". Big hierarchies like
  SpecialPage and ApiBase have getHookContainer() and getHookRunner()
  methods in the base class, and classes that extend that base class
  are not expected to know or care where the base class gets its
  HookContainer from.
* ProtectedHookAccessorTrait provides protected getHookContainer() and
  getHookRunner() methods, getting them from the global service
  container. The point of this is to ease migration to DI by ensuring
  that call sites ask their local friendly base class rather than
  getting a HookRunner from the service container directly.
* Private $this->hookRunner. In some smaller classes where accessor
  methods did not seem warranted, there is a private HookRunner property
  which is accessed directly. Very rarely (two cases), there is a
  protected property, for consistency with code that conventionally
  assumes protected=private, but in cases where the class might actually
  be overridden, a protected accessor is preferred over a protected
  property.
* The last resort: Hooks::runner(). Mostly for static, file-scope and
  global code. In a few cases it was used for objects with broken
  construction schemes, out of horror or laziness.

Constructors with new required arguments:
* AuthManager
* BadFileLookup
* BlockManager
* ClassicInterwikiLookup
* ContentHandlerFactory
* ContentSecurityPolicy
* DefaultOptionsManager
* DerivedPageDataUpdater
* FullSearchResultWidget
* HtmlCacheUpdater
* LanguageFactory
* LanguageNameUtils
* LinkRenderer
* LinkRendererFactory
* LocalisationCache
* MagicWordFactory
* MessageCache
* NamespaceInfo
* PageEditStash
* PageHandlerFactory
* PageUpdater
* ParserFactory
* PermissionManager
* RevisionStore
* RevisionStoreFactory
* SearchEngineConfig
* SearchEngineFactory
* SearchFormWidget
* SearchNearMatcher
* SessionBackend
* SpecialPageFactory
* UserNameUtils
* UserOptionsManager
* WatchedItemQueryService
* WatchedItemStore

Constructors with new optional arguments:
* DefaultPreferencesFactory
* Language
* LinkHolderArray
* MovePage
* Parser
* ParserCache
* PasswordReset
* Router

setHookContainer() now required after construction:
* AuthenticationProvider
* ResourceLoaderModule
* SearchEngine

Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
2020-05-30 14:23:28 +00:00

514 lines
16 KiB
PHP

<?php
/**
* Predictive edit preparation system for MediaWiki page.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
namespace MediaWiki\Storage;
use ActorMigration;
use BagOStuff;
use Content;
use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
use MediaWiki\HookContainer\HookContainer;
use MediaWiki\HookContainer\HookRunner;
use MediaWiki\Storage\Hook\ParserOutputStashForEditHook;
use ParserOutput;
use Psr\Log\LoggerInterface;
use stdClass;
use Title;
use User;
use Wikimedia\Rdbms\ILoadBalancer;
use Wikimedia\ScopedCallback;
use WikiPage;
/**
* Class for managing stashed edits used by the page updater classes
*
* @since 1.34
*/
class PageEditStash {
/** @var BagOStuff */
private $cache;
/** @var ILoadBalancer */
private $lb;
/** @var LoggerInterface */
private $logger;
/** @var StatsdDataFactoryInterface */
private $stats;
/** @var ParserOutputStashForEditHook */
private $hookRunner;
/** @var int */
private $initiator;
public const ERROR_NONE = 'stashed';
public const ERROR_PARSE = 'error_parse';
public const ERROR_CACHE = 'error_cache';
public const ERROR_UNCACHEABLE = 'uncacheable';
public const ERROR_BUSY = 'busy';
public const PRESUME_FRESH_TTL_SEC = 30;
public const MAX_CACHE_TTL = 300; // 5 minutes
public const MAX_SIGNATURE_TTL = 60;
private const MAX_CACHE_RECENT = 2;
public const INITIATOR_USER = 1;
public const INITIATOR_JOB_OR_CLI = 2;
/**
* @param BagOStuff $cache
* @param ILoadBalancer $lb
* @param LoggerInterface $logger
* @param StatsdDataFactoryInterface $stats
* @param HookContainer $hookContainer
* @param int $initiator Class INITIATOR__* constant
*/
public function __construct(
BagOStuff $cache,
ILoadBalancer $lb,
LoggerInterface $logger,
StatsdDataFactoryInterface $stats,
HookContainer $hookContainer,
$initiator
) {
$this->cache = $cache;
$this->lb = $lb;
$this->logger = $logger;
$this->stats = $stats;
$this->hookRunner = new HookRunner( $hookContainer );
$this->initiator = $initiator;
}
/**
* @param WikiPage $page
* @param Content $content Edit content
* @param User $user
* @param string $summary Edit summary
* @return string Class ERROR_* constant
*/
public function parseAndCache( WikiPage $page, Content $content, User $user, string $summary ) {
$logger = $this->logger;
$title = $page->getTitle();
$key = $this->getStashKey( $title, $this->getContentHash( $content ), $user );
$fname = __METHOD__;
// Use the master DB to allow for fast blocking locks on the "save path" where this
// value might actually be used to complete a page edit. If the edit submission request
// happens before this edit stash requests finishes, then the submission will block until
// the stash request finishes parsing. For the lock acquisition below, there is not much
// need to duplicate parsing of the same content/user/summary bundle, so try to avoid
// blocking at all here.
$dbw = $this->lb->getConnectionRef( DB_MASTER );
if ( !$dbw->lock( $key, $fname, 0 ) ) {
// De-duplicate requests on the same key
return self::ERROR_BUSY;
}
/** @noinspection PhpUnusedLocalVariableInspection */
$unlocker = new ScopedCallback( function () use ( $dbw, $key, $fname ) {
$dbw->unlock( $key, $fname );
} );
$cutoffTime = time() - self::PRESUME_FRESH_TTL_SEC;
// Reuse any freshly build matching edit stash cache
$editInfo = $this->getStashValue( $key );
if ( $editInfo && wfTimestamp( TS_UNIX, $editInfo->timestamp ) >= $cutoffTime ) {
$alreadyCached = true;
} else {
$format = $content->getDefaultFormat();
$editInfo = $page->prepareContentForEdit( $content, null, $user, $format, false );
$editInfo->output->setCacheTime( $editInfo->timestamp );
$alreadyCached = false;
}
$context = [ 'cachekey' => $key, 'title' => $title->getPrefixedText() ];
if ( $editInfo && $editInfo->output ) {
// Let extensions add ParserOutput metadata or warm other caches
$this->hookRunner->onParserOutputStashForEdit(
$page, $content, $editInfo->output, $summary, $user );
if ( $alreadyCached ) {
$logger->debug( "Parser output for key '{cachekey}' already cached.", $context );
return self::ERROR_NONE;
}
$code = $this->storeStashValue(
$key,
$editInfo->pstContent,
$editInfo->output,
$editInfo->timestamp,
$user
);
if ( $code === true ) {
$logger->debug( "Cached parser output for key '{cachekey}'.", $context );
return self::ERROR_NONE;
} elseif ( $code === 'uncacheable' ) {
$logger->info(
"Uncacheable parser output for key '{cachekey}' [{code}].",
$context + [ 'code' => $code ]
);
return self::ERROR_UNCACHEABLE;
} else {
$logger->error(
"Failed to cache parser output for key '{cachekey}'.",
$context + [ 'code' => $code ]
);
return self::ERROR_CACHE;
}
}
return self::ERROR_PARSE;
}
/**
* Check that a prepared edit is in cache and still up-to-date
*
* This method blocks if the prepared edit is already being rendered,
* waiting until rendering finishes before doing final validity checks.
*
* The cache is rejected if template or file changes are detected.
* Note that foreign template or file transclusions are not checked.
*
* This returns an object with the following fields:
* - pstContent: the Content after pre-save-transform
* - output: the ParserOutput instance
* - timestamp: the timestamp of the parse
* - edits: author edit count if they are logged in or NULL otherwise
*
* @param Title $title
* @param Content $content
* @param User $user User to get parser options from
* @return stdClass|bool Returns edit stash object or false on cache miss
*/
public function checkCache( Title $title, Content $content, User $user ) {
if (
// The context is not an HTTP POST request
!$user->getRequest()->wasPosted() ||
// The context is a CLI script or a job runner HTTP POST request
$this->initiator !== self::INITIATOR_USER ||
// The editor account is a known bot
$user->isBot()
) {
// Avoid wasted queries and statsd pollution
return false;
}
$logger = $this->logger;
$key = $this->getStashKey( $title, $this->getContentHash( $content ), $user );
$context = [
'key' => $key,
'title' => $title->getPrefixedText(),
'user' => $user->getName()
];
$editInfo = $this->getAndWaitForStashValue( $key );
if ( !is_object( $editInfo ) || !$editInfo->output ) {
$this->incrStatsByContent( 'cache_misses.no_stash', $content );
if ( $this->recentStashEntryCount( $user ) > 0 ) {
$logger->info( "Empty cache for key '{key}' but not for user.", $context );
} else {
$logger->debug( "Empty cache for key '{key}'.", $context );
}
return false;
}
$age = time() - (int)wfTimestamp( TS_UNIX, $editInfo->output->getCacheTime() );
$context['age'] = $age;
$isCacheUsable = true;
if ( $age <= self::PRESUME_FRESH_TTL_SEC ) {
// Assume nothing changed in this time
$this->incrStatsByContent( 'cache_hits.presumed_fresh', $content );
$logger->debug( "Timestamp-based cache hit for key '{key}'.", $context );
} elseif ( $user->isAnon() ) {
$lastEdit = $this->lastEditTime( $user );
$cacheTime = $editInfo->output->getCacheTime();
if ( $lastEdit < $cacheTime ) {
// Logged-out user made no local upload/template edits in the meantime
$this->incrStatsByContent( 'cache_hits.presumed_fresh', $content );
$logger->debug( "Edit check based cache hit for key '{key}'.", $context );
} else {
$isCacheUsable = false;
$this->incrStatsByContent( 'cache_misses.proven_stale', $content );
$logger->info( "Stale cache for key '{key}' due to outside edits.", $context );
}
} else {
if ( $editInfo->edits === $user->getEditCount() ) {
// Logged-in user made no local upload/template edits in the meantime
$this->incrStatsByContent( 'cache_hits.presumed_fresh', $content );
$logger->debug( "Edit count based cache hit for key '{key}'.", $context );
} else {
$isCacheUsable = false;
$this->incrStatsByContent( 'cache_misses.proven_stale', $content );
$logger->info( "Stale cache for key '{key}'due to outside edits.", $context );
}
}
if ( !$isCacheUsable ) {
return false;
}
if ( $editInfo->output->getFlag( 'vary-revision' ) ) {
// This can be used for the initial parse, e.g. for filters or doEditContent(),
// but a second parse will be triggered in doEditUpdates() no matter what
$logger->info(
"Cache for key '{key}' has vary-revision; post-insertion parse inevitable.",
$context
);
} else {
static $flagsMaybeReparse = [
// Similar to the above if we didn't guess the ID correctly
'vary-revision-id',
// Similar to the above if we didn't guess the timestamp correctly
'vary-revision-timestamp',
// Similar to the above if we didn't guess the content correctly
'vary-revision-sha1',
// Similar to the above if we didn't guess page ID correctly
'vary-page-id'
];
foreach ( $flagsMaybeReparse as $flag ) {
if ( $editInfo->output->getFlag( $flag ) ) {
$logger->debug(
"Cache for key '{key}' has $flag; post-insertion parse possible.",
$context
);
}
}
}
return $editInfo;
}
/**
* @param string $subkey
* @param Content $content
*/
private function incrStatsByContent( $subkey, Content $content ) {
$this->stats->increment( 'editstash.' . $subkey ); // overall for b/c
$this->stats->increment( 'editstash_by_model.' . $content->getModel() . '.' . $subkey );
}
/**
* @param string $key
* @return bool|stdClass
*/
private function getAndWaitForStashValue( $key ) {
$editInfo = $this->getStashValue( $key );
if ( !$editInfo ) {
$start = microtime( true );
// We ignore user aborts and keep parsing. Block on any prior parsing
// so as to use its results and make use of the time spent parsing.
// Skip this logic if there no master connection in case this method
// is called on an HTTP GET request for some reason.
$dbw = $this->lb->getAnyOpenConnection( $this->lb->getWriterIndex() );
if ( $dbw && $dbw->lock( $key, __METHOD__, 30 ) ) {
$editInfo = $this->getStashValue( $key );
$dbw->unlock( $key, __METHOD__ );
}
$timeMs = 1000 * max( 0, microtime( true ) - $start );
$this->stats->timing( 'editstash.lock_wait_time', $timeMs );
}
return $editInfo;
}
/**
* @param string $textHash
* @return string|bool Text or false if missing
*/
public function fetchInputText( $textHash ) {
$textKey = $this->cache->makeKey( 'stashedit', 'text', $textHash );
return $this->cache->get( $textKey );
}
/**
* @param string $text
* @param string $textHash
* @return bool Success
*/
public function stashInputText( $text, $textHash ) {
$textKey = $this->cache->makeKey( 'stashedit', 'text', $textHash );
return $this->cache->set(
$textKey,
$text,
self::MAX_CACHE_TTL,
BagOStuff::WRITE_ALLOW_SEGMENTS
);
}
/**
* @param User $user
* @return string|null TS_MW timestamp or null
*/
private function lastEditTime( User $user ) {
$db = $this->lb->getConnectionRef( DB_REPLICA );
$actorQuery = ActorMigration::newMigration()->getWhere( $db, 'rc_user', $user, false );
$time = $db->selectField(
[ 'recentchanges' ] + $actorQuery['tables'],
'MAX(rc_timestamp)',
[ $actorQuery['conds'] ],
__METHOD__,
[],
$actorQuery['joins']
);
return wfTimestampOrNull( TS_MW, $time );
}
/**
* Get hash of the content, factoring in model/format
*
* @param Content $content
* @return string
*/
private function getContentHash( Content $content ) {
return sha1( implode( "\n", [
$content->getModel(),
$content->getDefaultFormat(),
$content->serialize( $content->getDefaultFormat() )
] ) );
}
/**
* Get the temporary prepared edit stash key for a user
*
* This key can be used for caching prepared edits provided:
* - a) The $user was used for PST options
* - b) The parser output was made from the PST using cannonical matching options
*
* @param Title $title
* @param string $contentHash Result of getContentHash()
* @param User $user User to get parser options from
* @return string
*/
private function getStashKey( Title $title, $contentHash, User $user ) {
return $this->cache->makeKey(
'stashedit-info-v1',
md5( $title->getPrefixedDBkey() ),
// Account for the edit model/text
$contentHash,
// Account for user name related variables like signatures
md5( $user->getId() . "\n" . $user->getName() )
);
}
/**
* @param string $key
* @return stdClass|bool Object map (pstContent,output,outputID,timestamp,edits) or false
*/
private function getStashValue( $key ) {
$stashInfo = $this->cache->get( $key );
if ( is_object( $stashInfo ) && $stashInfo->output instanceof ParserOutput ) {
return $stashInfo;
}
return false;
}
/**
* Build a value to store in memcached based on the PST content and parser output
*
* This makes a simple version of WikiPage::prepareContentForEdit() as stash info
*
* @param string $key
* @param Content $pstContent Pre-Save transformed content
* @param ParserOutput $parserOutput
* @param string $timestamp TS_MW
* @param User $user
* @return string|bool True or an error code
*/
private function storeStashValue(
$key,
Content $pstContent,
ParserOutput $parserOutput,
$timestamp,
User $user
) {
// If an item is renewed, mind the cache TTL determined by config and parser functions.
// Put an upper limit on the TTL for sanity to avoid extreme template/file staleness.
$age = time() - (int)wfTimestamp( TS_UNIX, $parserOutput->getCacheTime() );
$ttl = min( $parserOutput->getCacheExpiry() - $age, self::MAX_CACHE_TTL );
// Avoid extremely stale user signature timestamps (T84843)
if ( $parserOutput->getFlag( 'user-signature' ) ) {
$ttl = min( $ttl, self::MAX_SIGNATURE_TTL );
}
if ( $ttl <= 0 ) {
return 'uncacheable'; // low TTL due to a tag, magic word, or signature?
}
// Store what is actually needed and split the output into another key (T204742)
$stashInfo = (object)[
'pstContent' => $pstContent,
'output' => $parserOutput,
'timestamp' => $timestamp,
'edits' => $user->getEditCount()
];
$ok = $this->cache->set( $key, $stashInfo, $ttl, BagOStuff::WRITE_ALLOW_SEGMENTS );
if ( $ok ) {
// These blobs can waste slots in low cardinality memcached slabs
$this->pruneExcessStashedEntries( $user, $key );
}
return $ok ? true : 'store_error';
}
/**
* @param User $user
* @param string $newKey
*/
private function pruneExcessStashedEntries( User $user, $newKey ) {
$key = $this->cache->makeKey( 'stash-edit-recent', sha1( $user->getName() ) );
$keyList = $this->cache->get( $key ) ?: [];
if ( count( $keyList ) >= self::MAX_CACHE_RECENT ) {
$oldestKey = array_shift( $keyList );
$this->cache->delete( $oldestKey, BagOStuff::WRITE_PRUNE_SEGMENTS );
}
$keyList[] = $newKey;
$this->cache->set( $key, $keyList, 2 * self::MAX_CACHE_TTL );
}
/**
* @param User $user
* @return int
*/
private function recentStashEntryCount( User $user ) {
$key = $this->cache->makeKey( 'stash-edit-recent', sha1( $user->getName() ) );
return count( $this->cache->get( $key ) ?: [] );
}
}