29e0183a56
This code didn't work because the $GLOBALS array is exposed by reference. Once this reference was broken by unset(), the rest just manipulated a local array that happens to be called "GLOBALS". It must not be unset or re-assigned. It can only be changed in-place. Before this, the execution of a MediaWikiUnitTestCase test stored a copy of GLOBALS in unitGlobals, then lost the GLOBALS pointer and created a new variable called "GLOBALS". As such, the tearDown() function didn't do what it meant to do, either – which then results in odd failures like T230023 Rewrite it as follows: * In setup, store the current GLOBALS keys and values, then reduce GLOBALS to only the whitelisted keys and values. * In teardown, restore the original state. * As optimisation, do this from setUpBeforeClass as well, so that there are relatively few globals to reset between tests. (Thanks @Simetrical!) The following tests were previously passing by accident under MediaWikiUnitTestCase but actually did depend on global config. * MainSlotRoleHandlerTest (…, ContentHandler, $wgContentHandlers) * SlotRecordTest (…, ContentHandler, $wgContentHandlers) * WikiReferenceTest (wfParseUrl, $wgUrlProtocols) * DifferenceEngineSlotDiffRendererTest (DifferenceEngine, wfDebug, …) * SlotDiffRendererTest (…, ContentHandler, $wgContentHandlers) * FileBackendDBRepoWrapperTest (wfWikiID, "Backend domain ID not provided") * JpegMetadataExtractorTest (…, wfDebug, …, LoggerFactory, …) * ParserFactoryTest (…, wfDebug, …, LoggerFactory, InvalidArgumentException) * MediaWikiPageNameNormalizerTest (…, wfDebug, …, LoggerFactory, …) * SiteExporterTest (SiteImporter, wfLogWarning, …) * SiteImporterTest (Site::newForType, $wgSiteTypes) * ZipDirectoryReaderTest (…, wfDebug, …, LoggerFactory, …) Bug: T230023 Change-Id: Ic22075bb5e81b7c2c4c1b8647547aa55306a10a7
44 lines
1.5 KiB
PHP
44 lines
1.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers DifferenceEngineSlotDiffRenderer
|
|
*/
|
|
class DifferenceEngineSlotDiffRendererTest extends MediaWikiIntegrationTestCase {
|
|
|
|
public function testGetDiff() {
|
|
$differenceEngine = new CustomDifferenceEngine();
|
|
$slotDiffRenderer = new DifferenceEngineSlotDiffRenderer( $differenceEngine );
|
|
$oldContent = ContentHandler::makeContent( 'xxx', null, CONTENT_MODEL_TEXT );
|
|
$newContent = ContentHandler::makeContent( 'yyy', null, CONTENT_MODEL_TEXT );
|
|
|
|
$diff = $slotDiffRenderer->getDiff( $oldContent, $newContent );
|
|
$this->assertEquals( 'xxx|yyy', $diff );
|
|
|
|
$diff = $slotDiffRenderer->getDiff( null, $newContent );
|
|
$this->assertEquals( '|yyy', $diff );
|
|
|
|
$diff = $slotDiffRenderer->getDiff( $oldContent, null );
|
|
$this->assertEquals( 'xxx|', $diff );
|
|
}
|
|
|
|
public function testAddModules() {
|
|
$output = $this->getMockBuilder( OutputPage::class )
|
|
->disableOriginalConstructor()
|
|
->setMethods( [ 'addModules' ] )
|
|
->getMock();
|
|
$output->expects( $this->once() )
|
|
->method( 'addModules' )
|
|
->with( 'foo' );
|
|
$differenceEngine = new CustomDifferenceEngine();
|
|
$slotDiffRenderer = new DifferenceEngineSlotDiffRenderer( $differenceEngine );
|
|
$slotDiffRenderer->addModules( $output );
|
|
}
|
|
|
|
public function testGetExtraCacheKeys() {
|
|
$differenceEngine = new CustomDifferenceEngine();
|
|
$slotDiffRenderer = new DifferenceEngineSlotDiffRenderer( $differenceEngine );
|
|
$extraCacheKeys = $slotDiffRenderer->getExtraCacheKeys();
|
|
$this->assertSame( [ 'foo' ], $extraCacheKeys );
|
|
}
|
|
|
|
}
|