8e1bb24eed
In LoadBalancer: * Make the "chronologyCallback" return the DBPrimaryPos and make loadSessionPrimaryPos() set the "waitForPos" more directly by calling setSessionPrimaryPosIfHigher(). Previously, it relied on the callback calling waitFor() to set the position as a side effect. * Remove redundant debug log entry in loadSessionPrimaryPos(). * Use type hints for waitFor()/waitForAll(). All callers already check this for before invocation. * Mark getReplicaResumePos() as @internal. In ChronologyProtector: * Update applySessionReplicationPosition() to return the position. * Rename applySessionReplicationPosition() to yieldSessionPrimaryPos() and stageSessionReplicationPosition() to stageSessionPrimaryPos() for for consistency LoadBalancer/DBPrimaryPos. Bug: T314434 Change-Id: I32aa784b424e7534047c9240e32fa5e0a2ac90b0
127 lines
3.4 KiB
PHP
127 lines
3.4 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Holds tests for ChronologyProtector abstract MediaWiki class.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use Wikimedia\Rdbms\ChronologyProtector;
|
|
use Wikimedia\Rdbms\ILoadBalancer;
|
|
use Wikimedia\Rdbms\MySQLPrimaryPos;
|
|
|
|
/**
|
|
* @covers \Wikimedia\Rdbms\ChronologyProtector
|
|
*/
|
|
class ChronologyProtectorTest extends PHPUnit\Framework\TestCase {
|
|
/**
|
|
* @dataProvider clientIdProvider
|
|
* @param array $client
|
|
* @param string $secret
|
|
* @param string $expectedId
|
|
*/
|
|
public function testClientId( array $client, $secret, $expectedId ) {
|
|
$bag = new HashBagOStuff();
|
|
$cp = new ChronologyProtector( $bag, $client, null, $secret );
|
|
|
|
$this->assertEquals( $expectedId, $cp->getClientId() );
|
|
}
|
|
|
|
public function clientIdProvider() {
|
|
return [
|
|
[
|
|
[
|
|
'ip' => '127.0.0.1',
|
|
'agent' => "Totally-Not-FireFox"
|
|
],
|
|
'',
|
|
'45e93a9c215c031d38b7c42d8e4700ca',
|
|
],
|
|
[
|
|
[
|
|
'ip' => '127.0.0.7',
|
|
'agent' => "Totally-Not-FireFox"
|
|
],
|
|
'',
|
|
'b1d604117b51746c35c3df9f293c84dc'
|
|
],
|
|
[
|
|
[
|
|
'ip' => '127.0.0.1',
|
|
'agent' => "Totally-FireFox"
|
|
],
|
|
'',
|
|
'731b4e06a65e2346b497fc811571c4d7'
|
|
],
|
|
[
|
|
[
|
|
'ip' => '127.0.0.1',
|
|
'agent' => "Totally-Not-FireFox"
|
|
],
|
|
'secret',
|
|
'defff51ded73cd901253d874c9b2077d'
|
|
]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers \Wikimedia\Rdbms\ChronologyProtector
|
|
* @covers \Wikimedia\Rdbms\MySQLPrimaryPos
|
|
*/
|
|
public function testPositionMarshalling() {
|
|
$replicationPos = '1-2-3';
|
|
$time = 100;
|
|
|
|
$lb = $this->createMock( ILoadBalancer::class );
|
|
$lb->method( 'getClusterName' )->willReturn( 'test' );
|
|
$lb->method( 'getServerName' )->willReturn( 'primary' );
|
|
$lb->method( 'hasOrMadeRecentPrimaryChanges' )->willReturn( true );
|
|
$lb->method( 'hasStreamingReplicaServers' )->willReturn( true );
|
|
$lb->method( 'getReplicaResumePos' )->willReturnCallback(
|
|
static function () use ( &$replicationPos, &$time ) {
|
|
return new MySQLPrimaryPos( $replicationPos, $time );
|
|
}
|
|
);
|
|
|
|
$client = [
|
|
'ip' => '127.0.0.1',
|
|
'agent' => "Burninator"
|
|
];
|
|
|
|
$secret = '0815';
|
|
|
|
$bag = new HashBagOStuff();
|
|
$cp = new ChronologyProtector( $bag, $client, null, $secret );
|
|
|
|
$clientPostIndex = 0;
|
|
$cp->stageSessionPrimaryPos( $lb );
|
|
$cp->persistSessionReplicationPositions( $clientPostIndex );
|
|
|
|
// Do it a second time so the values that were written the first
|
|
// time get read from the cache.
|
|
$replicationPos = '3-4-5';
|
|
$time++;
|
|
$cp->stageSessionPrimaryPos( $lb );
|
|
$cp->persistSessionReplicationPositions( $clientPostIndex );
|
|
|
|
$waitForPos = $cp->yieldSessionPrimaryPos( $lb );
|
|
$this->assertNotNull( $waitForPos );
|
|
$this->assertSame( $time, $waitForPos->asOfTime() );
|
|
$this->assertSame( "$replicationPos", "$waitForPos" );
|
|
}
|
|
}
|