Migrate all callers of Hooks::run() to use the new HookContainer/HookRunner system. General principles: * Use DI if it is already used. We're not changing the way state is managed in this patch. * HookContainer is always injected, not HookRunner. HookContainer is a service, it's a more generic interface, it is the only thing that provides isRegistered() which is needed in some cases, and a HookRunner can be efficiently constructed from it (confirmed by benchmark). Because HookContainer is needed for object construction, it is also needed by all factories. * "Ask your friendly local base class". Big hierarchies like SpecialPage and ApiBase have getHookContainer() and getHookRunner() methods in the base class, and classes that extend that base class are not expected to know or care where the base class gets its HookContainer from. * ProtectedHookAccessorTrait provides protected getHookContainer() and getHookRunner() methods, getting them from the global service container. The point of this is to ease migration to DI by ensuring that call sites ask their local friendly base class rather than getting a HookRunner from the service container directly. * Private $this->hookRunner. In some smaller classes where accessor methods did not seem warranted, there is a private HookRunner property which is accessed directly. Very rarely (two cases), there is a protected property, for consistency with code that conventionally assumes protected=private, but in cases where the class might actually be overridden, a protected accessor is preferred over a protected property. * The last resort: Hooks::runner(). Mostly for static, file-scope and global code. In a few cases it was used for objects with broken construction schemes, out of horror or laziness. Constructors with new required arguments: * AuthManager * BadFileLookup * BlockManager * ClassicInterwikiLookup * ContentHandlerFactory * ContentSecurityPolicy * DefaultOptionsManager * DerivedPageDataUpdater * FullSearchResultWidget * HtmlCacheUpdater * LanguageFactory * LanguageNameUtils * LinkRenderer * LinkRendererFactory * LocalisationCache * MagicWordFactory * MessageCache * NamespaceInfo * PageEditStash * PageHandlerFactory * PageUpdater * ParserFactory * PermissionManager * RevisionStore * RevisionStoreFactory * SearchEngineConfig * SearchEngineFactory * SearchFormWidget * SearchNearMatcher * SessionBackend * SpecialPageFactory * UserNameUtils * UserOptionsManager * WatchedItemQueryService * WatchedItemStore Constructors with new optional arguments: * DefaultPreferencesFactory * Language * LinkHolderArray * MovePage * Parser * ParserCache * PasswordReset * Router setHookContainer() now required after construction: * AuthenticationProvider * ResourceLoaderModule * SearchEngine Change-Id: Id442b0dbe43aba84bd5cf801d86dedc768b082c7
440 lines
13 KiB
PHP
440 lines
13 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Copyright © 2015 Geoffrey Mon <geofbot@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\Content\IContentHandlerFactory;
|
|
use MediaWiki\EditPage\SpamChecker;
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Permissions\PermissionManager;
|
|
use MediaWiki\Revision\MutableRevisionRecord;
|
|
use MediaWiki\Revision\RevisionStore;
|
|
use MediaWiki\Revision\SlotRecord;
|
|
use Wikimedia\Rdbms\IDatabase;
|
|
use Wikimedia\Rdbms\ILoadBalancer;
|
|
use Wikimedia\Timestamp\TimestampException;
|
|
|
|
/**
|
|
* Handles the backend logic of merging the histories of two
|
|
* pages.
|
|
*
|
|
* @since 1.27
|
|
*/
|
|
class MergeHistory {
|
|
|
|
/** Maximum number of revisions that can be merged at once */
|
|
public const REVISION_LIMIT = 5000;
|
|
|
|
/** @var Title Page from which history will be merged */
|
|
protected $source;
|
|
|
|
/** @var Title Page to which history will be merged */
|
|
protected $dest;
|
|
|
|
/** @var IDatabase Database that we are using */
|
|
protected $dbw;
|
|
|
|
/** @var MWTimestamp Maximum timestamp that we can use (oldest timestamp of dest) */
|
|
protected $maxTimestamp;
|
|
|
|
/** @var string SQL WHERE condition that selects source revisions to insert into destination */
|
|
protected $timeWhere;
|
|
|
|
/** @var MWTimestamp|bool Timestamp upto which history from the source will be merged */
|
|
protected $timestampLimit;
|
|
|
|
/** @var int Number of revisions merged (for Special:MergeHistory success message) */
|
|
protected $revisionsMerged;
|
|
|
|
/** @var PermissionManager */
|
|
private $permManager;
|
|
|
|
/** @var IContentHandlerFactory */
|
|
private $contentHandlerFactory;
|
|
|
|
/** @var RevisionStore */
|
|
private $revisionStore;
|
|
|
|
/** @var WatchedItemStoreInterface */
|
|
private $watchedItemStore;
|
|
|
|
/** @var SpamChecker */
|
|
private $spamChecker;
|
|
|
|
/**
|
|
* Since 1.35 dependencies are injected and not providing them is hard deprecated; use the
|
|
* MergeHistoryFactory service
|
|
*
|
|
* @param Title $source Page from which history will be merged
|
|
* @param Title $dest Page to which history will be merged
|
|
* @param string|bool $timestamp Timestamp up to which history from the source will be merged
|
|
* @param ILoadBalancer|null $loadBalancer
|
|
* @param PermissionManager|null $permManager
|
|
* @param IContentHandlerFactory|null $contentHandlerFactory
|
|
* @param RevisionStore|null $revisionStore
|
|
* @param WatchedItemStoreInterface|null $watchedItemStore
|
|
* @param SpamChecker|null $spamChecker
|
|
*/
|
|
public function __construct(
|
|
Title $source,
|
|
Title $dest,
|
|
$timestamp = false,
|
|
ILoadBalancer $loadBalancer = null,
|
|
PermissionManager $permManager = null,
|
|
IContentHandlerFactory $contentHandlerFactory = null,
|
|
RevisionStore $revisionStore = null,
|
|
WatchedItemStoreInterface $watchedItemStore = null,
|
|
SpamChecker $spamChecker = null
|
|
) {
|
|
if ( $loadBalancer === null ) {
|
|
wfDeprecated( __CLASS__ . ' being constructed directly', '1.35' );
|
|
$services = MediaWikiServices::getInstance();
|
|
|
|
$loadBalancer = $services->getDBLoadBalancer();
|
|
$permManager = $services->getPermissionManager();
|
|
$contentHandlerFactory = $services->getContentHandlerFactory();
|
|
$revisionStore = $services->getRevisionStore();
|
|
$watchedItemStore = $services->getWatchedItemStore();
|
|
$spamChecker = $services->getSpamChecker();
|
|
}
|
|
|
|
// Save the parameters
|
|
$this->source = $source;
|
|
$this->dest = $dest;
|
|
|
|
// Get the database
|
|
$this->dbw = $loadBalancer->getConnection( DB_MASTER );
|
|
|
|
$this->permManager = $permManager;
|
|
$this->contentHandlerFactory = $contentHandlerFactory;
|
|
$this->revisionStore = $revisionStore;
|
|
$this->watchedItemStore = $watchedItemStore;
|
|
$this->spamChecker = $spamChecker;
|
|
|
|
// Max timestamp should be min of destination page
|
|
$firstDestTimestamp = $this->dbw->selectField(
|
|
'revision',
|
|
'MIN(rev_timestamp)',
|
|
[ 'rev_page' => $this->dest->getArticleID() ],
|
|
__METHOD__
|
|
);
|
|
$this->maxTimestamp = new MWTimestamp( $firstDestTimestamp );
|
|
|
|
// Get the timestamp pivot condition
|
|
try {
|
|
if ( $timestamp ) {
|
|
// If we have a requested timestamp, use the
|
|
// latest revision up to that point as the insertion point
|
|
$mwTimestamp = new MWTimestamp( $timestamp );
|
|
$lastWorkingTimestamp = $this->dbw->selectField(
|
|
'revision',
|
|
'MAX(rev_timestamp)',
|
|
[
|
|
'rev_timestamp <= ' .
|
|
$this->dbw->addQuotes( $this->dbw->timestamp( $mwTimestamp ) ),
|
|
'rev_page' => $this->source->getArticleID()
|
|
],
|
|
__METHOD__
|
|
);
|
|
$mwLastWorkingTimestamp = new MWTimestamp( $lastWorkingTimestamp );
|
|
|
|
$timeInsert = $mwLastWorkingTimestamp;
|
|
$this->timestampLimit = $mwLastWorkingTimestamp;
|
|
} else {
|
|
// If we don't, merge entire source page history into the
|
|
// beginning of destination page history
|
|
|
|
// Get the latest timestamp of the source
|
|
$lastSourceTimestamp = $this->dbw->selectField(
|
|
[ 'page', 'revision' ],
|
|
'rev_timestamp',
|
|
[ 'page_id' => $this->source->getArticleID(),
|
|
'page_latest = rev_id'
|
|
],
|
|
__METHOD__
|
|
);
|
|
$lasttimestamp = new MWTimestamp( $lastSourceTimestamp );
|
|
|
|
$timeInsert = $this->maxTimestamp;
|
|
$this->timestampLimit = $lasttimestamp;
|
|
}
|
|
|
|
$this->timeWhere = "rev_timestamp <= " .
|
|
$this->dbw->addQuotes( $this->dbw->timestamp( $timeInsert ) );
|
|
} catch ( TimestampException $ex ) {
|
|
// The timestamp we got is screwed up and merge cannot continue
|
|
// This should be detected by $this->isValidMerge()
|
|
$this->timestampLimit = false;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Get the number of revisions that will be moved
|
|
* @return int
|
|
*/
|
|
public function getRevisionCount() {
|
|
$count = $this->dbw->selectRowCount( 'revision', '1',
|
|
[ 'rev_page' => $this->source->getArticleID(), $this->timeWhere ],
|
|
__METHOD__,
|
|
[ 'LIMIT' => self::REVISION_LIMIT + 1 ]
|
|
);
|
|
|
|
return $count;
|
|
}
|
|
|
|
/**
|
|
* Get the number of revisions that were moved
|
|
* Used in the SpecialMergeHistory success message
|
|
* @return int
|
|
*/
|
|
public function getMergedRevisionCount() {
|
|
return $this->revisionsMerged;
|
|
}
|
|
|
|
/**
|
|
* Check if the merge is possible
|
|
* @param User $user
|
|
* @param string $reason
|
|
* @return Status
|
|
*/
|
|
public function checkPermissions( User $user, $reason ) {
|
|
$status = new Status();
|
|
|
|
// Check if user can edit both pages
|
|
$errors = wfMergeErrorArrays(
|
|
$this->permManager->getPermissionErrors( 'edit', $user, $this->source ),
|
|
$this->permManager->getPermissionErrors( 'edit', $user, $this->dest )
|
|
);
|
|
|
|
// Convert into a Status object
|
|
if ( $errors ) {
|
|
foreach ( $errors as $error ) {
|
|
$status->fatal( ...$error );
|
|
}
|
|
}
|
|
|
|
// Anti-spam
|
|
if ( $this->spamChecker->checkSummary( $reason ) !== false ) {
|
|
// This is kind of lame, won't display nice
|
|
$status->fatal( 'spamprotectiontext' );
|
|
}
|
|
|
|
// Check mergehistory permission
|
|
if ( !$this->permManager->userHasRight( $user, 'mergehistory' ) ) {
|
|
// User doesn't have the right to merge histories
|
|
$status->fatal( 'mergehistory-fail-permission' );
|
|
}
|
|
|
|
return $status;
|
|
}
|
|
|
|
/**
|
|
* Does various sanity checks that the merge is
|
|
* valid. Only things based on the two pages
|
|
* should be checked here.
|
|
*
|
|
* @return Status
|
|
*/
|
|
public function isValidMerge() {
|
|
$status = new Status();
|
|
|
|
// If either article ID is 0, then revisions cannot be reliably selected
|
|
if ( $this->source->getArticleID() === 0 ) {
|
|
$status->fatal( 'mergehistory-fail-invalid-source' );
|
|
}
|
|
if ( $this->dest->getArticleID() === 0 ) {
|
|
$status->fatal( 'mergehistory-fail-invalid-dest' );
|
|
}
|
|
|
|
// Make sure page aren't the same
|
|
if ( $this->source->equals( $this->dest ) ) {
|
|
$status->fatal( 'mergehistory-fail-self-merge' );
|
|
}
|
|
|
|
// Make sure the timestamp is valid
|
|
if ( !$this->timestampLimit ) {
|
|
$status->fatal( 'mergehistory-fail-bad-timestamp' );
|
|
}
|
|
|
|
// $this->timestampLimit must be older than $this->maxTimestamp
|
|
if ( $this->timestampLimit > $this->maxTimestamp ) {
|
|
$status->fatal( 'mergehistory-fail-timestamps-overlap' );
|
|
}
|
|
|
|
// Check that there are not too many revisions to move
|
|
if ( $this->timestampLimit && $this->getRevisionCount() > self::REVISION_LIMIT ) {
|
|
$status->fatal( 'mergehistory-fail-toobig', Message::numParam( self::REVISION_LIMIT ) );
|
|
}
|
|
|
|
return $status;
|
|
}
|
|
|
|
/**
|
|
* Actually attempt the history move
|
|
*
|
|
* @todo if all versions of page A are moved to B and then a user
|
|
* tries to do a reverse-merge via the "unmerge" log link, then page
|
|
* A will still be a redirect (as it was after the original merge),
|
|
* though it will have the old revisions back from before (as expected).
|
|
* The user may have to "undo" the redirect manually to finish the "unmerge".
|
|
* Maybe this should delete redirects at the source page of merges?
|
|
*
|
|
* @param User $user
|
|
* @param string $reason
|
|
* @return Status status of the history merge
|
|
*/
|
|
public function merge( User $user, $reason = '' ) {
|
|
$status = new Status();
|
|
|
|
// Check validity and permissions required for merge
|
|
$validCheck = $this->isValidMerge(); // Check this first to check for null pages
|
|
if ( !$validCheck->isOK() ) {
|
|
return $validCheck;
|
|
}
|
|
$permCheck = $this->checkPermissions( $user, $reason );
|
|
if ( !$permCheck->isOK() ) {
|
|
return $permCheck;
|
|
}
|
|
|
|
$this->dbw->startAtomic( __METHOD__ );
|
|
|
|
$this->dbw->update(
|
|
'revision',
|
|
[ 'rev_page' => $this->dest->getArticleID() ],
|
|
[ 'rev_page' => $this->source->getArticleID(), $this->timeWhere ],
|
|
__METHOD__
|
|
);
|
|
|
|
// Check if this did anything
|
|
$this->revisionsMerged = $this->dbw->affectedRows();
|
|
if ( $this->revisionsMerged < 1 ) {
|
|
$this->dbw->endAtomic( __METHOD__ );
|
|
$status->fatal( 'mergehistory-fail-no-change' );
|
|
|
|
return $status;
|
|
}
|
|
|
|
// Update denormalized revactor_page too
|
|
$this->dbw->update(
|
|
'revision_actor_temp',
|
|
[ 'revactor_page' => $this->dest->getArticleID() ],
|
|
[
|
|
'revactor_page' => $this->source->getArticleID(),
|
|
// Slightly hacky, but should work given the values assigned in this class
|
|
str_replace( 'rev_timestamp', 'revactor_timestamp', $this->timeWhere )
|
|
],
|
|
__METHOD__
|
|
);
|
|
|
|
// Make the source page a redirect if no revisions are left
|
|
$haveRevisions = $this->dbw->lockForUpdate(
|
|
'revision',
|
|
[ 'rev_page' => $this->source->getArticleID() ],
|
|
__METHOD__
|
|
);
|
|
|
|
if ( !$haveRevisions ) {
|
|
if ( $reason ) {
|
|
$reason = wfMessage(
|
|
'mergehistory-comment',
|
|
$this->source->getPrefixedText(),
|
|
$this->dest->getPrefixedText(),
|
|
$reason
|
|
)->inContentLanguage()->text();
|
|
} else {
|
|
$reason = wfMessage(
|
|
'mergehistory-autocomment',
|
|
$this->source->getPrefixedText(),
|
|
$this->dest->getPrefixedText()
|
|
)->inContentLanguage()->text();
|
|
}
|
|
|
|
$redirectContent = $this->contentHandlerFactory
|
|
->getContentHandler( $this->source->getContentModel() )
|
|
->makeRedirectContent(
|
|
$this->dest,
|
|
wfMessage( 'mergehistory-redirect-text' )->inContentLanguage()->plain()
|
|
);
|
|
|
|
if ( $redirectContent ) {
|
|
$redirectComment = CommentStoreComment::newUnsavedComment( $reason );
|
|
|
|
$redirectRevRecord = new MutableRevisionRecord( $this->source );
|
|
$redirectRevRecord->setContent( SlotRecord::MAIN, $redirectContent );
|
|
$redirectRevRecord->setPageId( $this->source->getArticleID() );
|
|
$redirectRevRecord->setComment( $redirectComment );
|
|
$redirectRevRecord->setUser( $user );
|
|
$redirectRevRecord->setTimestamp( wfTimestampNow() );
|
|
|
|
$insertedRevRecord = $this->revisionStore->insertRevisionOn(
|
|
$redirectRevRecord,
|
|
$this->dbw
|
|
);
|
|
|
|
$redirectPage = WikiPage::factory( $this->source );
|
|
$redirectPage->updateRevisionOn( $this->dbw, $insertedRevRecord );
|
|
|
|
// Now, we record the link from the redirect to the new title.
|
|
// It should have no other outgoing links...
|
|
$this->dbw->delete(
|
|
'pagelinks',
|
|
[ 'pl_from' => $this->dest->getArticleID() ],
|
|
__METHOD__
|
|
);
|
|
$this->dbw->insert( 'pagelinks',
|
|
[
|
|
'pl_from' => $this->dest->getArticleID(),
|
|
'pl_from_namespace' => $this->dest->getNamespace(),
|
|
'pl_namespace' => $this->dest->getNamespace(),
|
|
'pl_title' => $this->dest->getDBkey() ],
|
|
__METHOD__
|
|
);
|
|
} else {
|
|
// Warning if we couldn't create the redirect
|
|
$status->warning( 'mergehistory-warning-redirect-not-created' );
|
|
}
|
|
} else {
|
|
$this->source->invalidateCache(); // update histories
|
|
}
|
|
$this->dest->invalidateCache(); // update histories
|
|
|
|
// Duplicate watchers of the old article to the new article on history merge
|
|
$this->watchedItemStore->duplicateAllAssociatedEntries( $this->source, $this->dest );
|
|
|
|
// Update our logs
|
|
$logEntry = new ManualLogEntry( 'merge', 'merge' );
|
|
$logEntry->setPerformer( $user );
|
|
$logEntry->setComment( $reason );
|
|
$logEntry->setTarget( $this->source );
|
|
$logEntry->setParameters( [
|
|
'4::dest' => $this->dest->getPrefixedText(),
|
|
'5::mergepoint' => $this->timestampLimit->getTimestamp( TS_MW )
|
|
] );
|
|
$logId = $logEntry->insert();
|
|
$logEntry->publish( $logId );
|
|
|
|
Hooks::runner()->onArticleMergeComplete( $this->source, $this->dest );
|
|
|
|
$this->dbw->endAtomic( __METHOD__ );
|
|
|
|
return $status;
|
|
}
|
|
}
|