88 lines
2.3 KiB
PHP
88 lines
2.3 KiB
PHP
<?php
|
|
/**
|
|
* @author Antoine Musso
|
|
* @copyright Copyright © 2013, Antoine Musso
|
|
* @copyright Copyright © 2013, Wikimedia Foundation Inc.
|
|
* @file
|
|
*/
|
|
|
|
class MWExceptionHandlerTest extends \MediaWikiUnitTestCase {
|
|
|
|
private $oldSettingValue;
|
|
|
|
protected function setUp() : void {
|
|
parent::setUp();
|
|
// We need to make sure the traces have function arguments as we're testing
|
|
// their handling.
|
|
$this->oldSettingValue = ini_set( 'zend.exception_ignore_args', 0 );
|
|
}
|
|
|
|
protected function tearDown() : void {
|
|
ini_set( 'zend.exception_ignore_args', $this->oldSettingValue );
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* @covers MWExceptionHandler::getRedactedTrace
|
|
*/
|
|
public function testGetRedactedTrace() {
|
|
$refvar = 'value';
|
|
try {
|
|
$array = [ 'a', 'b' ];
|
|
$object = (object)[];
|
|
self::helperThrowAnException( $array, $object, $refvar );
|
|
} catch ( Exception $e ) {
|
|
}
|
|
|
|
# Make sure our stack trace contains an array and an object passed to
|
|
# some function in the stacktrace. Else, we can not assert the trace
|
|
# redaction achieved its job.
|
|
$trace = $e->getTrace();
|
|
$hasObject = false;
|
|
$hasArray = false;
|
|
foreach ( $trace as $frame ) {
|
|
if ( !isset( $frame['args'] ) ) {
|
|
continue;
|
|
}
|
|
foreach ( $frame['args'] as $arg ) {
|
|
$hasObject = $hasObject || is_object( $arg );
|
|
$hasArray = $hasArray || is_array( $arg );
|
|
}
|
|
|
|
if ( $hasObject && $hasArray ) {
|
|
break;
|
|
}
|
|
}
|
|
$this->assertTrue( $hasObject,
|
|
"The stacktrace must contain a function having an object as a parameter" );
|
|
$this->assertTrue( $hasArray,
|
|
"The stacktrace must contain a function having an array as a parameter" );
|
|
|
|
# Now we redact the trace.. and make sure no function arguments are
|
|
# arrays or objects.
|
|
$redacted = MWExceptionHandler::getRedactedTrace( $e );
|
|
|
|
foreach ( $redacted as $frame ) {
|
|
if ( !isset( $frame['args'] ) ) {
|
|
continue;
|
|
}
|
|
foreach ( $frame['args'] as $arg ) {
|
|
$this->assertIsNotArray( $arg );
|
|
$this->assertIsNotObject( $arg );
|
|
}
|
|
}
|
|
|
|
$this->assertEquals( 'value', $refvar, 'Ensuring reference variable wasn\'t changed' );
|
|
}
|
|
|
|
/**
|
|
* Helper function for testExpandArgumentsInCall
|
|
*
|
|
* Pass it an object and an array, and something by reference :-)
|
|
*
|
|
* @throws Exception
|
|
*/
|
|
protected static function helperThrowAnException( $a, $b, &$c ) {
|
|
throw new Exception();
|
|
}
|
|
}
|